Re: [PATCH net-next] virtio_net: don't reset twice on XDP on/off

[Jason Wang]

On 2017年03月30日 04:14, Michael S. Tsirkin wrote:

We already do a reset once in remove_vq_common -
there appears to be no point in doing another one
when we add/remove XDP.

Signed-off-by: Michael S. Tsirkin 
---
  drivers/net/virtio_net.c | 1 -
  1 file changed, 1 deletion(-)

diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index de42e9a..ed8f548 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -1810,7 +1810,6 @@ static int virtnet_reset(struct virtnet_info *vi, int 
curr_qp, int xdp_qp)
virtnet_freeze_down(dev);
_remove_vq_common(vi);
  
-	dev->config->reset(dev);

virtio_add_status(dev, VIRTIO_CONFIG_S_ACKNOWLEDGE);
virtio_add_status(dev, VIRTIO_CONFIG_S_DRIVER);
  


Acked-by: Jason Wang 

[PATCH net-next] virtio_net: don't reset twice on XDP on/off

[Michael S. Tsirkin]

We already do a reset once in remove_vq_common -
there appears to be no point in doing another one
when we add/remove XDP.

Signed-off-by: Michael S. Tsirkin 
---
 drivers/net/virtio_net.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index de42e9a..ed8f548 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -1810,7 +1810,6 @@ static int virtnet_reset(struct virtnet_info *vi, int 
curr_qp, int xdp_qp)
virtnet_freeze_down(dev);
_remove_vq_common(vi);
 
-   dev->config->reset(dev);
virtio_add_status(dev, VIRTIO_CONFIG_S_ACKNOWLEDGE);
virtio_add_status(dev, VIRTIO_CONFIG_S_DRIVER);
 
-- 
MST