Re: [PATCH net-next 0/2] Extract IFE logic to module
No objections here. On Fri, Feb 3, 2017 at 2:02 PM, Jamal Hadi Salim wrote: > On 17-02-02 06:12 AM, Yotam Gigi wrote: >>> >>> -Original Message- > > >>> >>> I have no objection to this modularisation but I am curious to know >>> if you have a use-case in mind. My understanding is that earlier versions >>> of the sample action used IFE but that is not the case in the version >>> that >>> was ultimately accepted. >> >> >> Hi Simon. >> >> You are right that the patches were done for the former version of the >> sample >> classifier, and there are not required for the current version. We don't >> have >> current use-case in mind, but I did send the patches because I think it >> can help >> others, or us in the future. > > > For what its worth given Yotam has done this work and vetted it and weve > reviewed and discussed it in the past, I am going to sign off on it. > > > cheers, > jamal >
Re: [PATCH net-next 0/2] Extract IFE logic to module
On 17-02-02 06:12 AM, Yotam Gigi wrote: -Original Message- I have no objection to this modularisation but I am curious to know if you have a use-case in mind. My understanding is that earlier versions of the sample action used IFE but that is not the case in the version that was ultimately accepted. Hi Simon. You are right that the patches were done for the former version of the sample classifier, and there are not required for the current version. We don't have current use-case in mind, but I did send the patches because I think it can help others, or us in the future. For what its worth given Yotam has done this work and vetted it and weve reviewed and discussed it in the past, I am going to sign off on it. cheers, jamal
RE: [PATCH net-next 0/2] Extract IFE logic to module
>-Original Message- >From: Simon Horman [mailto:simon.hor...@netronome.com] >Sent: Thursday, February 02, 2017 12:17 PM >To: Yotam Gigi >Cc: j...@mojatatu.com; da...@davemloft.net; netdev@vger.kernel.org; Jiri Pirko >; Elad Raz ; Ido Schimmel > >Subject: Re: [PATCH net-next 0/2] Extract IFE logic to module > >Hi Yotam, > >On Tue, Jan 31, 2017 at 03:57:02PM +0200, Yotam Gigi wrote: >> Extract ife logic from the tc_ife action into an independent module, and >> make the tc_ife action use it. This way, the ife encapsulation can be used >> by other modules other than tc_ife action. > >I have no objection to this modularisation but I am curious to know >if you have a use-case in mind. My understanding is that earlier versions >of the sample action used IFE but that is not the case in the version that >was ultimately accepted. Hi Simon. You are right that the patches were done for the former version of the sample classifier, and there are not required for the current version. We don't have current use-case in mind, but I did send the patches because I think it can help others, or us in the future.
Re: [PATCH net-next 0/2] Extract IFE logic to module
Hi Yotam, On Tue, Jan 31, 2017 at 03:57:02PM +0200, Yotam Gigi wrote: > Extract ife logic from the tc_ife action into an independent module, and > make the tc_ife action use it. This way, the ife encapsulation can be used > by other modules other than tc_ife action. I have no objection to this modularisation but I am curious to know if you have a use-case in mind. My understanding is that earlier versions of the sample action used IFE but that is not the case in the version that was ultimately accepted.
[PATCH net-next 0/2] Extract IFE logic to module
Extract ife logic from the tc_ife action into an independent module, and make the tc_ife action use it. This way, the ife encapsulation can be used by other modules other than tc_ife action. Yotam Gigi (2): net: Introduce ife encapsulation module net/sched: act_ife: Change to use ife module MAINTAINERS| 7 ++ include/net/ife.h | 51 + include/net/tc_act/tc_ife.h| 3 - include/uapi/linux/Kbuild | 1 + include/uapi/linux/ife.h | 18 + include/uapi/linux/tc_act/tc_ife.h | 10 +-- net/Kconfig| 1 + net/Makefile | 1 + net/ife/Kconfig| 16 + net/ife/Makefile | 5 ++ net/ife/ife.c | 142 + net/sched/Kconfig | 1 + net/sched/act_ife.c| 110 +--- 13 files changed, 276 insertions(+), 90 deletions(-) create mode 100644 include/net/ife.h create mode 100644 include/uapi/linux/ife.h create mode 100644 net/ife/Kconfig create mode 100644 net/ife/Makefile create mode 100644 net/ife/ife.c -- 2.4.11
