Re: [PATCH net-next 0/3] tcp: take a bit more care of backlog stress
On Fri, Nov 23, 2018 at 11:25 AM David Miller wrote: > My impression is that patch #2 needs some fixes in order to not > lose dupacks. So there will be a respin of this. > > Thanks. You are absolutely right, we will submit a v2 next week after TG holidays. Thanks.
Re: [PATCH net-next 0/3] tcp: take a bit more care of backlog stress
From: Eric Dumazet Date: Wed, 21 Nov 2018 09:52:37 -0800 > While working on the SACK compression issue Jean-Louis Dupond > reported, we found that his linux box was suffering very hard > from tail drops on the socket backlog queue, because the opposite > TCP stack was ont implementing latest RFC recommendations. > > First patch is a cleanup > > Second patch is attempting coalescing when a new packet must > be added to the backlog queue. Cooking bigger skbs helps > to keep backlog list smaller and speeds its handling when > user thread finally releases the socket lock. > > Third patch is implementing head drop as a last resort. > Head drops are generally better for optimal TCP behavior. My impression is that patch #2 needs some fixes in order to not lose dupacks. So there will be a respin of this. Thanks.
[PATCH net-next 0/3] tcp: take a bit more care of backlog stress
While working on the SACK compression issue Jean-Louis Dupond reported, we found that his linux box was suffering very hard from tail drops on the socket backlog queue, because the opposite TCP stack was ont implementing latest RFC recommendations. First patch is a cleanup Second patch is attempting coalescing when a new packet must be added to the backlog queue. Cooking bigger skbs helps to keep backlog list smaller and speeds its handling when user thread finally releases the socket lock. Third patch is implementing head drop as a last resort. Head drops are generally better for optimal TCP behavior. Eric Dumazet (3): tcp: remove hdrlen argument from tcp_queue_rcv() tcp: implement coalescing on backlog queue tcp: implement head drops in backlog queue include/uapi/linux/snmp.h | 1 + net/ipv4/proc.c | 1 + net/ipv4/tcp_input.c | 13 +++--- net/ipv4/tcp_ipv4.c | 89 --- 4 files changed, 91 insertions(+), 13 deletions(-) -- 2.19.1.1215.g8438c0b245-goog
