Re: [PATCH net-next 0/5] fib_rules: support sport, dport and ip proto match
On Sun, Feb 25, 2018 at 7:20 PM, David Ahern wrote: > On 2/24/18 10:44 PM, Roopa Prabhu wrote: >> From: Roopa Prabhu >> >> This series extends fib rule match support to include sport, dport >> and ip proto match (to complete the 5-tuple match support). >> Common use-cases of Policy based routing in the data center require >> 5-tuple match. The last 2 patches in the series add a call to flow dissect >> in the fwd path if required by the installed fib rules (controlled by a >> flag). >> >> v1: >> - Fix errors reported by kbuild and feedback on RFC series >> - extend port match uapi to accomodate port ranges > > Would be good to have a test script under tools/testing/selftests/net > that covers expectations for good and bad cases. Can create one based on > tools/testing/selftests/net/fib-onlink-tests.sh yep, that would help. Let me see if I can change my current bash test script to selftests
Re: [PATCH net-next 0/5] fib_rules: support sport, dport and ip proto match
On 2/24/18 10:44 PM, Roopa Prabhu wrote: > From: Roopa Prabhu > > This series extends fib rule match support to include sport, dport > and ip proto match (to complete the 5-tuple match support). > Common use-cases of Policy based routing in the data center require > 5-tuple match. The last 2 patches in the series add a call to flow dissect > in the fwd path if required by the installed fib rules (controlled by a flag). > > v1: > - Fix errors reported by kbuild and feedback on RFC series > - extend port match uapi to accomodate port ranges Would be good to have a test script under tools/testing/selftests/net that covers expectations for good and bad cases. Can create one based on tools/testing/selftests/net/fib-onlink-tests.sh
[PATCH net-next 0/5] fib_rules: support sport, dport and ip proto match
From: Roopa Prabhu This series extends fib rule match support to include sport, dport and ip proto match (to complete the 5-tuple match support). Common use-cases of Policy based routing in the data center require 5-tuple match. The last 2 patches in the series add a call to flow dissect in the fwd path if required by the installed fib rules (controlled by a flag). v1: - Fix errors reported by kbuild and feedback on RFC series - extend port match uapi to accomodate port ranges Roopa Prabhu (5): net: fib_rules: support for match on ip_proto, sport and dport ipv4: fib_rules: support match on sport, dport and ip proto ipv6: fib6_rules: support for match on sport, dport and ip proto ipv4: route: dissect flow in input path if fib rules need it ipv6: route: dissect flow in input path if fib rules need it include/net/fib_rules.h| 31 +- include/net/ip6_route.h| 3 +- include/net/ip_fib.h | 2 +- include/net/netns/ipv4.h | 1 + include/net/netns/ipv6.h | 1 + include/uapi/linux/fib_rules.h | 8 net/core/fib_rules.c | 95 +- net/ipv4/fib_rules.c | 15 +++ net/ipv4/fib_semantics.c | 2 +- net/ipv4/route.c | 52 --- net/ipv6/fib6_rules.c | 14 +++ net/ipv6/icmp.c| 2 +- net/ipv6/route.c | 45 13 files changed, 241 insertions(+), 30 deletions(-) -- 2.1.4
