[PATCH net-next 01/13] net: ethernet: aquantia: Removed extra assignment for skb->dev.

2017-02-15 Thread Pavel Belous 
From: Pavel Belous 

This assignment is not needed.

Signed-off-by: Pavel Belous 
---
 drivers/net/ethernet/aquantia/atlantic/aq_ring.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_ring.c 
b/drivers/net/ethernet/aquantia/atlantic/aq_ring.c
index dea9e9b..4c40644 100644
--- a/drivers/net/ethernet/aquantia/atlantic/aq_ring.c
+++ b/drivers/net/ethernet/aquantia/atlantic/aq_ring.c
@@ -214,7 +214,6 @@ int aq_ring_rx_clean(struct aq_ring_s *self, int 
*work_done, int budget)
goto err_exit;
}
 
-   skb->dev = ndev;
skb_put(skb, buff->len);
} else {
skb = netdev_alloc_skb(ndev, ETH_HLEN);
-- 
2.7.4

Re: [PATCH net-next 01/13] net: ethernet: aquantia: Removed extra assignment for skb->dev.

2017-02-15 Thread Lino Sanfilippo 

Hi,

On 15.02.2017 21:01, Pavel Belous wrote:

From: Pavel Belous 

This assignment is not needed.

Signed-off-by: Pavel Belous 
---
 drivers/net/ethernet/aquantia/atlantic/aq_ring.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_ring.c 
b/drivers/net/ethernet/aquantia/atlantic/aq_ring.c
index dea9e9b..4c40644 100644
--- a/drivers/net/ethernet/aquantia/atlantic/aq_ring.c
+++ b/drivers/net/ethernet/aquantia/atlantic/aq_ring.c
@@ -214,7 +214,6 @@ int aq_ring_rx_clean(struct aq_ring_s *self, int 
*work_done, int budget)
goto err_exit;
}

-   skb->dev = ndev;
skb_put(skb, buff->len);
} else {
skb = netdev_alloc_skb(ndev, ETH_HLEN);



Reviewed-by: Lino Sanfilippo