Re: [PATCH net-next 2/3] smsc95xx: Add register define

2016-09-06 Thread David Miller 
From: Joe Perches 
Date: Fri, 02 Sep 2016 13:40:01 -0700

> On Fri, 2016-09-02 at 20:34 +, woojung@microchip.com wrote:
>> From: Woojung Huh 
>> 
>> Add STRAP_STATUS defines.
> []
>> diff --git a/drivers/net/usb/smsc95xx.h b/drivers/net/usb/smsc95xx.h
> []
>> @@ -144,6 +144,14 @@
>>  
>>  #define BURST_CAP   (0x38)
>>  
>> +#define STRAP_STATUS(0x3C)
>> +#define STRAP_STATUS_PWR_SEL_   (0x0020)
>> +#define STRAP_STATUS_AMDIX_EN_  (0x0010)
>> +#define STRAP_STATUS_PORT_SWAP_ (0x0008)
>> +#define STRAP_STATUS_EEP_SIZE_  (0x0004)
>> +#define STRAP_STATUS_RMT_WKP_   (0x0002)
>> +#define STRAP_STATUS_EEP_DISABLE_   (0x0001)
> 
> Using BIT would be more common.
> 
> Ending the #defines with an underscore is just odd
> and unappealing.

But that's what the rest of this file is doing already.

If we want to change this, it's a separate follow-up change.

Re: [PATCH net-next 2/3] smsc95xx: Add register define

2016-09-02 Thread Joe Perches 
On Fri, 2016-09-02 at 20:34 +, woojung@microchip.com wrote:
> From: Woojung Huh 
> 
> Add STRAP_STATUS defines.
[]
> diff --git a/drivers/net/usb/smsc95xx.h b/drivers/net/usb/smsc95xx.h
[]
> @@ -144,6 +144,14 @@
>  
>  #define BURST_CAP(0x38)
>  
> +#define  STRAP_STATUS(0x3C)
> +#define  STRAP_STATUS_PWR_SEL_   (0x0020)
> +#define  STRAP_STATUS_AMDIX_EN_  (0x0010)
> +#define  STRAP_STATUS_PORT_SWAP_ (0x0008)
> +#define  STRAP_STATUS_EEP_SIZE_  (0x0004)
> +#define  STRAP_STATUS_RMT_WKP_   (0x0002)
> +#define  STRAP_STATUS_EEP_DISABLE_   (0x0001)

Using BIT would be more common.

Ending the #defines with an underscore is just odd
and unappealing.

[PATCH net-next 2/3] smsc95xx: Add register define

2016-09-02 Thread Woojung.Huh 
From: Woojung Huh 

Add STRAP_STATUS defines.

Signed-off-by: Woojung Huh 
---
 drivers/net/usb/smsc95xx.h | 8 
 1 file changed, 8 insertions(+)

diff --git a/drivers/net/usb/smsc95xx.h b/drivers/net/usb/smsc95xx.h
index 526faa0..29a4d9e 100644
--- a/drivers/net/usb/smsc95xx.h
+++ b/drivers/net/usb/smsc95xx.h
@@ -144,6 +144,14 @@
 
 #define BURST_CAP  (0x38)
 
+#defineSTRAP_STATUS(0x3C)
+#defineSTRAP_STATUS_PWR_SEL_   (0x0020)
+#defineSTRAP_STATUS_AMDIX_EN_  (0x0010)
+#defineSTRAP_STATUS_PORT_SWAP_ (0x0008)
+#defineSTRAP_STATUS_EEP_SIZE_  (0x0004)
+#defineSTRAP_STATUS_RMT_WKP_   (0x0002)
+#defineSTRAP_STATUS_EEP_DISABLE_   (0x0001)
+
 #define GPIO_WAKE  (0x64)
 
 #define INT_EP_CTL (0x68)
-- 
2.7.4