Re: [PATCH net-next 3/6] net: use core MTU range checking in WAN drivers

2016-10-21 Thread Krzysztof HaƂasa
Jarod Wilson  writes:

> - set min/max_mtu in all hdlc drivers, remove hdlc_change_mtu
> - sent max_mtu in lec driver, remove lec_change_mtu

>  drivers/net/wan/c101.c|  1 -
>  drivers/net/wan/hdlc.c| 11 ++-
>  drivers/net/wan/hdlc_fr.c |  3 ++-
>  drivers/net/wan/ixp4xx_hss.c  |  1 -
>  drivers/net/wan/n2.c  |  1 -
>  drivers/net/wan/pc300too.c|  1 -
>  drivers/net/wan/pci200syn.c   |  1 -
>  drivers/net/wan/wanxl.c   |  1 -
>  include/linux/hdlc.h  |  2 --

Acked-by: Krzysztof Halasa 
-- 
Krzysztof Halasa

Industrial Research Institute for Automation and Measurements PIAP
Al. Jerozolimskie 202, 02-486 Warsaw, Poland


[PATCH net-next 3/6] net: use core MTU range checking in WAN drivers

2016-10-18 Thread Jarod Wilson
- set min/max_mtu in all hdlc drivers, remove hdlc_change_mtu
- sent max_mtu in lec driver, remove lec_change_mtu

CC: netdev@vger.kernel.org
CC: Krzysztof Halasa 
CC: Krzysztof Halasa 
CC: Jan "Yenya" Kasprzak 
CC: Francois Romieu 
CC: Kevin Curtis 
CC: Zhao Qiang 
Signed-off-by: Jarod Wilson 
---
 drivers/char/pcmcia/synclink_cs.c |  1 -
 drivers/net/wan/c101.c|  1 -
 drivers/net/wan/cosa.c|  1 -
 drivers/net/wan/dscc4.c   |  1 -
 drivers/net/wan/farsync.c |  1 -
 drivers/net/wan/fsl_ucc_hdlc.c|  1 -
 drivers/net/wan/hdlc.c| 11 ++-
 drivers/net/wan/hdlc_fr.c |  3 ++-
 drivers/net/wan/hostess_sv11.c|  1 -
 drivers/net/wan/ixp4xx_hss.c  |  1 -
 drivers/net/wan/lmc/lmc_main.c|  1 -
 drivers/net/wan/n2.c  |  1 -
 drivers/net/wan/pc300too.c|  1 -
 drivers/net/wan/pci200syn.c   |  1 -
 drivers/net/wan/sealevel.c|  1 -
 drivers/net/wan/wanxl.c   |  1 -
 drivers/tty/synclink.c|  1 -
 drivers/tty/synclink_gt.c |  1 -
 drivers/tty/synclinkmp.c  |  1 -
 include/linux/hdlc.h  |  2 --
 net/atm/lec.c | 11 +--
 21 files changed, 5 insertions(+), 39 deletions(-)

diff --git a/drivers/char/pcmcia/synclink_cs.c 
b/drivers/char/pcmcia/synclink_cs.c
index d28922d..a7dd5f4 100644
--- a/drivers/char/pcmcia/synclink_cs.c
+++ b/drivers/char/pcmcia/synclink_cs.c
@@ -4248,7 +4248,6 @@ static void hdlcdev_rx(MGSLPC_INFO *info, char *buf, int 
size)
 static const struct net_device_ops hdlcdev_ops = {
.ndo_open   = hdlcdev_open,
.ndo_stop   = hdlcdev_close,
-   .ndo_change_mtu = hdlc_change_mtu,
.ndo_start_xmit = hdlc_start_xmit,
.ndo_do_ioctl   = hdlcdev_ioctl,
.ndo_tx_timeout = hdlcdev_tx_timeout,
diff --git a/drivers/net/wan/c101.c b/drivers/net/wan/c101.c
index 09a5075..2371e07 100644
--- a/drivers/net/wan/c101.c
+++ b/drivers/net/wan/c101.c
@@ -302,7 +302,6 @@ static void c101_destroy_card(card_t *card)
 static const struct net_device_ops c101_ops = {
.ndo_open   = c101_open,
.ndo_stop   = c101_close,
-   .ndo_change_mtu = hdlc_change_mtu,
.ndo_start_xmit = hdlc_start_xmit,
.ndo_do_ioctl   = c101_ioctl,
 };
diff --git a/drivers/net/wan/cosa.c b/drivers/net/wan/cosa.c
index b87fe0a..087eb26 100644
--- a/drivers/net/wan/cosa.c
+++ b/drivers/net/wan/cosa.c
@@ -432,7 +432,6 @@ module_exit(cosa_exit);
 static const struct net_device_ops cosa_ops = {
.ndo_open   = cosa_net_open,
.ndo_stop   = cosa_net_close,
-   .ndo_change_mtu = hdlc_change_mtu,
.ndo_start_xmit = hdlc_start_xmit,
.ndo_do_ioctl   = cosa_net_ioctl,
.ndo_tx_timeout = cosa_net_timeout,
diff --git a/drivers/net/wan/dscc4.c b/drivers/net/wan/dscc4.c
index 6292259..7351e54 100644
--- a/drivers/net/wan/dscc4.c
+++ b/drivers/net/wan/dscc4.c
@@ -887,7 +887,6 @@ static inline int dscc4_set_quartz(struct dscc4_dev_priv 
*dpriv, int hz)
 static const struct net_device_ops dscc4_ops = {
.ndo_open   = dscc4_open,
.ndo_stop   = dscc4_close,
-   .ndo_change_mtu = hdlc_change_mtu,
.ndo_start_xmit = hdlc_start_xmit,
.ndo_do_ioctl   = dscc4_ioctl,
.ndo_tx_timeout = dscc4_tx_timeout,
diff --git a/drivers/net/wan/farsync.c b/drivers/net/wan/farsync.c
index 3c9cbf9..03696d3 100644
--- a/drivers/net/wan/farsync.c
+++ b/drivers/net/wan/farsync.c
@@ -2394,7 +2394,6 @@ fst_init_card(struct fst_card_info *card)
 static const struct net_device_ops fst_ops = {
.ndo_open   = fst_open,
.ndo_stop   = fst_close,
-   .ndo_change_mtu = hdlc_change_mtu,
.ndo_start_xmit = hdlc_start_xmit,
.ndo_do_ioctl   = fst_ioctl,
.ndo_tx_timeout = fst_tx_timeout,
diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c
index 6564753..e38ce4d 100644
--- a/drivers/net/wan/fsl_ucc_hdlc.c
+++ b/drivers/net/wan/fsl_ucc_hdlc.c
@@ -992,7 +992,6 @@ static const struct dev_pm_ops uhdlc_pm_ops = {
 static const struct net_device_ops uhdlc_ops = {
.ndo_open   = uhdlc_open,
.ndo_stop   = uhdlc_close,
-   .ndo_change_mtu = hdlc_change_mtu,
.ndo_start_xmit = hdlc_start_xmit,
.ndo_do_ioctl   = uhdlc_ioctl,
 };
diff --git a/drivers/net/wan/hdlc.c b/drivers/net/wan/hdlc.c
index 9bd4aa8..7221a53 100644
--- a/drivers/net/wan/hdlc.c
+++ b/drivers/net/wan/hdlc.c
@@ -46,14 +46,6 @@ static const char* version = "HDLC support module revision 
1.22";
 
 static struct hdlc_proto *first_proto;
 
-int hdlc_change_mtu(struct net_device *dev, int new_mtu)
-{
-   if ((new_mtu < 68) || (new_mtu > HDLC_MAX_MTU))
-   return -EINVAL;
-   dev->mtu = new_mtu;
-   return 0;
-}
-
 static int hdlc_rcv(struct sk_buff *skb, struct net_device *dev,
struct packet_type *p, struct net_device *orig_dev)
 {
@@ -237,6 +229