RE: [PATCH net-next V3 02/16] net: fec: remove unused interrupt FEC_ENET_TS_TIMER

[Fugang Duan]

From: Troy Kisky <troy.ki...@boundarydevices.com> Sent: Wednesday, April 06, 
2016 10:26 AM
> To: netdev@vger.kernel.org; da...@davemloft.net; Fugang Duan
> <fugang.d...@nxp.com>; lzn...@gmail.com
> Cc: Fabio Estevam <fabio.este...@nxp.com>; l.st...@pengutronix.de;
> and...@lunn.ch; trem...@gmail.com; g...@uclinux.org; linux-arm-
> ker...@lists.infradead.org; johan...@sipsolutions.net;
> stillcompil...@gmail.com; sergei.shtyl...@cogentembedded.com;
> a...@arndb.de; Troy Kisky <troy.ki...@boundarydevices.com>
> Subject: [PATCH net-next V3 02/16] net: fec: remove unused interrupt
> FEC_ENET_TS_TIMER
> 
> FEC_ENET_TS_TIMER is not checked in the interrupt routine so there is no need
> to enable it.
> 
> Signed-off-by: Troy Kisky <troy.ki...@boundarydevices.com>
> 
> ---
> v3: New patch
> 
> Frank Li said "TS_TIMER should never be triggered."
> when discussing another patch.
> ---
>  drivers/net/ethernet/freescale/fec.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/freescale/fec.h
> b/drivers/net/ethernet/freescale/fec.h
> index 195122e..6dd0ba8 100644
> --- a/drivers/net/ethernet/freescale/fec.h
> +++ b/drivers/net/ethernet/freescale/fec.h
> @@ -374,8 +374,8 @@ struct bufdesc_ex {
>  #define FEC_ENET_TS_AVAIL   ((uint)0x0001)
>  #define FEC_ENET_TS_TIMER   ((uint)0x8000)
> 
> -#define FEC_DEFAULT_IMASK (FEC_ENET_TXF | FEC_ENET_RXF | FEC_ENET_MII
> | FEC_ENET_TS_TIMER)
> -#define FEC_NAPI_IMASK   (FEC_ENET_MII | FEC_ENET_TS_TIMER)
> +#define FEC_DEFAULT_IMASK (FEC_ENET_TXF | FEC_ENET_RXF | FEC_ENET_MII)
> +#define FEC_NAPI_IMASK   FEC_ENET_MII
>  #define FEC_RX_DISABLED_IMASK (FEC_DEFAULT_IMASK & (~FEC_ENET_RXF))
> 
>  /* ENET interrupt coalescing macro define */
> --
> 2.5.0

Acked-by: Fugang Duan <fugang.d...@nxp.com>

[PATCH net-next V3 02/16] net: fec: remove unused interrupt FEC_ENET_TS_TIMER

[Troy Kisky]

FEC_ENET_TS_TIMER is not checked in the interrupt routine
so there is no need to enable it.

Signed-off-by: Troy Kisky 

---
v3: New patch

Frank Li said "TS_TIMER should never be triggered."
when discussing another patch.
---
 drivers/net/ethernet/freescale/fec.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/freescale/fec.h 
b/drivers/net/ethernet/freescale/fec.h
index 195122e..6dd0ba8 100644
--- a/drivers/net/ethernet/freescale/fec.h
+++ b/drivers/net/ethernet/freescale/fec.h
@@ -374,8 +374,8 @@ struct bufdesc_ex {
 #define FEC_ENET_TS_AVAIL   ((uint)0x0001)
 #define FEC_ENET_TS_TIMER   ((uint)0x8000)
 
-#define FEC_DEFAULT_IMASK (FEC_ENET_TXF | FEC_ENET_RXF | FEC_ENET_MII | 
FEC_ENET_TS_TIMER)
-#define FEC_NAPI_IMASK (FEC_ENET_MII | FEC_ENET_TS_TIMER)
+#define FEC_DEFAULT_IMASK (FEC_ENET_TXF | FEC_ENET_RXF | FEC_ENET_MII)
+#define FEC_NAPI_IMASK FEC_ENET_MII
 #define FEC_RX_DISABLED_IMASK (FEC_DEFAULT_IMASK & (~FEC_ENET_RXF))
 
 /* ENET interrupt coalescing macro define */
-- 
2.5.0