Re: [PATCH net-next resubmit 2/2] net: phy: remove generic settings for callbacks config_aneg and read_status from drivers

[Florian Fainelli]

On 12/01/2017 02:37 PM, Heiner Kallweit wrote:
> Am 01.12.2017 um 21:42 schrieb David Miller:
>> From: Heiner Kallweit 
>> Date: Thu, 30 Nov 2017 23:47:52 +0100
>>
>>> Remove generic settings for callbacks config_aneg and read_status
>>> from drivers.
>>>
> When re-testing I just figured out that in drivers/net/phy/broadcom.c
> I mistakenly removed three lines too many.
> Do you prefer a fixed version of the patch or just a patch with the
> fix?

Once the patches has been applied by David, you should send an
incremental change to fix your previous patches. Thank you.
-- 
Florian

Re: [PATCH net-next resubmit 2/2] net: phy: remove generic settings for callbacks config_aneg and read_status from drivers

[Heiner Kallweit]

Am 01.12.2017 um 21:42 schrieb David Miller:
> From: Heiner Kallweit 
> Date: Thu, 30 Nov 2017 23:47:52 +0100
> 
>> Remove generic settings for callbacks config_aneg and read_status
>> from drivers.
>>
When re-testing I just figured out that in drivers/net/phy/broadcom.c
I mistakenly removed three lines too many.
Do you prefer a fixed version of the patch or just a patch with the
fix?

Sorry, Heiner

>> Signed-off-by: Heiner Kallweit 
>> Reviewed-by: Florian Fainelli 
> 
> Applied.
> 

Re: [PATCH net-next resubmit 2/2] net: phy: remove generic settings for callbacks config_aneg and read_status from drivers

[David Miller]

From: Heiner Kallweit 
Date: Thu, 30 Nov 2017 23:47:52 +0100

> Remove generic settings for callbacks config_aneg and read_status
> from drivers.
> 
> Signed-off-by: Heiner Kallweit 
> Reviewed-by: Florian Fainelli 

Applied.

[PATCH net-next resubmit 2/2] net: phy: remove generic settings for callbacks config_aneg and read_status from drivers

[Heiner Kallweit]

Remove generic settings for callbacks config_aneg and read_status
from drivers.

Signed-off-by: Heiner Kallweit 
Reviewed-by: Florian Fainelli 
---
 drivers/net/phy/amd.c|  2 --
 drivers/net/phy/at803x.c |  6 --
 drivers/net/phy/bcm-cygnus.c |  2 --
 drivers/net/phy/bcm63xx.c|  4 
 drivers/net/phy/bcm7xxx.c|  6 --
 drivers/net/phy/broadcom.c   | 30 --
 drivers/net/phy/cicada.c |  4 
 drivers/net/phy/davicom.c|  5 -
 drivers/net/phy/dp83640.c|  2 --
 drivers/net/phy/dp83822.c|  2 --
 drivers/net/phy/dp83848.c|  2 --
 drivers/net/phy/dp83867.c|  2 --
 drivers/net/phy/icplus.c |  4 
 drivers/net/phy/intel-xway.c | 12 
 drivers/net/phy/lxt.c|  5 -
 drivers/net/phy/marvell.c|  9 -
 drivers/net/phy/meson-gxl.c  |  2 --
 drivers/net/phy/micrel.c | 24 
 drivers/net/phy/microchip.c  |  1 -
 drivers/net/phy/national.c   |  2 --
 drivers/net/phy/phy_device.c |  2 --
 drivers/net/phy/qsemi.c  |  2 --
 drivers/net/phy/realtek.c| 12 
 drivers/net/phy/rockchip.c   |  1 -
 drivers/net/phy/smsc.c   |  9 -
 drivers/net/phy/ste10Xp.c|  4 
 drivers/net/phy/uPD60620.c   |  1 -
 drivers/net/phy/vitesse.c| 12 
 28 files changed, 169 deletions(-)

diff --git a/drivers/net/phy/amd.c b/drivers/net/phy/amd.c
index 18141c022..6fe5dc920 100644
--- a/drivers/net/phy/amd.c
+++ b/drivers/net/phy/amd.c
@@ -68,8 +68,6 @@ static struct phy_driver am79c_driver[] = { {
.features   = PHY_BASIC_FEATURES,
.flags  = PHY_HAS_INTERRUPT,
.config_init= am79c_config_init,
-   .config_aneg= genphy_config_aneg,
-   .read_status= genphy_read_status,
.ack_interrupt  = am79c_ack_interrupt,
.config_intr= am79c_config_intr,
 } };
diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
index 5f93e6add..de7dd6566 100644
--- a/drivers/net/phy/at803x.c
+++ b/drivers/net/phy/at803x.c
@@ -408,8 +408,6 @@ static struct phy_driver at803x_driver[] = {
.resume = at803x_resume,
.features   = PHY_GBIT_FEATURES,
.flags  = PHY_HAS_INTERRUPT,
-   .config_aneg= genphy_config_aneg,
-   .read_status= genphy_read_status,
.ack_interrupt  = at803x_ack_interrupt,
.config_intr= at803x_config_intr,
 }, {
@@ -426,8 +424,6 @@ static struct phy_driver at803x_driver[] = {
.resume = at803x_resume,
.features   = PHY_BASIC_FEATURES,
.flags  = PHY_HAS_INTERRUPT,
-   .config_aneg= genphy_config_aneg,
-   .read_status= genphy_read_status,
.ack_interrupt  = at803x_ack_interrupt,
.config_intr= at803x_config_intr,
 }, {
@@ -443,8 +439,6 @@ static struct phy_driver at803x_driver[] = {
.resume = at803x_resume,
.features   = PHY_GBIT_FEATURES,
.flags  = PHY_HAS_INTERRUPT,
-   .config_aneg= genphy_config_aneg,
-   .read_status= genphy_read_status,
.aneg_done  = at803x_aneg_done,
.ack_interrupt  = _ack_interrupt,
.config_intr= _config_intr,
diff --git a/drivers/net/phy/bcm-cygnus.c b/drivers/net/phy/bcm-cygnus.c
index 3fe8cc5c1..683812983 100644
--- a/drivers/net/phy/bcm-cygnus.c
+++ b/drivers/net/phy/bcm-cygnus.c
@@ -136,8 +136,6 @@ static struct phy_driver bcm_cygnus_phy_driver[] = {
.name  = "Broadcom Cygnus PHY",
.features  = PHY_GBIT_FEATURES,
.config_init   = bcm_cygnus_config_init,
-   .config_aneg   = genphy_config_aneg,
-   .read_status   = genphy_read_status,
.ack_interrupt = bcm_phy_ack_intr,
.config_intr   = bcm_phy_config_intr,
.suspend   = genphy_suspend,
diff --git a/drivers/net/phy/bcm63xx.c b/drivers/net/phy/bcm63xx.c
index b0492ef2c..cf1461374 100644
--- a/drivers/net/phy/bcm63xx.c
+++ b/drivers/net/phy/bcm63xx.c
@@ -69,8 +69,6 @@ static struct phy_driver bcm63xx_driver[] = {
.features   = (PHY_BASIC_FEATURES | SUPPORTED_Pause),
.flags  = PHY_HAS_INTERRUPT | PHY_IS_INTERNAL,
.config_init= bcm63xx_config_init,
-   .config_aneg= genphy_config_aneg,
-   .read_status= genphy_read_status,
.ack_interrupt  = bcm_phy_ack_intr,
.config_intr= bcm63xx_config_intr,
 }, {
@@ -81,8 +79,6 @@ static struct phy_driver bcm63xx_driver[] = {
.features   = (PHY_BASIC_FEATURES | SUPPORTED_Pause),
.flags  = PHY_HAS_INTERRUPT | PHY_IS_INTERNAL,
.config_init= bcm63xx_config_init,
-   .config_aneg= genphy_config_aneg,
-   .read_status=