Re: [PATCH net-next v2] Add uid and cookie bpf helper to cg_skb_func_proto
From: Chenbo FengDate: Fri, 14 Apr 2017 18:25:26 -0700 > From: Chenbo Feng > > BPF helper functions get_socket_cookie and get_socket_uid can be > used for network traffic classifications, among others. Expose > them also to programs of type BPF_PROG_TYPE_CGROUP_SKB. As of > commit 8f917bba0042 ("bpf: pass sk to helper functions") the > required skb->sk function is available at both cgroup bpf ingress > and egress hooks. With these two new helper, cg_skb_func_proto is > effectively the same as sk_filter_func_proto. > > Change since V1: > Instead of add the helper to cg_skb_func_proto, redirect the > cg_skb_func_proto to sk_filter_func_proto since all helper function > in sk_filter_func_proto are applicable to cg_skb_func_proto now. > > Signed-off-by: Chenbo Feng Applied, thanks.
Re: [PATCH net-next v2] Add uid and cookie bpf helper to cg_skb_func_proto
On 04/15/2017 03:25 AM, Chenbo Feng wrote: From: Chenbo FengBPF helper functions get_socket_cookie and get_socket_uid can be used for network traffic classifications, among others. Expose them also to programs of type BPF_PROG_TYPE_CGROUP_SKB. As of commit 8f917bba0042 ("bpf: pass sk to helper functions") the required skb->sk function is available at both cgroup bpf ingress and egress hooks. With these two new helper, cg_skb_func_proto is effectively the same as sk_filter_func_proto. Change since V1: Instead of add the helper to cg_skb_func_proto, redirect the cg_skb_func_proto to sk_filter_func_proto since all helper function in sk_filter_func_proto are applicable to cg_skb_func_proto now. Signed-off-by: Chenbo Feng Acked-by: Daniel Borkmann
Re: [PATCH net-next v2] Add uid and cookie bpf helper to cg_skb_func_proto
On Fri, Apr 14, 2017 at 06:25:26PM -0700, Chenbo Feng wrote: > From: Chenbo Feng> > BPF helper functions get_socket_cookie and get_socket_uid can be > used for network traffic classifications, among others. Expose > them also to programs of type BPF_PROG_TYPE_CGROUP_SKB. As of > commit 8f917bba0042 ("bpf: pass sk to helper functions") the > required skb->sk function is available at both cgroup bpf ingress > and egress hooks. With these two new helper, cg_skb_func_proto is > effectively the same as sk_filter_func_proto. > > Change since V1: > Instead of add the helper to cg_skb_func_proto, redirect the > cg_skb_func_proto to sk_filter_func_proto since all helper function > in sk_filter_func_proto are applicable to cg_skb_func_proto now. > > Signed-off-by: Chenbo Feng Thanks! Acked-by: Alexei Starovoitov
[PATCH net-next v2] Add uid and cookie bpf helper to cg_skb_func_proto
From: Chenbo FengBPF helper functions get_socket_cookie and get_socket_uid can be used for network traffic classifications, among others. Expose them also to programs of type BPF_PROG_TYPE_CGROUP_SKB. As of commit 8f917bba0042 ("bpf: pass sk to helper functions") the required skb->sk function is available at both cgroup bpf ingress and egress hooks. With these two new helper, cg_skb_func_proto is effectively the same as sk_filter_func_proto. Change since V1: Instead of add the helper to cg_skb_func_proto, redirect the cg_skb_func_proto to sk_filter_func_proto since all helper function in sk_filter_func_proto are applicable to cg_skb_func_proto now. Signed-off-by: Chenbo Feng --- net/core/filter.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/net/core/filter.c b/net/core/filter.c index ce2a19d..19be954 100644 --- a/net/core/filter.c +++ b/net/core/filter.c @@ -2766,12 +2766,7 @@ xdp_func_proto(enum bpf_func_id func_id) static const struct bpf_func_proto * cg_skb_func_proto(enum bpf_func_id func_id) { - switch (func_id) { - case BPF_FUNC_skb_load_bytes: - return _skb_load_bytes_proto; - default: - return bpf_base_func_proto(func_id); - } + return sk_filter_func_proto(func_id); } static const struct bpf_func_proto * -- 2.7.4