Re: [PATCH net-next v2] bpf: cgroup: fix documentation of __cgroup_bpf_update()
From: Daniel MackDate: Mon, 28 Nov 2016 14:11:04 +0100 > There's a 'not' missing in one paragraph. Add it. > > Signed-off-by: Daniel Mack > Reported-by: Rami Rosen > Fixes: 3007098494be ("cgroup: add support for eBPF programs") Applied, thanks.
Re: [PATCH net-next v2] bpf: cgroup: fix documentation of __cgroup_bpf_update()
On Mon, Nov 28, 2016 at 02:11:04PM +0100, Daniel Mack wrote: > There's a 'not' missing in one paragraph. Add it. > > Signed-off-by: Daniel Mack> Reported-by: Rami Rosen > Fixes: 3007098494be ("cgroup: add support for eBPF programs") Acked-by: Alexei Starovoitov btw more canonical patch format is to put Fixes tag before SOB.
Re: [PATCH net-next v2] bpf: cgroup: fix documentation of __cgroup_bpf_update()
On 11/28/2016 02:11 PM, Daniel Mack wrote: There's a 'not' missing in one paragraph. Add it. Signed-off-by: Daniel MackReported-by: Rami Rosen Fixes: 3007098494be ("cgroup: add support for eBPF programs") Acked-by: Daniel Borkmann
[PATCH net-next v2] bpf: cgroup: fix documentation of __cgroup_bpf_update()
There's a 'not' missing in one paragraph. Add it. Signed-off-by: Daniel MackReported-by: Rami Rosen Fixes: 3007098494be ("cgroup: add support for eBPF programs") --- kernel/bpf/cgroup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/bpf/cgroup.c b/kernel/bpf/cgroup.c index a0ab43f..8c784f8 100644 --- a/kernel/bpf/cgroup.c +++ b/kernel/bpf/cgroup.c @@ -66,8 +66,8 @@ void cgroup_bpf_inherit(struct cgroup *cgrp, struct cgroup *parent) * Each cgroup has a set of two pointers for bpf programs; one for eBPF * programs it owns, and which is effective for execution. * - * If @prog is %NULL, this function attaches a new program to the cgroup and - * releases the one that is currently attached, if any. @prog is then made + * If @prog is not %NULL, this function attaches a new program to the cgroup + * and releases the one that is currently attached, if any. @prog is then made * the effective program of type @type in that cgroup. * * If @prog is %NULL, the currently attached program of type @type is released, -- 2.7.4