Re: [PATCH net-next v3] be2net: log link status
From: Ivan Vecera ivec...@redhat.com Date: Thu, 30 Apr 2015 11:59:49 +0200 The driver unlike other drivers does not log link state changes. It's better for an user when asynchronous link states are logged to the system log. v3: Changes from v2 discarded as not necessary Cc: Sathya Perla sathya.pe...@emulex.com Cc: Subbu Seetharaman subbu.seethara...@emulex.com Cc: Ajit Khaparde ajit.khapa...@emulex.com Signed-off-by: Ivan Vecera ivec...@redhat.com Applied. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH net-next v3] be2net: log link status
-Original Message- From: Ivan Vecera [mailto:ivec...@redhat.com] The driver unlike other drivers does not log link state changes. It's better for an user when asynchronous link states are logged in the system log. v3: Changes from v2 discarded as not necessary Cc: Sathya Perla sathya.pe...@emulex.com Cc: Subbu Seetharaman subbu.seethara...@emulex.com Cc: Ajit Khaparde ajit.khapa...@emulex.com Signed-off-by: Ivan Vecera ivec...@redhat.com Acked-by: Sathya Perla sathya.pe...@emulex.com -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH net-next v3] be2net: log link status
From: Ivan Vecera ivec...@redhat.com Date: Tue, 28 Apr 2015 21:39:32 +0200 The driver unlike other drivers does not log link state changes. It's better for an user when asynchronous link states are logged in the system log. v3: Changes from v2 discarded as not necessary Cc: Sathya Perla sathya.pe...@emulex.com Cc: Subbu Seetharaman subbu.seethara...@emulex.com Cc: Ajit Khaparde ajit.khapa...@emulex.com Signed-off-by: Ivan Vecera ivec...@redhat.com --- drivers/net/ethernet/emulex/benet/be_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c index fb0bc3c..e349131 100644 --- a/drivers/net/ethernet/emulex/benet/be_main.c +++ b/drivers/net/ethernet/emulex/benet/be_main.c @@ -662,6 +662,8 @@ void be_link_status_update(struct be_adapter *adapter, u8 link_status) Patch has been corrupted by your email client. Please fix this up and resubmit. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH net-next v3] be2net: log link status
The driver unlike other drivers does not log link state changes. It's better for an user when asynchronous link states are logged in the system log. v3: Changes from v2 discarded as not necessary Cc: Sathya Perla sathya.pe...@emulex.com Cc: Subbu Seetharaman subbu.seethara...@emulex.com Cc: Ajit Khaparde ajit.khapa...@emulex.com Signed-off-by: Ivan Vecera ivec...@redhat.com --- drivers/net/ethernet/emulex/benet/be_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c index fb0bc3c..e349131 100644 --- a/drivers/net/ethernet/emulex/benet/be_main.c +++ b/drivers/net/ethernet/emulex/benet/be_main.c @@ -662,6 +662,8 @@ void be_link_status_update(struct be_adapter *adapter, u8 link_status) netif_carrier_on(netdev); else netif_carrier_off(netdev); + + netdev_info(netdev, Link is %s\n, link_status ? Up : Down); } static void be_tx_stats_update(struct be_tx_obj *txo, struct sk_buff *skb) -- 2.0.5 -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html