[PATCH net 0/3] qed: Fix dependencies and warnings series
Hi Dave, The first patch in this series follows Dan Carpenter's reports about Smatch warnings for recent qed additions and fixes those. The second patch is the most significant one [and the reason this is ntended for 'net'] - it's based on Arnd Bermann's suggestion for fixing compilation issues that were introduced with the roce addition as a result of certain combinations of qed, qede and qedr Kconfig options. The third follows the discussion with Arnd and clears a lot of the warnings that arise when compiling the drivers with "C=1". Please consider applying this series to 'net'. Thanks, Yuval Yuval Mintz (3): qed: Fix static checker warning. qed*: Fix Kconfig dependencies with INFINIBAND_QEDR qed: Additional work toward cleaning C=1 drivers/net/ethernet/qlogic/Kconfig | 4 + drivers/net/ethernet/qlogic/qed/Makefile| 2 +- drivers/net/ethernet/qlogic/qed/qed_cxt.c | 15 +- drivers/net/ethernet/qlogic/qed/qed_debug.c | 53 +++ drivers/net/ethernet/qlogic/qed/qed_dev.c | 19 +-- drivers/net/ethernet/qlogic/qed/qed_ll2.c | 16 +-- drivers/net/ethernet/qlogic/qed/qed_ll2.h | 20 --- drivers/net/ethernet/qlogic/qed/qed_main.c | 30 ++-- drivers/net/ethernet/qlogic/qed/qed_roce.c | 216 drivers/net/ethernet/qlogic/qed/qed_roce.h | 95 ++-- drivers/net/ethernet/qlogic/qed/qed_sp.h| 1 - drivers/net/ethernet/qlogic/qed/qed_spq.c | 4 - drivers/net/ethernet/qlogic/qede/Makefile | 2 +- include/linux/qed/qede_roce.h | 2 +- 14 files changed, 179 insertions(+), 300 deletions(-) -- 1.9.3
Re: [PATCH net 0/3] qed: Fix dependencies and warnings series
On Thursday, October 13, 2016 10:57:00 PM CEST Yuval Mintz wrote: > Hi Dave, > > The first patch in this series follows Dan Carpenter's reports about > Smatch warnings for recent qed additions and fixes those. > > The second patch is the most significant one [and the reason this is > ntended for 'net'] - it's based on Arnd Bermann's suggestion for fixing > compilation issues that were introduced with the roce addition as a result > of certain combinations of qed, qede and qedr Kconfig options. > > The third follows the discussion with Arnd and clears a lot of the warnings > that arise when compiling the drivers with "C=1". > > Please consider applying this series to 'net'. > I've put all three patches into my randconfig test tree for double-checking, but looking at the patches I'm fairly sure they are good. I'll let you know within a few hours if something breaks unexpectedly. Thanks for picking up my suggestions! Acked-by: Arnd Bergmann
Re: [PATCH net 0/3] qed: Fix dependencies and warnings series
From: Yuval Mintz Date: Thu, 13 Oct 2016 22:57:00 +0300 > The first patch in this series follows Dan Carpenter's reports about > Smatch warnings for recent qed additions and fixes those. > > The second patch is the most significant one [and the reason this is > ntended for 'net'] - it's based on Arnd Bermann's suggestion for fixing > compilation issues that were introduced with the roce addition as a result > of certain combinations of qed, qede and qedr Kconfig options. > > The third follows the discussion with Arnd and clears a lot of the warnings > that arise when compiling the drivers with "C=1". > > Please consider applying this series to 'net'. Series applied, thanks.