Re: [PATCH v2 3/3] ARM: zynq: DT: Use the zynq binding with macb

2015-05-25 Thread Sören Brinkmann 
On Fri, 2015-05-22 at 09:22AM -0500, Nathan Sullivan wrote:
 Use the new zynq binding for macb ethernet, since it will disable half
 duplex gigabit like the Zynq TRM says to do.
 
 Signed-off-by: Nathan Sullivan nathan.sulli...@ni.com
 ---
  arch/arm/boot/dts/zynq-7000.dtsi |4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
 
 diff --git a/arch/arm/boot/dts/zynq-7000.dtsi 
 b/arch/arm/boot/dts/zynq-7000.dtsi
 index a5cd2ed..9ea54b3 100644
 --- a/arch/arm/boot/dts/zynq-7000.dtsi
 +++ b/arch/arm/boot/dts/zynq-7000.dtsi
 @@ -193,7 +193,7 @@
   };
  
   gem0: ethernet@e000b000 {
 - compatible = cdns,gem;
 + compatible = cdns,zynq-gem;

Please, prepend the new string to the compatible list. Don't just
replace it like this.

   reg = 0xe000b000 0x1000;
   status = disabled;
   interrupts = 0 22 4;
 @@ -204,7 +204,7 @@
   };
  
   gem1: ethernet@e000c000 {
 - compatible = cdns,gem;
 + compatible = cdns,zynq-gem;

ditto

Sören
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2 3/3] ARM: zynq: DT: Use the zynq binding with macb

2015-05-22 Thread Nathan Sullivan 
Use the new zynq binding for macb ethernet, since it will disable half
duplex gigabit like the Zynq TRM says to do.

Signed-off-by: Nathan Sullivan nathan.sulli...@ni.com
---
 arch/arm/boot/dts/zynq-7000.dtsi |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi
index a5cd2ed..9ea54b3 100644
--- a/arch/arm/boot/dts/zynq-7000.dtsi
+++ b/arch/arm/boot/dts/zynq-7000.dtsi
@@ -193,7 +193,7 @@
};
 
gem0: ethernet@e000b000 {
-   compatible = cdns,gem;
+   compatible = cdns,zynq-gem;
reg = 0xe000b000 0x1000;
status = disabled;
interrupts = 0 22 4;
@@ -204,7 +204,7 @@
};
 
gem1: ethernet@e000c000 {
-   compatible = cdns,gem;
+   compatible = cdns,zynq-gem;
reg = 0xe000c000 0x1000;
status = disabled;
interrupts = 0 45 4;
-- 
1.7.10.4

--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html