Re: [PATCH v2 Resend] net/fddi: remove HWM_REVERSE() macro

2015-08-11 Thread yalin wang
HWM_REVERSE() macro is unused, remove it.

Signed-off-by: yalin wang yalin.wang2...@gmail.com
---
 drivers/net/fddi/skfp/h/hwmtm.h | 9 -
 1 file changed, 9 deletions(-)

diff --git a/drivers/net/fddi/skfp/h/hwmtm.h b/drivers/net/fddi/skfp/h/hwmtm.h
index 5924d42..4ca2341 100644
--- a/drivers/net/fddi/skfp/h/hwmtm.h
+++ b/drivers/net/fddi/skfp/h/hwmtm.h
@@ -74,15 +74,6 @@
 #define NULL   0
 #endif
 
-#ifdef LITTLE_ENDIAN
-#define HWM_REVERSE(x) (x)
-#else
-#defineHWM_REVERSE(x)  x)24L)0xff00L)   +   
\
-(((x) 8L)0x00ffL)   +   \
-(((x) 8L)0xff00L)   +   \
-(((x)24L)0x00ffL))
-#endif
-
 #define C_INDIC(1L25)
 #define A_INDIC(1L26)
 #defineRD_FS_LOCAL 0x80
-- 
1.9.1















--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH v2 Resend] net/fddi: remove HWM_REVERSE() macro

2015-08-10 Thread yalin wang
HWM_REVERSE() macro is unused, remove it.

Signed-off-by: yalin wang yalin.wang2...@gmail.com
---
drivers/net/fddi/skfp/h/hwmtm.h | 10 --
1 file changed, 10 deletions(-)

diff --git a/drivers/net/fddi/skfp/h/hwmtm.h b/drivers/net/fddi/skfp/h/hwmtm.h
index 5924d42..4ca2341 100644
--- a/drivers/net/fddi/skfp/h/hwmtm.h
+++ b/drivers/net/fddi/skfp/h/hwmtm.h
@@ -74,15 +74,6 @@
#define NULL   0
#endif

-#ifdef LITTLE_ENDIAN
-#define HWM_REVERSE(x) (x)
-#else
-#defineHWM_REVERSE(x)  x)24L)0xff00L)   +   
\
-(((x) 8L)0x00ffL)   +   \
-(((x) 8L)0xff00L)   +   \
-(((x)24L)0x00ffL))
-#endif
-
#define C_INDIC(1L25)
#define A_INDIC(1L26)
#defineRD_FS_LOCAL 0x80
-- 
1.9.1


--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH v2 Resend] net/fddi: remove HWM_REVERSE() macro

2015-08-10 Thread David Miller
From: yalin wang yalin.wang2...@gmail.com
Date: Tue, 11 Aug 2015 13:11:22 +0800

 HWM_REVERSE() macro is unused, remove it.
 
 Signed-off-by: yalin wang yalin.wang2...@gmail.com

You did not do as I asked you to, this patch is still corrupted
and there is no way you successfully applied what is in this patch.

 -#defineHWM_REVERSE(x)  x)24L)0xff00L)   + 
   \
 -(((x) 8L)0x00ffL)   +   \
 -(((x) 8L)0xff00L)   +   \
 -(((x)24L)0x00ffL))

This indentation here is spaces, whereas in the source files they
are TABS.

Your email client did this.

If you fail to properly verify that your outgoing patches are not
corrupted before submitting them here, I will stop reviewing and
considering your changes.

Thank you.
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH v2 Resend] net/fddi: remove HWM_REVERSE() macro

2015-08-10 Thread yalin wang

 On Aug 11, 2015, at 13:37, David Miller da...@davemloft.net wrote:
 
 From: yalin wang yalin.wang2...@gmail.com
 Date: Tue, 11 Aug 2015 13:11:22 +0800
 
 HWM_REVERSE() macro is unused, remove it.
 
 Signed-off-by: yalin wang yalin.wang2...@gmail.com
 
 You did not do as I asked you to, this patch is still corrupted
 and there is no way you successfully applied what is in this patch.
 
 -#defineHWM_REVERSE(x)  x)24L)0xff00L)   +
\
 -(((x) 8L)0x00ffL)   +   \
 -(((x) 8L)0xff00L)   +   \
 -(((x)24L)0x00ffL))
 
 This indentation here is spaces, whereas in the source files they
 are TABS.
 
 Your email client did this.
 
 If you fail to properly verify that your outgoing patches are not
 corrupted before submitting them here, I will stop reviewing and
 considering your changes.
 
 Thank you.
ouch,  i am sorry that i am sending from windows PC,
let me check that .
Sorry for that .--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html