Re: [PATCH v2 iproute2] tc: fix bpf compilation with old glibc
On Thu, Jul 23, 2015 at 11:50 PM, Alexei Starovoitov
alexei.starovoi...@gmail.com wrote:
On Thu, Jul 23, 2015 at 09:17:41AM +0200, Nicolas Dichtel wrote:
Error was:
f_bpf.o: In function `bpf_parse_opt':
f_bpf.c:(.text+0x88f): undefined reference to `secure_getenv'
m_bpf.o: In function `parse_bpf':
m_bpf.c:(.text+0x587): undefined reference to `secure_getenv'
collect2: error: ld returned 1 exit status
There is no special reason to use the secure version of getenv, thus let's
simply use getenv().
CC: Daniel Borkmann dan...@iogearbox.net
Fixes: 88eea5395483 (tc: {f,m}_bpf: allow to retrieve uds path from env)
Signed-off-by: Nicolas Dichtel nicolas.dich...@6wind.com
---
v2: rework the fix to use getenv() instead of secure_getenv()
had the same workaround locally.
Acked-by: Alexei Starovoitov a...@plumgrid.com
Tested-by: Yegor Yefremov yegorsli...@googlemail.com
tested with uclibc, that has problems with secure_getenv() too.
Yegor
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 iproute2] tc: fix bpf compilation with old glibc
On Thu, Jul 23, 2015 at 09:17:41AM +0200, Nicolas Dichtel wrote:
Error was:
f_bpf.o: In function `bpf_parse_opt':
f_bpf.c:(.text+0x88f): undefined reference to `secure_getenv'
m_bpf.o: In function `parse_bpf':
m_bpf.c:(.text+0x587): undefined reference to `secure_getenv'
collect2: error: ld returned 1 exit status
There is no special reason to use the secure version of getenv, thus let's
simply use getenv().
CC: Daniel Borkmann dan...@iogearbox.net
Fixes: 88eea5395483 (tc: {f,m}_bpf: allow to retrieve uds path from env)
Signed-off-by: Nicolas Dichtel nicolas.dich...@6wind.com
---
v2: rework the fix to use getenv() instead of secure_getenv()
had the same workaround locally.
Acked-by: Alexei Starovoitov a...@plumgrid.com
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 iproute2] tc: fix bpf compilation with old glibc
On 07/23/2015 09:17 AM, Nicolas Dichtel wrote:
Error was:
f_bpf.o: In function `bpf_parse_opt':
f_bpf.c:(.text+0x88f): undefined reference to `secure_getenv'
m_bpf.o: In function `parse_bpf':
m_bpf.c:(.text+0x587): undefined reference to `secure_getenv'
collect2: error: ld returned 1 exit status
There is no special reason to use the secure version of getenv, thus let's
simply use getenv().
CC: Daniel Borkmann dan...@iogearbox.net
Fixes: 88eea5395483 (tc: {f,m}_bpf: allow to retrieve uds path from env)
Signed-off-by: Nicolas Dichtel nicolas.dich...@6wind.com
Acked-by: Daniel Borkmann dan...@iogearbox.net
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v2 iproute2] tc: fix bpf compilation with old glibc
Error was:
f_bpf.o: In function `bpf_parse_opt':
f_bpf.c:(.text+0x88f): undefined reference to `secure_getenv'
m_bpf.o: In function `parse_bpf':
m_bpf.c:(.text+0x587): undefined reference to `secure_getenv'
collect2: error: ld returned 1 exit status
There is no special reason to use the secure version of getenv, thus let's
simply use getenv().
CC: Daniel Borkmann dan...@iogearbox.net
Fixes: 88eea5395483 (tc: {f,m}_bpf: allow to retrieve uds path from env)
Signed-off-by: Nicolas Dichtel nicolas.dich...@6wind.com
---
v2: rework the fix to use getenv() instead of secure_getenv()
examples/bpf/bpf_agent.c | 2 +-
tc/f_bpf.c | 2 +-
tc/m_bpf.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/examples/bpf/bpf_agent.c b/examples/bpf/bpf_agent.c
index 426b8800bf4e..f9b9ce3ccb3d 100644
--- a/examples/bpf/bpf_agent.c
+++ b/examples/bpf/bpf_agent.c
@@ -154,7 +154,7 @@ static void bpf_map_get_from_env(int *tfd)
memset(key, 0, sizeof(key));
snprintf(key, sizeof(key), BPF_MAP%d, i);
- val = secure_getenv(key);
+ val = getenv(key);
assert(val != NULL);
tfd[i] = atoi(val);
diff --git a/tc/f_bpf.c b/tc/f_bpf.c
index c21bf33fd25f..490dc6b4e7ba 100644
--- a/tc/f_bpf.c
+++ b/tc/f_bpf.c
@@ -122,7 +122,7 @@ opt_bpf:
NEXT_ARG();
if (ebpf) {
- bpf_uds_name = secure_getenv(BPF_ENV_UDS);
+ bpf_uds_name = getenv(BPF_ENV_UDS);
bpf_obj = *argv;
NEXT_ARG();
diff --git a/tc/m_bpf.c b/tc/m_bpf.c
index 9ddb6672693c..c51f44fc6ce6 100644
--- a/tc/m_bpf.c
+++ b/tc/m_bpf.c
@@ -105,7 +105,7 @@ opt_bpf:
NEXT_ARG();
if (ebpf) {
- bpf_uds_name = secure_getenv(BPF_ENV_UDS);
+ bpf_uds_name = getenv(BPF_ENV_UDS);
bpf_obj = *argv;
NEXT_ARG();
--
2.4.2
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
