Re: [PATCH v2 net] net/mlx4_en: really allow to change RSS key

2015-09-17 Thread David Miller 
From: Or Gerlitz 
Date: Wed, 16 Sep 2015 14:05:25 +0300

> On Wed, Sep 16, 2015 at 4:29 AM, Eric Dumazet  wrote:
>> From: Eric Dumazet 
>>
>> When changing rss key, we do not want to overwrite user provided key
>> by the one provided by netdev_rss_key_fill(), which is the host random
>> key generated at boot time.
>>
>> Fixes: 947cbb0ac242 ("net/mlx4_en: Support for configurable RSS hash 
>> function")
>> Signed-off-by: Eric Dumazet 
>> Cc: Eyal Perry 
>> CC: Amir Vadai 
> 
> Acked-by: Or Gerlitz 
> 
> Dave, can you please push it to -stable of >= 3.19 ?

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 net] net/mlx4_en: really allow to change RSS key

2015-09-16 Thread Or Gerlitz 
On Wed, Sep 16, 2015 at 4:29 AM, Eric Dumazet  wrote:
> From: Eric Dumazet 
>
> When changing rss key, we do not want to overwrite user provided key
> by the one provided by netdev_rss_key_fill(), which is the host random
> key generated at boot time.
>
> Fixes: 947cbb0ac242 ("net/mlx4_en: Support for configurable RSS hash 
> function")
> Signed-off-by: Eric Dumazet 
> Cc: Eyal Perry 
> CC: Amir Vadai 

Acked-by: Or Gerlitz 

Dave, can you please push it to -stable of >= 3.19 ?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2 net] net/mlx4_en: really allow to change RSS key

2015-09-15 Thread Eric Dumazet 
From: Eric Dumazet 

When changing rss key, we do not want to overwrite user provided key
by the one provided by netdev_rss_key_fill(), which is the host random
key generated at boot time.

Fixes: 947cbb0ac242 ("net/mlx4_en: Support for configurable RSS hash function")
Signed-off-by: Eric Dumazet 
Cc: Eyal Perry 
CC: Amir Vadai 
---
 drivers/net/ethernet/mellanox/mlx4/en_rx.c |2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlx4/en_rx.c 
b/drivers/net/ethernet/mellanox/mlx4/en_rx.c
index 4402a1e48c9b..0ce6ffe73ca8 100644
--- a/drivers/net/ethernet/mellanox/mlx4/en_rx.c
+++ b/drivers/net/ethernet/mellanox/mlx4/en_rx.c
@@ -1268,8 +1268,6 @@ int mlx4_en_config_rss_steer(struct mlx4_en_priv *priv)
rss_context->hash_fn = MLX4_RSS_HASH_TOP;
memcpy(rss_context->rss_key, priv->rss_key,
   MLX4_EN_RSS_KEY_SIZE);
-   netdev_rss_key_fill(rss_context->rss_key,
-   MLX4_EN_RSS_KEY_SIZE);
} else {
en_err(priv, "Unknown RSS hash function requested\n");
err = -EINVAL;


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html