Re: [PATCH v2 net-next] net/vxlan: Fix kernel unaligned access in __vxlan_find_mac

[David Miller]

From: Sowmini Varadhan sowmini.varad...@oracle.com
Date: Mon, 20 Jul 2015 09:54:50 +0200

 
 __vxlan_find_mac invokes ether_addr_equal on the eth_addr field,
 which triggers unaligned access messages, so rearrange vxlan_fdb
 to avoid this in the most non-intrusive way.
 
 Signed-off-by: Sowmini Varadhan sowmini.varad...@oracle.com
 ---
 v2: Alexander Duyck comments: place eth_addr[] to be 64b aligned

Applied, thanks.
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 net-next] net/vxlan: Fix kernel unaligned access in __vxlan_find_mac

[Jiri Pirko]

Mon, Jul 20, 2015 at 09:54:50AM CEST, sowmini.varad...@oracle.com wrote:

__vxlan_find_mac invokes ether_addr_equal on the eth_addr field,
which triggers unaligned access messages, so rearrange vxlan_fdb
to avoid this in the most non-intrusive way.

Signed-off-by: Sowmini Varadhan sowmini.varad...@oracle.com

Reviewed-by: Jiri Pirko j...@resnulli.us


--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2 net-next] net/vxlan: Fix kernel unaligned access in __vxlan_find_mac

[Sowmini Varadhan]

__vxlan_find_mac invokes ether_addr_equal on the eth_addr field,
which triggers unaligned access messages, so rearrange vxlan_fdb
to avoid this in the most non-intrusive way.

Signed-off-by: Sowmini Varadhan sowmini.varad...@oracle.com
---
v2: Alexander Duyck comments: place eth_addr[] to be 64b aligned

 drivers/net/vxlan.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
index 34c519e..ec86a11 100644
--- a/drivers/net/vxlan.c
+++ b/drivers/net/vxlan.c
@@ -106,9 +106,9 @@ struct vxlan_fdb {
unsigned long updated;  /* jiffies */
unsigned long used;
struct list_head  remotes;
+   u8eth_addr[ETH_ALEN];
u16   state;/* see ndm_state */
u8flags;/* see ndm_flags */
-   u8eth_addr[ETH_ALEN];
 };
 
 /* Pseudo network device */
-- 
1.7.1

--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 net-next] net/vxlan: Fix kernel unaligned access in __vxlan_find_mac

[Marcelo Ricardo Leitner]

On Mon, Jul 20, 2015 at 09:54:50AM +0200, Sowmini Varadhan wrote:
 
 __vxlan_find_mac invokes ether_addr_equal on the eth_addr field,
 which triggers unaligned access messages, so rearrange vxlan_fdb
 to avoid this in the most non-intrusive way.
 
 Signed-off-by: Sowmini Varadhan sowmini.varad...@oracle.com

Reviewed-by: Marcelo Ricardo Leitner marcelo.leit...@gmail.com

--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html