Re: [PATCH v2 net-next 01/13] ip_tunnels: remove custom alignment and packing

[Thomas Graf]

On 08/19/15 at 12:09pm, Jiri Benc wrote:
> The custom alignment of struct ip_tunnel_key is unnecessary. In struct
> sw_flow_key, it starts at offset 256, in struct ip_tunnel_info it's the
> first field.
> 
> The structure is also packed even without the __packed keyword.
> 
> Signed-off-by: Jiri Benc 

I came to the same conclusion but didn't want to change it in the original
series.

Acked-by: Thomas Graf 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2 net-next 01/13] ip_tunnels: remove custom alignment and packing

[Jiri Benc]

The custom alignment of struct ip_tunnel_key is unnecessary. In struct
sw_flow_key, it starts at offset 256, in struct ip_tunnel_info it's the
first field.

The structure is also packed even without the __packed keyword.

Signed-off-by: Jiri Benc 
---
 include/net/ip_tunnels.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/net/ip_tunnels.h b/include/net/ip_tunnels.h
index 984dbfa15e13..81cf11c931e4 100644
--- a/include/net/ip_tunnels.h
+++ b/include/net/ip_tunnels.h
@@ -36,7 +36,7 @@ struct ip_tunnel_key {
__u8ipv4_ttl;
__be16  tp_src;
__be16  tp_dst;
-} __packed __aligned(4); /* Minimize padding. */
+};
 
 /* Indicates whether the tunnel info structure represents receive
  * or transmit tunnel parameters.
-- 
1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html