Re: [PATCH v3 -mm 0/9] netconsole: Multiple targets and dynamic reconfigurability

2007-07-30 Thread Andrew Morton
On Mon, 30 Jul 2007 08:17:41 +0530
Satyam Sharma [EMAIL PROTECTED] wrote:

 [0/9] netconsole: Multiple targets and dynamic reconfigurability
 
 This is v3 of the patchset

That all looks pretty reasonable, thanks.

Are we all comfortable with the attributions?  As I have it now, everything
will go in as having been authored by yourself.  There is no formal (ie:
understood-by-git) way of recording joint authorship, unfortunately.  But one
can make a record of such things in the changelog.

I'll queue this material up in the to-be-sent-to-davem queue.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH v3 -mm 0/9] netconsole: Multiple targets and dynamic reconfigurability

2007-07-30 Thread Satyam Sharma


On Mon, 30 Jul 2007, Andrew Morton wrote:

 On Mon, 30 Jul 2007 08:17:41 +0530
 Satyam Sharma [EMAIL PROTECTED] wrote:
 
  [0/9] netconsole: Multiple targets and dynamic reconfigurability
  
  This is v3 of the patchset
 
 That all looks pretty reasonable, thanks.
 
 Are we all comfortable with the attributions?  As I have it now, everything
 will go in as having been authored by yourself.  There is no formal (ie:
 understood-by-git) way of recording joint authorship, unfortunately.  But one
 can make a record of such things in the changelog.

Ok, making such a record would be good, if possible. I did see that the
author field for git commits can have only one entry, unfortunately,
and it turns out Signed-off-by and Acked-by have other meanings
attached that have to do with the patch-journey-from-author-to-you chain.
But I'd like these to be somehow marked as jointly authored, definitely.

 I'll queue this material up in the to-be-sent-to-davem queue.

Ok, thanks.


Satyam
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH v3 -mm 0/9] netconsole: Multiple targets and dynamic reconfigurability

2007-07-29 Thread Satyam Sharma
[0/9] netconsole: Multiple targets and dynamic reconfigurability

This is v3 of the patchset, the previous versions are available at:
http://lkml.org/lkml/2007/7/4/107
http://lkml.org/lkml/2007/7/10/78

Diffed against 2.6.23-rc1-git6 (6c8dca5d as of writing), but applies
successfully to 2.6.23-rc1-mm1 as well.

Patches 1-5 are okay-to-apply to current mainline -git, I think.

Patches 6-9 introduce the new functionality and are requested for
inclusion in -mm.

[1/9] netconsole: Cleanups, codingstyle, prettyfication
[2/9] netconsole: Remove bogus check
[3/9] netconsole: Simplify boot/module option setup logic
[4/9] netconsole: Use netif_running() in write_msg()
[5/9] netconsole: Add some useful tips to documentation
[6/9] netconsole: Introduce netconsole_target
[7/9] netconsole: Introduce netconsole_netdev_notifier
[8/9] netconsole: Support multiple logging targets
[9/9] netconsole: Support dynamic reconfiguration using configfs

Changes since v2:
=

* enabled must be defined outside #ifdef NETCONSOLE_DYNAMIC

* Some simple enhancements to documentation

* Drop the use of unlikely from a condition where I'd got the
  common case wrong

About this patchset:


What?

Support multiple remote logging targets in netconsole. Also, ability to
dynamically add or remove targets or modify parameters (IP, port, remote
MAC address) of targets at runtime, from userspace, using configfs.

Why?

From Keiichi Kii's original post:

[...] current netconsole is not flexible. For example, if you want to change
ip address for logging agent, in the case of built-in netconsole, you can't
change config except for changing boot parameter and rebooting your system,
or in the case of module netconsole, you need to remove it and reload
with different parameters. [...] and we have been losing serial console
port with PCs and Servers.

(... and especially laptops, I would add.)


Satyam
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html