Re: [PATCH v3 net-next 2/2] rocker: mark parameters and local variables as const

[Jiri Pirko]

Mon, May 25, 2015 at 07:28:36AM CEST, simon.hor...@netronome.com wrote:
>Mark parameters and local variables as const where possible.
>
>Signed-off-by: Simon Horman 
>Acked-by: Scott Feldman 

Acked-by: Jiri Pirko 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v3 net-next 2/2] rocker: mark parameters and local variables as const

[Simon Horman]

Mark parameters and local variables as const where possible.

Signed-off-by: Simon Horman 
Acked-by: Scott Feldman 

---
v3
* Rebased and updated to cover new parameters and local variables
  that may be const
* Added Scott Feldman's Ack

v2
* Make more parameters and variables const.
  It seems that I missed quite a few the first time around.

  The more I look over this the more I feel others are lurking.
---
 drivers/net/ethernet/rocker/rocker.c | 415 ++-
 1 file changed, 215 insertions(+), 200 deletions(-)

diff --git a/drivers/net/ethernet/rocker/rocker.c 
b/drivers/net/ethernet/rocker/rocker.c
index 4818f2be036f..36f7edfc3c7a 100644
--- a/drivers/net/ethernet/rocker/rocker.c
+++ b/drivers/net/ethernet/rocker/rocker.c
@@ -295,7 +295,7 @@ static bool rocker_vlan_id_is_internal(__be16 vlan_id)
return (_vlan_id >= start && _vlan_id <= end);
 }
 
-static __be16 rocker_port_vid_to_vlan(struct rocker_port *rocker_port,
+static __be16 rocker_port_vid_to_vlan(const struct rocker_port *rocker_port,
  u16 vid, bool *pop_vlan)
 {
__be16 vlan_id;
@@ -312,7 +312,7 @@ static __be16 rocker_port_vid_to_vlan(struct rocker_port 
*rocker_port,
return vlan_id;
 }
 
-static u16 rocker_port_vlan_to_vid(struct rocker_port *rocker_port,
+static u16 rocker_port_vlan_to_vid(const struct rocker_port *rocker_port,
   __be16 vlan_id)
 {
if (rocker_vlan_id_is_internal(vlan_id))
@@ -321,7 +321,7 @@ static u16 rocker_port_vlan_to_vid(struct rocker_port 
*rocker_port,
return ntohs(vlan_id);
 }
 
-static bool rocker_port_is_bridged(struct rocker_port *rocker_port)
+static bool rocker_port_is_bridged(const struct rocker_port *rocker_port)
 {
return !!rocker_port->bridge_dev;
 }
@@ -443,18 +443,18 @@ static void rocker_wait_wake_up(struct rocker_wait *wait)
wake_up(&wait->wait);
 }
 
-static u32 rocker_msix_vector(struct rocker *rocker, unsigned int vector)
+static u32 rocker_msix_vector(const struct rocker *rocker, unsigned int vector)
 {
return rocker->msix_entries[vector].vector;
 }
 
-static u32 rocker_msix_tx_vector(struct rocker_port *rocker_port)
+static u32 rocker_msix_tx_vector(const struct rocker_port *rocker_port)
 {
return rocker_msix_vector(rocker_port->rocker,
  ROCKER_MSIX_VEC_TX(rocker_port->port_number));
 }
 
-static u32 rocker_msix_rx_vector(struct rocker_port *rocker_port)
+static u32 rocker_msix_rx_vector(const struct rocker_port *rocker_port)
 {
return rocker_msix_vector(rocker_port->rocker,
  ROCKER_MSIX_VEC_RX(rocker_port->port_number));
@@ -473,9 +473,9 @@ static u32 rocker_msix_rx_vector(struct rocker_port 
*rocker_port)
  * HW basic testing functions
  */
 
-static int rocker_reg_test(struct rocker *rocker)
+static int rocker_reg_test(const struct rocker *rocker)
 {
-   struct pci_dev *pdev = rocker->pdev;
+   const struct pci_dev *pdev = rocker->pdev;
u64 test_reg;
u64 rnd;
 
@@ -503,12 +503,12 @@ static int rocker_reg_test(struct rocker *rocker)
return 0;
 }
 
-static int rocker_dma_test_one(struct rocker *rocker, struct rocker_wait *wait,
-  u32 test_type, dma_addr_t dma_handle,
-  unsigned char *buf, unsigned char *expect,
-  size_t size)
+static int rocker_dma_test_one(const struct rocker *rocker,
+  struct rocker_wait *wait, u32 test_type,
+  dma_addr_t dma_handle, const unsigned char *buf,
+  const unsigned char *expect, size_t size)
 {
-   struct pci_dev *pdev = rocker->pdev;
+   const struct pci_dev *pdev = rocker->pdev;
int i;
 
rocker_wait_reset(wait);
@@ -532,7 +532,7 @@ static int rocker_dma_test_one(struct rocker *rocker, 
struct rocker_wait *wait,
 #define ROCKER_TEST_DMA_BUF_SIZE (PAGE_SIZE * 4)
 #define ROCKER_TEST_DMA_FILL_PATTERN 0x96
 
-static int rocker_dma_test_offset(struct rocker *rocker,
+static int rocker_dma_test_offset(const struct rocker *rocker,
  struct rocker_wait *wait, int offset)
 {
struct pci_dev *pdev = rocker->pdev;
@@ -592,7 +592,8 @@ free_alloc:
return err;
 }
 
-static int rocker_dma_test(struct rocker *rocker, struct rocker_wait *wait)
+static int rocker_dma_test(const struct rocker *rocker,
+  struct rocker_wait *wait)
 {
int i;
int err;
@@ -614,9 +615,9 @@ static irqreturn_t rocker_test_irq_handler(int irq, void 
*dev_id)
return IRQ_HANDLED;
 }
 
-static int rocker_basic_hw_test(struct rocker *rocker)
+static int rocker_basic_hw_test(const struct rocker *rocker)
 {
-   struct pci_dev *pdev = rocker->pdev;
+   const struct pci_dev *pdev = rocker->pdev;
struct rocker_wait