Re: [PATCH v7 1/2] nl80211: multicast_to_unicast can be changed while IFF_UP

2016-11-21 Thread Johannes Berg
On Mon, 2016-10-31 at 14:40 +0100, Michael Braun wrote:
> There is no need to prevent toggling multicast_to_unicast while
> interface is already up. This change simplifies reconfiguration
> from hostapd.

Applied. This check never should've been there anyway, if desired,
NEED_NETDEV_UP should've been used.

johannes


[PATCH v7 1/2] nl80211: multicast_to_unicast can be changed while IFF_UP

2016-10-31 Thread Michael Braun
There is no need to prevent toggling multicast_to_unicast while
interface is already up. This change simplifies reconfiguration
from hostapd.

Signed-off-by: Michael Braun 
---
 net/wireless/nl80211.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
index 5349c63..7554400 100644
--- a/net/wireless/nl80211.c
+++ b/net/wireless/nl80211.c
@@ -11006,9 +11006,6 @@ static int nl80211_set_multicast_to_unicast(struct 
sk_buff *skb,
const struct nlattr *nla;
bool enabled;
 
-   if (netif_running(dev))
-   return -EBUSY;
-
if (!rdev->ops->set_multicast_to_unicast)
return -EOPNOTSUPP;
 
-- 
2.1.4