[PKT_SCHED]: act_api: Fix module leak while flushing actions

2006-07-09 Thread Thomas Graf 
Module reference needs to be given back if message header
construction fails.

Signed-off-by: Thomas Graf [EMAIL PROTECTED]

Index: net-2.6.git/net/sched/act_api.c
===
--- net-2.6.git.orig/net/sched/act_api.c
+++ net-2.6.git/net/sched/act_api.c
@@ -602,8 +602,8 @@ static int tca_action_flush(struct rtatt
return err;
 
 rtattr_failure:
-   module_put(a-ops-owner);
 nlmsg_failure:
+   module_put(a-ops-owner);
 err_out:
kfree_skb(skb);
kfree(a);
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PKT_SCHED]: act_api: Fix module leak while flushing actions

2006-07-09 Thread David Miller 
From: Thomas Graf [EMAIL PROTECTED]
Date: Sun, 9 Jul 2006 16:20:43 +0200

 Module reference needs to be given back if message header
 construction fails.
 
 Signed-off-by: Thomas Graf [EMAIL PROTECTED]

Applied, thanks Thomas.

This reminds me of something, not only are non-networking developers
getting tripped up constantly about these magic code labels referenced
from the netlink macros, they are tripping us up as well.

I really think it's time, at a minimum, to explicitly mention the
labels as an argument to the macros, or something like that.

I'll try to cons something up when I get a chance.  The current
situation is too error prone.

-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PKT_SCHED]: act_api: Fix module leak while flushing actions

2006-07-09 Thread Thomas Graf 
* David Miller [EMAIL PROTECTED] 2006-07-09 11:38
 From: Thomas Graf [EMAIL PROTECTED]
 Date: Sun, 9 Jul 2006 16:20:43 +0200
 
  Module reference needs to be given back if message header
  construction fails.
  
  Signed-off-by: Thomas Graf [EMAIL PROTECTED]
 
 Applied, thanks Thomas.
 
 This reminds me of something, not only are non-networking developers
 getting tripped up constantly about these magic code labels referenced
 from the netlink macros, they are tripping us up as well.
 
 I really think it's time, at a minimum, to explicitly mention the
 labels as an argument to the macros, or something like that.
 
 I'll try to cons something up when I get a chance.  The current
 situation is too error prone.

I agree, that's why the new netlink api offers label free
methods. The transformation patches for 2.6.19 converting
all netlink users to use the new api will resolved these
issues.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PKT_SCHED]: act_api: Fix module leak while flushing actions

2006-07-09 Thread David Miller 
From: Thomas Graf [EMAIL PROTECTED]
Date: Sun, 9 Jul 2006 21:57:34 +0200

 * David Miller [EMAIL PROTECTED] 2006-07-09 11:38
  I'll try to cons something up when I get a chance.  The current
  situation is too error prone.
 
 I agree, that's why the new netlink api offers label free
 methods. The transformation patches for 2.6.19 converting
 all netlink users to use the new api will resolved these
 issues.

Awesome, I look forward to seeing those patches.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html