Re: [RFC] Multiple IPV6 Routing Tables Policy Routing
Thomas Graf wrote: Hello, Hi Thomas! Thought it might be time to go through a round of comments on this work. Even though I've almost rewritten all the code the patches are based on the work found on www.mobile-ipv6.org. I have no idea which code was written by whom so just email me to get the credits right. The policy routing stuff (multiple tables and source address based routing) was almost entirely written by me. Therefore you can apply my name as you see fit ;-) Tushar Gohad at MontaVista, Benjamin Thery at Bull and of course USAGI have also worked on the code. Main differences to the version found on mobile-ipv6.org is that I removed table refcnt and defined that tables cannot disappear once created to simplify things and avoid too many atomic operations when looking up routes. Yes, that sounds good. As the ipv6 module doesn't really seem to become unloadable anytime soon, there isn't really any good reason to refcount the tables. I've replaced the table array with a hash table to prepare it for 255 tables and made things aware of the new default router selection code and experimental route info stuff added recently. Good! I never had the time to merge our changes with 2.6.17. It's not final but somewhat working, I'm eager to see comments or patches. I'll try to comment on them the best I can. I apologize if I've tramped onto anybody's foot by taking this up and submitting it, this isn't meant as an attempt to steal credits but rather to pick up good code and finally get it upstream after a very long while. No offense taken! It's great that someone wants to push these things upstream as I personally have neither had the time nor the energy to do so lately. Regards, Ville - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC] Multiple IPV6 Routing Tables Policy Routing
Hello. In article [EMAIL PROTECTED] (at Thu, 27 Jul 2006 00:11:00 +0200), Thomas Graf [EMAIL PROTECTED] says: It's not final but somewhat working, I'm eager to see comments or patches. I apologize if I've tramped onto anybody's foot by taking this up and submitting it, this isn't meant as an attempt to steal credits but rather to pick up good code and finally get it upstream after a very long while. First of all, Thank you for giving us good starting point. I am interested in this area because I have been spending several month for this release engineering. Well, as you stated, the code is based on the work of MIPL, which is being jointly developed by Helsinki University of Technology (HUT) and USAGI/WIDE Project. Please describe this on your commit logs. Please retain copyright information as well. Thank you very much. -- YOSHIFUJI Hideaki @ USAGI Project [EMAIL PROTECTED] GPG-FP : 9022 65EB 1ECF 3AD1 0BDF 80D8 4807 F894 E062 0EEA - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC] Multiple IPV6 Routing Tables Policy Routing
From: YOSHIFUJI Hideaki [EMAIL PROTECTED] Date: Fri, 28 Jul 2006 15:10:09 +0900 (JST) Well, as you stated, the code is based on the work of MIPL, which is being jointly developed by Helsinki University of Technology (HUT) and USAGI/WIDE Project. Please describe this on your commit logs. Please retain copyright information as well. Ok. Thomas could you please respin the patches with: 1) Updated credits, based upon Yoshifuji's feedback 2) Fixes for the small issues Patrick pointer out in his review Thanks a lot. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC] Multiple IPV6 Routing Tables Policy Routing
* YOSHIFUJI Hideaki / ?$B5HF#1QL@ [EMAIL PROTECTED] 2006-07-28 15:10 Well, as you stated, the code is based on the work of MIPL, which is being jointly developed by Helsinki University of Technology (HUT) and USAGI/WIDE Project. Please describe this on your commit logs. Please retain copyright information as well. Please tell me which copyright I missed? - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC] Multiple IPV6 Routing Tables Policy Routing
In article [EMAIL PROTECTED] (at Fri, 28 Jul 2006 12:32:29 +0200), Thomas Graf [EMAIL PROTECTED] says: * YOSHIFUJI Hideaki / ?$B5HF#1QL@ [EMAIL PROTECTED] 2006-07-28 15:10 Well, as you stated, the code is based on the work of MIPL, which is being jointly developed by Helsinki University of Technology (HUT) and USAGI/WIDE Project. Please describe this on your commit logs. Please retain copyright information as well. Please tell me which copyright I missed? Please put these lines in net/ipv6/fib6_rules.c (and maybe, its derived files): Copyright (C)2003-2006 Helsinki University of Technology Copyright (C)2003-2006 USAGI/WIDE Project You can add your own copyright notice if you want, of course. Thank you. --yoshfuji - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[RFC] Multiple IPV6 Routing Tables Policy Routing
Hello, Thought it might be time to go through a round of comments on this work. Even though I've almost rewritten all the code the patches are based on the work found on www.mobile-ipv6.org. I have no idea which code was written by whom so just email me to get the credits right. Main differences to the version found on mobile-ipv6.org is that I removed table refcnt and defined that tables cannot disappear once created to simplify things and avoid too many atomic operations when looking up routes. I've replaced the table array with a hash table to prepare it for 255 tables and made things aware of the new default router selection code and experimental route info stuff added recently. It's not final but somewhat working, I'm eager to see comments or patches. I apologize if I've tramped onto anybody's foot by taking this up and submitting it, this isn't meant as an attempt to steal credits but rather to pick up good code and finally get it upstream after a very long while. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html