Re: [iproute2 net-next v2 0/3] ip netconf improvements
On Thu, 23 Mar 2017 19:51:19 -0700 David Ahern wrote: > Currently, ip netconf only shows data for ipv4 and ipv6 for dumps > and just ipv4 for device requests. Improve the user experience by > using the new kernel patch to dump all address families that have > registered. For example, if mpls_router module is loaded then mpls > values are displayed along with ipv4 and ipv6. > > If the new feature is not supported (new iproute2 on older kernel) > the kernel returns the nlmsg error EOPNOTSUPP which can be trapped > and fallback to existing behavior. > > v2 > - fixed index conversion in patch 3 per nicholas' comment > > David Ahern (3): > netlink: Add flag to suppress print of nlmsg error > ip netconf: Show all address families by default in dumps > ip netconf: show all families on dev request > > include/libnetlink.h | 1 + > ip/ipnetconf.c | 36 +--- > lib/libnetlink.c | 3 ++- > 3 files changed, 28 insertions(+), 12 deletions(-) > Sure applied, just wanted to make sure there was nothing interrelated with recent spate of changes to netlink notifications.
Re: [iproute2 net-next v2 0/3] ip netconf improvements
On 4/4/17 5:39 PM, Stephen Hemminger wrote: > On Tue, 4 Apr 2017 17:07:31 -0400 > David Ahern wrote: > >> On 3/23/17 10:51 PM, David Ahern wrote: >>> Currently, ip netconf only shows data for ipv4 and ipv6 for dumps >>> and just ipv4 for device requests. Improve the user experience by >>> using the new kernel patch to dump all address families that have >>> registered. For example, if mpls_router module is loaded then mpls >>> values are displayed along with ipv4 and ipv6. >>> >>> If the new feature is not supported (new iproute2 on older kernel) >>> the kernel returns the nlmsg error EOPNOTSUPP which can be trapped >>> and fallback to existing behavior. >>> >>> v2 >>> - fixed index conversion in patch 3 per nicholas' comment >>> >>> David Ahern (3): >>> netlink: Add flag to suppress print of nlmsg error >>> ip netconf: Show all address families by default in dumps >>> ip netconf: show all families on dev request >>> >>> include/libnetlink.h | 1 + >>> ip/ipnetconf.c | 36 +--- >>> lib/libnetlink.c | 3 ++- >>> 3 files changed, 28 insertions(+), 12 deletions(-) >>> >> >> Hi Stephen: any comments? are you ok with this change? > > I was holding off until all the upstream commits went through. Other than > that fine. > I'm not aware of any kernel commits that not in net-next, so I think we good to go on the kernel side.
Re: [iproute2 net-next v2 0/3] ip netconf improvements
On Tue, 4 Apr 2017 17:07:31 -0400 David Ahern wrote: > On 3/23/17 10:51 PM, David Ahern wrote: > > Currently, ip netconf only shows data for ipv4 and ipv6 for dumps > > and just ipv4 for device requests. Improve the user experience by > > using the new kernel patch to dump all address families that have > > registered. For example, if mpls_router module is loaded then mpls > > values are displayed along with ipv4 and ipv6. > > > > If the new feature is not supported (new iproute2 on older kernel) > > the kernel returns the nlmsg error EOPNOTSUPP which can be trapped > > and fallback to existing behavior. > > > > v2 > > - fixed index conversion in patch 3 per nicholas' comment > > > > David Ahern (3): > > netlink: Add flag to suppress print of nlmsg error > > ip netconf: Show all address families by default in dumps > > ip netconf: show all families on dev request > > > > include/libnetlink.h | 1 + > > ip/ipnetconf.c | 36 +--- > > lib/libnetlink.c | 3 ++- > > 3 files changed, 28 insertions(+), 12 deletions(-) > > > > Hi Stephen: any comments? are you ok with this change? I was holding off until all the upstream commits went through. Other than that fine.
Re: [iproute2 net-next v2 0/3] ip netconf improvements
On 3/23/17 10:51 PM, David Ahern wrote: > Currently, ip netconf only shows data for ipv4 and ipv6 for dumps > and just ipv4 for device requests. Improve the user experience by > using the new kernel patch to dump all address families that have > registered. For example, if mpls_router module is loaded then mpls > values are displayed along with ipv4 and ipv6. > > If the new feature is not supported (new iproute2 on older kernel) > the kernel returns the nlmsg error EOPNOTSUPP which can be trapped > and fallback to existing behavior. > > v2 > - fixed index conversion in patch 3 per nicholas' comment > > David Ahern (3): > netlink: Add flag to suppress print of nlmsg error > ip netconf: Show all address families by default in dumps > ip netconf: show all families on dev request > > include/libnetlink.h | 1 + > ip/ipnetconf.c | 36 +--- > lib/libnetlink.c | 3 ++- > 3 files changed, 28 insertions(+), 12 deletions(-) > Hi Stephen: any comments? are you ok with this change?
Re: [iproute2 net-next v2 0/3] ip netconf improvements
Le 24/03/2017 à 03:51, David Ahern a écrit : > Currently, ip netconf only shows data for ipv4 and ipv6 for dumps > and just ipv4 for device requests. Improve the user experience by > using the new kernel patch to dump all address families that have > registered. For example, if mpls_router module is loaded then mpls > values are displayed along with ipv4 and ipv6. > > If the new feature is not supported (new iproute2 on older kernel) > the kernel returns the nlmsg error EOPNOTSUPP which can be trapped > and fallback to existing behavior. Acked-by: Nicolas Dichtel
[iproute2 net-next v2 0/3] ip netconf improvements
Currently, ip netconf only shows data for ipv4 and ipv6 for dumps and just ipv4 for device requests. Improve the user experience by using the new kernel patch to dump all address families that have registered. For example, if mpls_router module is loaded then mpls values are displayed along with ipv4 and ipv6. If the new feature is not supported (new iproute2 on older kernel) the kernel returns the nlmsg error EOPNOTSUPP which can be trapped and fallback to existing behavior. v2 - fixed index conversion in patch 3 per nicholas' comment David Ahern (3): netlink: Add flag to suppress print of nlmsg error ip netconf: Show all address families by default in dumps ip netconf: show all families on dev request include/libnetlink.h | 1 + ip/ipnetconf.c | 36 +--- lib/libnetlink.c | 3 ++- 3 files changed, 28 insertions(+), 12 deletions(-) -- 2.1.4
