Re: [net-next:master 194/196] include/net/sock.h:1367:9: error: implicit declaration of function 'lockdep_is_held'

[Hannes Frederic Sowa]

On Thu, Apr 7, 2016, at 23:09, David Miller wrote:
> From: kbuild test robot 
> Date: Fri, 8 Apr 2016 05:00:42 +0800
> 
> >include/net/sock.h: In function 'lockdep_sock_is_held':
> >>> include/net/sock.h:1367:9: error: implicit declaration of function 
> >>> 'lockdep_is_held' [-Werror=implicit-function-declaration]
> >  return lockdep_is_held(>sk_lock) ||
> ...
> >   1361  } while (0)
> >   1362  
> >   1363  static bool lockdep_sock_is_held(const struct sock *csk)
> >   1364  {
> >   1365  struct sock *sk = (struct sock *)csk;
> >   1366  
> >> 1367   return lockdep_is_held(>sk_lock) ||
> >   1368 lockdep_is_held(>sk_lock.slock);
> >   1369  }
> 
> Hmmm, Hannes to we need to make this a macro just like lockdep_is_held()
> is?

I think my newest patch should fix it. I simply forgot the inline
keyword. inline functions get invisible if not used by the compiler.

Sorry,
Hannes

Re: [net-next:master 194/196] include/net/sock.h:1367:9: error: implicit declaration of function 'lockdep_is_held'

[David Miller]

From: kbuild test robot 
Date: Fri, 8 Apr 2016 05:00:42 +0800

>include/net/sock.h: In function 'lockdep_sock_is_held':
>>> include/net/sock.h:1367:9: error: implicit declaration of function 
>>> 'lockdep_is_held' [-Werror=implicit-function-declaration]
>  return lockdep_is_held(>sk_lock) ||
...
>   1361} while (0)
>   1362
>   1363static bool lockdep_sock_is_held(const struct sock *csk)
>   1364{
>   1365struct sock *sk = (struct sock *)csk;
>   1366
>> 1367 return lockdep_is_held(>sk_lock) ||
>   1368   lockdep_is_held(>sk_lock.slock);
>   1369}

Hmmm, Hannes to we need to make this a macro just like lockdep_is_held() is?

[net-next:master 194/196] include/net/sock.h:1367:9: error: implicit declaration of function 'lockdep_is_held'

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 
master
head:   1fbbe1a8a9b195c4ac856540dfaef49d663c2e91
commit: 1e1d04e678cf72442f57ce82803c7a407769135f [194/196] net: introduce 
lockdep_is_held and update various places to use it
config: i386-tinyconfig (attached as .config)
reproduce:
git checkout 1e1d04e678cf72442f57ce82803c7a407769135f
# save the attached .config to linux build tree
make ARCH=i386 

All errors (new ones prefixed by >>):

   In file included from include/linux/tcp.h:22:0,
from include/linux/ipv6.h:75,
from include/net/ipv6.h:16,
from include/linux/sunrpc/clnt.h:27,
from include/linux/nfs_fs.h:30,
from init/do_mounts.c:32:
   include/net/sock.h: In function 'lockdep_sock_is_held':
>> include/net/sock.h:1367:9: error: implicit declaration of function 
>> 'lockdep_is_held' [-Werror=implicit-function-declaration]
 return lockdep_is_held(>sk_lock) ||
^
   init/do_mounts.c: At top level:
   include/net/sock.h:1363:13: warning: 'lockdep_sock_is_held' defined but not 
used [-Wunused-function]
static bool lockdep_sock_is_held(const struct sock *csk)
^
   cc1: some warnings being treated as errors

vim +/lockdep_is_held +1367 include/net/sock.h

  1361  } while (0)
  1362  
  1363  static bool lockdep_sock_is_held(const struct sock *csk)
  1364  {
  1365  struct sock *sk = (struct sock *)csk;
  1366  
> 1367  return lockdep_is_held(>sk_lock) ||
  1368 lockdep_is_held(>sk_lock.slock);
  1369  }
  1370  

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: Binary data