Re: [patch, -rc5-mm1] lock validator: special locking: net/ipv4/igmp.c #2
On 5/31/06, Ingo Molnar [EMAIL PROTECTED] wrote: * Jesse Brandeburg [EMAIL PROTECTED] wrote: well, when running e1000 through some code paths on FC4 + 2.6.17-rc5-mm1 + ingo's latest rollup patch, with this lockdep debug option enabled I got this: e1000: eth1: e1000_watchdog_task: NIC Link is Up 1000 Mbps Full Duplex == [ BUG: bad unlock ordering detected! ] -- mDNSResponder/2361 is trying to release lock (in_dev-mc_list_lock) at: [81233f5a] ip_mc_add_src+0x85/0x1f8 ok, could you try the patch below? (i also updated the rollup with this fix) Ingo - Subject: lock validator: special locking: net/ipv4/igmp.c #2 From: Ingo Molnar [EMAIL PROTECTED] another case of non-nested unlocking igmp.c. Signed-off-by: Ingo Molnar [EMAIL PROTECTED] --- net/ipv4/igmp.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux/net/ipv4/igmp.c === --- linux.orig/net/ipv4/igmp.c +++ linux/net/ipv4/igmp.c @@ -1646,7 +1646,7 @@ static int ip_mc_add_src(struct in_devic return -ESRCH; } spin_lock_bh(pmc-lock); - read_unlock(in_dev-mc_list_lock); + read_unlock_non_nested(in_dev-mc_list_lock); #ifdef CONFIG_IP_MULTICAST sf_markstate(pmc); yep, this fixes it. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[patch, -rc5-mm1] lock validator: special locking: net/ipv4/igmp.c #2
* Jesse Brandeburg [EMAIL PROTECTED] wrote: well, when running e1000 through some code paths on FC4 + 2.6.17-rc5-mm1 + ingo's latest rollup patch, with this lockdep debug option enabled I got this: e1000: eth1: e1000_watchdog_task: NIC Link is Up 1000 Mbps Full Duplex == [ BUG: bad unlock ordering detected! ] -- mDNSResponder/2361 is trying to release lock (in_dev-mc_list_lock) at: [81233f5a] ip_mc_add_src+0x85/0x1f8 ok, could you try the patch below? (i also updated the rollup with this fix) Ingo - Subject: lock validator: special locking: net/ipv4/igmp.c #2 From: Ingo Molnar [EMAIL PROTECTED] another case of non-nested unlocking igmp.c. Signed-off-by: Ingo Molnar [EMAIL PROTECTED] --- net/ipv4/igmp.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux/net/ipv4/igmp.c === --- linux.orig/net/ipv4/igmp.c +++ linux/net/ipv4/igmp.c @@ -1646,7 +1646,7 @@ static int ip_mc_add_src(struct in_devic return -ESRCH; } spin_lock_bh(pmc-lock); - read_unlock(in_dev-mc_list_lock); + read_unlock_non_nested(in_dev-mc_list_lock); #ifdef CONFIG_IP_MULTICAST sf_markstate(pmc); - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
