Re: [patch 03/10] strlcpy is smart enough

2007-03-29 Thread Jeff Garzik

[EMAIL PROTECTED] wrote:

From: Jean Delvare <[EMAIL PROTECTED]>

strlcpy already accounts for the trailing zero in its length
computation, so there is no need to substract one to the buffer size.

Signed-off-by: Jean Delvare <[EMAIL PROTECTED]>
Cc: Jan-Bernd Themann <[EMAIL PROTECTED]>
Cc: Thomas Klein <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
---

 drivers/net/ehea/ehea_ethtool.c |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


applied 3-5


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[patch 03/10] strlcpy is smart enough

2007-03-26 Thread akpm
From: Jean Delvare <[EMAIL PROTECTED]>

strlcpy already accounts for the trailing zero in its length
computation, so there is no need to substract one to the buffer size.

Signed-off-by: Jean Delvare <[EMAIL PROTECTED]>
Cc: Jan-Bernd Themann <[EMAIL PROTECTED]>
Cc: Thomas Klein <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
---

 drivers/net/ehea/ehea_ethtool.c |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff -puN drivers/net/ehea/ehea_ethtool.c~ehea-strlcpy-is-smart-enough 
drivers/net/ehea/ehea_ethtool.c
--- a/drivers/net/ehea/ehea_ethtool.c~ehea-strlcpy-is-smart-enough
+++ a/drivers/net/ehea/ehea_ethtool.c
@@ -144,8 +144,8 @@ static int ehea_nway_reset(struct net_de
 static void ehea_get_drvinfo(struct net_device *dev,
   struct ethtool_drvinfo *info)
 {
-   strlcpy(info->driver, DRV_NAME, sizeof(info->driver) - 1);
-   strlcpy(info->version, DRV_VERSION, sizeof(info->version) - 1);
+   strlcpy(info->driver, DRV_NAME, sizeof(info->driver));
+   strlcpy(info->version, DRV_VERSION, sizeof(info->version));
 }
 
 static u32 ehea_get_msglevel(struct net_device *dev)
_
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html