Re: [patch 04/18] via-rhine: disable rx_copybreak on archs that don't allow unaligned DMA access

2007-08-13 Thread Jeff Garzik

[EMAIL PROTECTED] wrote:

From: Dustin Marquess [EMAIL PROTECTED]

Patch to disable the rx_copybreak feature on hardware architectures that
don't allow unaligned DMA access.

#ifdef code taken from tulip_core.c.  Problem pointed out by Ivan
Kokshaysky.

Signed-off-by: Dustin Marquess [EMAIL PROTECTED]
Cc: Francois Romieu [EMAIL PROTECTED]
Cc: Ivan Kokshaysky [EMAIL PROTECTED]
Cc: Jeff Garzik [EMAIL PROTECTED]
Signed-off-by: Andrew Morton [EMAIL PROTECTED]
---

 drivers/net/via-rhine.c |6 ++
 1 files changed, 6 insertions(+)


applied


-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[patch 04/18] via-rhine: disable rx_copybreak on archs that don't allow unaligned DMA access

2007-08-10 Thread akpm
From: Dustin Marquess [EMAIL PROTECTED]

Patch to disable the rx_copybreak feature on hardware architectures that
don't allow unaligned DMA access.

#ifdef code taken from tulip_core.c.  Problem pointed out by Ivan
Kokshaysky.

Signed-off-by: Dustin Marquess [EMAIL PROTECTED]
Cc: Francois Romieu [EMAIL PROTECTED]
Cc: Ivan Kokshaysky [EMAIL PROTECTED]
Cc: Jeff Garzik [EMAIL PROTECTED]
Signed-off-by: Andrew Morton [EMAIL PROTECTED]
---

 drivers/net/via-rhine.c |6 ++
 1 files changed, 6 insertions(+)

diff -puN drivers/net/via-rhine.c~via-rhine-disable-rx_copybreak-on-archs-that 
drivers/net/via-rhine.c
--- a/drivers/net/via-rhine.c~via-rhine-disable-rx_copybreak-on-archs-that
+++ a/drivers/net/via-rhine.c
@@ -42,7 +42,13 @@ static int max_interrupt_work = 20;
 
 /* Set the copy breakpoint for the copy-only-tiny-frames scheme.
Setting to  1518 effectively disables this feature. */
+#if defined(__alpha__) || defined(__arm__) || defined(__hppa__) \
+   || defined(CONFIG_SPARC) || defined(__ia64__) \
+   || defined(__sh__) || defined(__mips__)
+static int rx_copybreak = 1518;
+#else
 static int rx_copybreak;
+#endif
 
 /* Work-around for broken BIOSes: they are unable to get the chip back out of
power state D3 so PXE booting fails. bootparam(7): via-rhine.avoid_D3=1 */
_
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [patch 04/18] via-rhine: disable rx_copybreak on archs that don't allow unaligned DMA access

2007-08-10 Thread Francois Romieu
[EMAIL PROTECTED] [EMAIL PROTECTED] :
 From: Dustin Marquess [EMAIL PROTECTED]
 
 Patch to disable the rx_copybreak feature on hardware architectures that
 don't allow unaligned DMA access.
 
 #ifdef code taken from tulip_core.c.  Problem pointed out by Ivan
 Kokshaysky.

Color me confused but what are we trying to solve here ?

The rx_copybreak processing is performed after the DMA from the network
card to memory is done: DMA does not care about rx_copybreak. 

-- 
Ueimor
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html