Re: [patch 06/18] PCI-X/PCI-Express read control interfaces: use them in myrinet

2007-08-13 Thread Brice Goglin 
Jeff Garzik wrote:
> [EMAIL PROTECTED] wrote:
>> From: "Peter Oruba" <[EMAIL PROTECTED]>
>>
>> These driver changes incorporate the proposed PCI-X / PCI-Express
>> read byte
>> count interface.  Reading and setting those valuse doesn't take place
>> "manually", instead wrapping functions are called to allow quirks for
>> some
>> PCI bridges.
>>
>
> I presume Brice will resend this one to me, next time he pushes...


Ok, I'll take care of it.

Brice

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [patch 06/18] PCI-X/PCI-Express read control interfaces: use them in myrinet

2007-08-13 Thread Jeff Garzik 

[EMAIL PROTECTED] wrote:

From: "Peter Oruba" <[EMAIL PROTECTED]>

These driver changes incorporate the proposed PCI-X / PCI-Express read byte
count interface.  Reading and setting those valuse doesn't take place
"manually", instead wrapping functions are called to allow quirks for some
PCI bridges.

Signed-off by: Peter Oruba <[EMAIL PROTECTED]>
Based on work by Stephen Hemminger <[EMAIL PROTECTED]>
Cc: Roland Dreier <[EMAIL PROTECTED]>
Cc: Brice Goglin <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
---

 drivers/net/myri10ge/myri10ge.c |3 +--
 1 files changed, 1 insertion(+), 2 deletions(-)

diff -puN 
drivers/net/myri10ge/myri10ge.c~pci-x-pci-express-read-control-interfaces-myrinet
 drivers/net/myri10ge/myri10ge.c
--- 
a/drivers/net/myri10ge/myri10ge.c~pci-x-pci-express-read-control-interfaces-myrinet
+++ a/drivers/net/myri10ge/myri10ge.c
@@ -2884,8 +2884,7 @@ static int myri10ge_probe(struct pci_dev
status);
goto abort_with_netdev;
}
-   val = (val & ~PCI_EXP_DEVCTL_READRQ) | (5 << 12);
-   status = pci_write_config_word(pdev, cap + PCI_EXP_DEVCTL, val);
+   status = pcie_set_readrq(pdev, 4096);



I presume Brice will resend this one to me, next time he pushes...

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[patch 06/18] PCI-X/PCI-Express read control interfaces: use them in myrinet

2007-08-10 Thread akpm 
From: "Peter Oruba" <[EMAIL PROTECTED]>

These driver changes incorporate the proposed PCI-X / PCI-Express read byte
count interface.  Reading and setting those valuse doesn't take place
"manually", instead wrapping functions are called to allow quirks for some
PCI bridges.

Signed-off by: Peter Oruba <[EMAIL PROTECTED]>
Based on work by Stephen Hemminger <[EMAIL PROTECTED]>
Cc: Roland Dreier <[EMAIL PROTECTED]>
Cc: Brice Goglin <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
---

 drivers/net/myri10ge/myri10ge.c |3 +--
 1 files changed, 1 insertion(+), 2 deletions(-)

diff -puN 
drivers/net/myri10ge/myri10ge.c~pci-x-pci-express-read-control-interfaces-myrinet
 drivers/net/myri10ge/myri10ge.c
--- 
a/drivers/net/myri10ge/myri10ge.c~pci-x-pci-express-read-control-interfaces-myrinet
+++ a/drivers/net/myri10ge/myri10ge.c
@@ -2884,8 +2884,7 @@ static int myri10ge_probe(struct pci_dev
status);
goto abort_with_netdev;
}
-   val = (val & ~PCI_EXP_DEVCTL_READRQ) | (5 << 12);
-   status = pci_write_config_word(pdev, cap + PCI_EXP_DEVCTL, val);
+   status = pcie_set_readrq(pdev, 4096);
if (status != 0) {
dev_err(&pdev->dev, "Error %d writing PCI_EXP_DEVCTL\n",
status);
_
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html