[patch 5/5] d80211: allow wireless vlan interface to have same MAC an AP interface

[David Kimdon]

Wireless vlan interfaces need to have the same mac address as
AP interfaces.  The STA must not see the change when it is bound to
a specific vlan, so the address of the vlan interface must be the same
as the address of the AP interface the station associated with.

Signed-off-by: David Kimdon <[EMAIL PROTECTED]>
 
Index: wireless-dev/net/d80211/ieee80211.c
===
--- wireless-dev.orig/net/d80211/ieee80211.c
+++ wireless-dev/net/d80211/ieee80211.c
@@ -2092,7 +2092,12 @@ static inline int identical_mac_addr_all
 type2 == IEEE80211_IF_TYPE_WDS) ||
(type1 == IEEE80211_IF_TYPE_WDS &&
 (type2 == IEEE80211_IF_TYPE_WDS ||
- type2 == IEEE80211_IF_TYPE_AP)));
+ type2 == IEEE80211_IF_TYPE_AP)) ||
+   (type1 == IEEE80211_IF_TYPE_AP &&
+type2 == IEEE80211_IF_TYPE_VLAN) ||
+   (type1 == IEEE80211_IF_TYPE_VLAN &&
+(type2 == IEEE80211_IF_TYPE_AP ||
+ type2 == IEEE80211_IF_TYPE_VLAN)));
 }
 
 static int ieee80211_master_open(struct net_device *dev)

--
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [patch 5/5] d80211: allow wireless vlan interface to have same MAC an AP interface

[Jiri Benc]

All patches have been applied to my tree, thanks!

 Jiri

-- 
Jiri Benc
SUSE Labs
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [patch 5/5] d80211: allow wireless vlan interface to have same MAC an AP interface

[Johannes Berg]

On Tue, 2006-10-03 at 11:12 -0700, David Kimdon wrote:
> Wireless vlan interfaces need to have the same mac address as
> AP interfaces.  The STA must not see the change when it is bound to
> a specific vlan, so the address of the vlan interface must be the same
> as the address of the AP interface the station associated with.

Hm. Now I finally understand the vlan interface type. Neat. How do you
bind stas to one vlan interface? Is it possible to do on the fly after
EAP or similar?

Anyway. Wouldn't it make more sense to not even allow setting a MAC
address different from all AP interfaces, i.e. require that the VLAN
interface have the same MAC as one of the AP interfaces that exist?

And then there probably should be a check that prohibits binding a sta
to a vlan interface that has a different MAC than the AP interface it
is/was on... or something.

johannes


signature.asc
Description: This is a digitally signed message part