Re: [patch 8/9] smsc-ircc2: fix section reference mismatches

[Dmitry Torokhov]

On 7/7/06, Jeff Garzik <[EMAIL PROTECTED]> wrote:

[EMAIL PROTECTED] wrote:
> From: Dmitry Torokhov <[EMAIL PROTECTED]>
>
> subsystem_configurations array is only used by an __init function,
> therefore it should be marked __initdata, not __devinitdata.
>
> Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]>
> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
> ---
>
>  drivers/net/irda/smsc-ircc2.c |2 +-
>  1 files changed, 1 insertion(+), 1 deletion(-)
>
> diff -puN 
drivers/net/irda/smsc-ircc2.c~smsc-ircc2-fix-section-reference-mismatches 
drivers/net/irda/smsc-ircc2.c
> --- 
a/drivers/net/irda/smsc-ircc2.c~smsc-ircc2-fix-section-reference-mismatches
> +++ a/drivers/net/irda/smsc-ircc2.c
> @@ -2353,7 +2353,7 @@ static int __init smsc_superio_lpc(unsig
>  #ifdef CONFIG_PCI
>  #define PCIID_VENDOR_INTEL 0x8086
>  #define PCIID_VENDOR_ALI 0x10b9
> -static struct smsc_ircc_subsystem_configuration subsystem_configurations[] 
__devinitdata = {
> +static struct smsc_ircc_subsystem_configuration subsystem_configurations[] 
__initdata = {

Are you sure this fully solves the problem?



I think so, at least I see no more warnigns...


It seems like the functions referenced inside this are inappropriately
marked as well...



subsystem_configurations is only used from
smsc_ircc_preconfigure_subsystems(), which is called from
smsc_ircc_init(). Both of these are __init. All methods in
subsystem_configurations are marked as __init as well. Seems logical
that the strcture should be marked __initdata.

--
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [patch 8/9] smsc-ircc2: fix section reference mismatches

[Jeff Garzik]

[EMAIL PROTECTED] wrote:

From: Dmitry Torokhov <[EMAIL PROTECTED]>

subsystem_configurations array is only used by an __init function,
therefore it should be marked __initdata, not __devinitdata.

Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
---

 drivers/net/irda/smsc-ircc2.c |2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -puN 
drivers/net/irda/smsc-ircc2.c~smsc-ircc2-fix-section-reference-mismatches 
drivers/net/irda/smsc-ircc2.c
--- a/drivers/net/irda/smsc-ircc2.c~smsc-ircc2-fix-section-reference-mismatches
+++ a/drivers/net/irda/smsc-ircc2.c
@@ -2353,7 +2353,7 @@ static int __init smsc_superio_lpc(unsig
 #ifdef CONFIG_PCI
 #define PCIID_VENDOR_INTEL 0x8086
 #define PCIID_VENDOR_ALI 0x10b9
-static struct smsc_ircc_subsystem_configuration subsystem_configurations[] 
__devinitdata = {
+static struct smsc_ircc_subsystem_configuration subsystem_configurations[] 
__initdata = {


Are you sure this fully solves the problem?

It seems like the functions referenced inside this are inappropriately 
marked as well...



-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[patch 8/9] smsc-ircc2: fix section reference mismatches

[akpm]

From: Dmitry Torokhov <[EMAIL PROTECTED]>

subsystem_configurations array is only used by an __init function,
therefore it should be marked __initdata, not __devinitdata.

Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
---

 drivers/net/irda/smsc-ircc2.c |2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -puN 
drivers/net/irda/smsc-ircc2.c~smsc-ircc2-fix-section-reference-mismatches 
drivers/net/irda/smsc-ircc2.c
--- a/drivers/net/irda/smsc-ircc2.c~smsc-ircc2-fix-section-reference-mismatches
+++ a/drivers/net/irda/smsc-ircc2.c
@@ -2353,7 +2353,7 @@ static int __init smsc_superio_lpc(unsig
 #ifdef CONFIG_PCI
 #define PCIID_VENDOR_INTEL 0x8086
 #define PCIID_VENDOR_ALI 0x10b9
-static struct smsc_ircc_subsystem_configuration subsystem_configurations[] 
__devinitdata = {
+static struct smsc_ircc_subsystem_configuration subsystem_configurations[] 
__initdata = {
{
.vendor = PCIID_VENDOR_INTEL, /* Intel 82801DBM LPC bridge */
.device = 0x24cc,
_
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html