Re: [patch net-next] net: qcom/emac: fix a sizeof() typo
From: Dan Carpenter
Date: Mon, 13 Feb 2017 14:00:22 +0300
> We had intended to say "sizeof(u32)" but the "u" is missing.
> Fortunately, sizeof(32) is also 4, so the original code still works.
>
> Fixes: c4e7beea2192 ("net: qcom/emac: add ethtool support for reading
> hardware registers")
> Signed-off-by: Dan Carpenter
Applied.
Re: [patch net-next] net: qcom/emac: fix a sizeof() typo
Dan Carpenter wrote:
We had intended to say "sizeof(u32)" but the "u" is missing.
Fortunately, sizeof(32) is also 4, so the original code still works.
Fixes: c4e7beea2192 ("net: qcom/emac: add ethtool support for reading hardware
registers")
Signed-off-by: Dan Carpenter
Acked-by: Timur Tabi
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the
Code Aurora Forum, hosted by The Linux Foundation.
Re: [patch net-next] net: qcom/emac: fix a sizeof() typo
walter harms wrote: The question is: why is a simple calculation const*const separated into a function ? This is a callback function. That's just how it's defined. It's rare, but there are drivers that use the parameter, like this one: http://git.kernel.org/cgit/linux/kernel/git/davem/net-next.git/tree/drivers/net/ethernet/qlogic/qlge/qlge_ethtool.c#n591 -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation.
Re: [patch net-next] net: qcom/emac: fix a sizeof() typo
On Mon, Feb 13, 2017 at 12:55:03PM +0100, walter harms wrote:
>
>
> Am 13.02.2017 12:00, schrieb Dan Carpenter:
> > We had intended to say "sizeof(u32)" but the "u" is missing.
> > Fortunately, sizeof(32) is also 4, so the original code still works.
> >
> > Fixes: c4e7beea2192 ("net: qcom/emac: add ethtool support for reading
> > hardware registers")
> > Signed-off-by: Dan Carpenter
> >
> > diff --git a/drivers/net/ethernet/qualcomm/emac/emac-ethtool.c
> > b/drivers/net/ethernet/qualcomm/emac/emac-ethtool.c
> > index 0d9945fb79be..bbe24639aa5a 100644
> > --- a/drivers/net/ethernet/qualcomm/emac/emac-ethtool.c
> > +++ b/drivers/net/ethernet/qualcomm/emac/emac-ethtool.c
> > @@ -227,7 +227,7 @@ static void emac_get_regs(struct net_device *netdev,
> >
> > static int emac_get_regs_len(struct net_device *netdev)
> > {
> > - return EMAC_MAX_REG_SIZE * sizeof(32);
> > + return EMAC_MAX_REG_SIZE * sizeof(u32);
> > }
> >
>
>
> We have a function where the argument is ignored and the rest is const ?
>
> emac_ethtool_get_regs_len seems the only user. So it would be fairly easy to
> move that into that function.
It's not the only user. We have to pass netdev because it's used as a
function pointer.
regards,
dan carpenter
Re: [patch net-next] net: qcom/emac: fix a sizeof() typo
Am 13.02.2017 14:03, schrieb Timur Tabi: > walter harms wrote: >> We have a function where the argument is ignored and the rest is const ? >> >> emac_ethtool_get_regs_len seems the only user. So it would be fairly >> easy to >> move that into that function. >> >> @maintainer: >> Is there a deeper logic behind this ? > > I don't understand the question. The question is: why is a simple calculation const*const separated into a function ? re, wh
Re: [patch net-next] net: qcom/emac: fix a sizeof() typo
walter harms wrote: We have a function where the argument is ignored and the rest is const ? emac_ethtool_get_regs_len seems the only user. So it would be fairly easy to move that into that function. @maintainer: Is there a deeper logic behind this ? I don't understand the question. The patch is valid (I have no idea how I made that mistake). -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation.
Re: [patch net-next] net: qcom/emac: fix a sizeof() typo
Am 13.02.2017 12:00, schrieb Dan Carpenter:
> We had intended to say "sizeof(u32)" but the "u" is missing.
> Fortunately, sizeof(32) is also 4, so the original code still works.
>
> Fixes: c4e7beea2192 ("net: qcom/emac: add ethtool support for reading
> hardware registers")
> Signed-off-by: Dan Carpenter
>
> diff --git a/drivers/net/ethernet/qualcomm/emac/emac-ethtool.c
> b/drivers/net/ethernet/qualcomm/emac/emac-ethtool.c
> index 0d9945fb79be..bbe24639aa5a 100644
> --- a/drivers/net/ethernet/qualcomm/emac/emac-ethtool.c
> +++ b/drivers/net/ethernet/qualcomm/emac/emac-ethtool.c
> @@ -227,7 +227,7 @@ static void emac_get_regs(struct net_device *netdev,
>
> static int emac_get_regs_len(struct net_device *netdev)
> {
> - return EMAC_MAX_REG_SIZE * sizeof(32);
> + return EMAC_MAX_REG_SIZE * sizeof(u32);
> }
>
We have a function where the argument is ignored and the rest is const ?
emac_ethtool_get_regs_len seems the only user. So it would be fairly easy to
move that into that function.
@maintainer:
Is there a deeper logic behind this ?
re,
wh
> static const struct ethtool_ops emac_ethtool_ops = {
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
[patch net-next] net: qcom/emac: fix a sizeof() typo
We had intended to say "sizeof(u32)" but the "u" is missing.
Fortunately, sizeof(32) is also 4, so the original code still works.
Fixes: c4e7beea2192 ("net: qcom/emac: add ethtool support for reading hardware
registers")
Signed-off-by: Dan Carpenter
diff --git a/drivers/net/ethernet/qualcomm/emac/emac-ethtool.c
b/drivers/net/ethernet/qualcomm/emac/emac-ethtool.c
index 0d9945fb79be..bbe24639aa5a 100644
--- a/drivers/net/ethernet/qualcomm/emac/emac-ethtool.c
+++ b/drivers/net/ethernet/qualcomm/emac/emac-ethtool.c
@@ -227,7 +227,7 @@ static void emac_get_regs(struct net_device *netdev,
static int emac_get_regs_len(struct net_device *netdev)
{
- return EMAC_MAX_REG_SIZE * sizeof(32);
+ return EMAC_MAX_REG_SIZE * sizeof(u32);
}
static const struct ethtool_ops emac_ethtool_ops = {
