Re: [patch net-next 00/15] net: sched: summer cleanup part 2, ndo_setup_tc
Mon, Aug 07, 2017 at 08:09:01AM CEST, da...@davemloft.net wrote: >From: Jiri Pirko >Date: Mon, 7 Aug 2017 07:27:34 +0200 > >> Mon, Aug 07, 2017 at 06:37:49AM CEST, da...@davemloft.net wrote: >>>From: Jiri Pirko >>>Date: Sat, 5 Aug 2017 16:53:22 +0200 >>> From: Jiri Pirko This patchset focuses on ndo_setup_tc and its args. Currently there are couple of things that do not make much sense. The type is passed in struct tc_to_netdev, but as it is always required, should be arg of the ndo. Other things are passed as args but they are only relevant for cls offloads and not mqprio. Therefore, they should be pushed to struct. As the tc_to_netdev struct in the end is just a container of single pointer, we get rid of it and pass the struct according to type. So in the end, we have: ndo_setup_tc(dev, type, type_data_struct) There are couple of cosmetics done on the way to make things smooth. Also, reported error is consolidated to eopnotsupp in case the asked offload is not supported. >>> >>>Series applied, thanks Jiri. >> >> Pushed this already? I just got an email from kbuildbot, I missed hns3pf >> driver (3 days). I can send the fix as followup as well. Up to you. > >Luckily I didn't push yet, please respin with hns3pf fixed, thanks! Will do. Thanks.
Re: [patch net-next 00/15] net: sched: summer cleanup part 2, ndo_setup_tc
From: Jiri Pirko Date: Mon, 7 Aug 2017 07:27:34 +0200 > Mon, Aug 07, 2017 at 06:37:49AM CEST, da...@davemloft.net wrote: >>From: Jiri Pirko >>Date: Sat, 5 Aug 2017 16:53:22 +0200 >> >>> From: Jiri Pirko >>> >>> This patchset focuses on ndo_setup_tc and its args. >>> Currently there are couple of things that do not make much sense. >>> The type is passed in struct tc_to_netdev, but as it is always >>> required, should be arg of the ndo. Other things are passed as args >>> but they are only relevant for cls offloads and not mqprio. Therefore, >>> they should be pushed to struct. As the tc_to_netdev struct in the end >>> is just a container of single pointer, we get rid of it and pass the >>> struct according to type. So in the end, we have: >>> ndo_setup_tc(dev, type, type_data_struct) >>> >>> There are couple of cosmetics done on the way to make things smooth. >>> Also, reported error is consolidated to eopnotsupp in case the >>> asked offload is not supported. >> >>Series applied, thanks Jiri. > > Pushed this already? I just got an email from kbuildbot, I missed hns3pf > driver (3 days). I can send the fix as followup as well. Up to you. Luckily I didn't push yet, please respin with hns3pf fixed, thanks!
Re: [patch net-next 00/15] net: sched: summer cleanup part 2, ndo_setup_tc
Mon, Aug 07, 2017 at 06:37:49AM CEST, da...@davemloft.net wrote: >From: Jiri Pirko >Date: Sat, 5 Aug 2017 16:53:22 +0200 > >> From: Jiri Pirko >> >> This patchset focuses on ndo_setup_tc and its args. >> Currently there are couple of things that do not make much sense. >> The type is passed in struct tc_to_netdev, but as it is always >> required, should be arg of the ndo. Other things are passed as args >> but they are only relevant for cls offloads and not mqprio. Therefore, >> they should be pushed to struct. As the tc_to_netdev struct in the end >> is just a container of single pointer, we get rid of it and pass the >> struct according to type. So in the end, we have: >> ndo_setup_tc(dev, type, type_data_struct) >> >> There are couple of cosmetics done on the way to make things smooth. >> Also, reported error is consolidated to eopnotsupp in case the >> asked offload is not supported. > >Series applied, thanks Jiri. Pushed this already? I just got an email from kbuildbot, I missed hns3pf driver (3 days). I can send the fix as followup as well. Up to you.
Re: [patch net-next 00/15] net: sched: summer cleanup part 2, ndo_setup_tc
From: Jiri Pirko Date: Sat, 5 Aug 2017 16:53:22 +0200 > From: Jiri Pirko > > This patchset focuses on ndo_setup_tc and its args. > Currently there are couple of things that do not make much sense. > The type is passed in struct tc_to_netdev, but as it is always > required, should be arg of the ndo. Other things are passed as args > but they are only relevant for cls offloads and not mqprio. Therefore, > they should be pushed to struct. As the tc_to_netdev struct in the end > is just a container of single pointer, we get rid of it and pass the > struct according to type. So in the end, we have: > ndo_setup_tc(dev, type, type_data_struct) > > There are couple of cosmetics done on the way to make things smooth. > Also, reported error is consolidated to eopnotsupp in case the > asked offload is not supported. Series applied, thanks Jiri.
Re: [patch net-next 00/15] net: sched: summer cleanup part 2, ndo_setup_tc
On 17-08-05 10:53 AM, Jiri Pirko wrote: From: Jiri Pirko This patchset focuses on ndo_setup_tc and its args. Currently there are couple of things that do not make much sense. The type is passed in struct tc_to_netdev, but as it is always required, should be arg of the ndo. Other things are passed as args but they are only relevant for cls offloads and not mqprio. Therefore, they should be pushed to struct. As the tc_to_netdev struct in the end is just a container of single pointer, we get rid of it and pass the struct according to type. So in the end, we have: ndo_setup_tc(dev, type, type_data_struct) There are couple of cosmetics done on the way to make things smooth. Also, reported error is consolidated to eopnotsupp in case the asked offload is not supported. I did a quick review of all the patches and they are simple, nice cleanups. Instead of acking each one individually, i am just acking this one. Acked-by: Jamal Hadi Salim cheers, jamal
[patch net-next 00/15] net: sched: summer cleanup part 2, ndo_setup_tc
From: Jiri Pirko This patchset focuses on ndo_setup_tc and its args. Currently there are couple of things that do not make much sense. The type is passed in struct tc_to_netdev, but as it is always required, should be arg of the ndo. Other things are passed as args but they are only relevant for cls offloads and not mqprio. Therefore, they should be pushed to struct. As the tc_to_netdev struct in the end is just a container of single pointer, we get rid of it and pass the struct according to type. So in the end, we have: ndo_setup_tc(dev, type, type_data_struct) There are couple of cosmetics done on the way to make things smooth. Also, reported error is consolidated to eopnotsupp in case the asked offload is not supported. Jiri Pirko (15): net: sched: make type an argument for ndo_setup_tc net: sched: rename TC_SETUP_MATCHALL to TC_SETUP_CLSMATCHALL net: sched: make egress_dev flag part of flower offload struct cxgb4: push cls_u32 setup_tc processing into a separate function ixgbe: push cls_u32 and mqprio setup_tc processing into separate functions mlx5e: push cls_flower and mqprio setup_tc processing into separate functions mlx5e_rep: push cls_flower setup_tc processing into a separate function mlxsw: spectrum: push cls_flower and cls_matchall setup_tc processing into separate functions mlxsw: spectrum: rename cls arg in matchall processing dsa: push cls_matchall setup_tc processing into a separate function nfp: change flows in apps that offload ndo_setup_tc net: sched: push cls related args into cls_common structure net: sched: move prio into cls_common net: sched: change return value of ndo_setup_tc for driver supporting mqprio only net: sched: get rid of struct tc_to_netdev drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 14 +-- drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c| 14 +-- drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h| 4 +- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 14 +-- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c| 43 + drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32.c | 7 +- drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32.h | 6 +- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 13 +-- drivers/net/ethernet/intel/fm10k/fm10k_netdev.c| 14 +-- drivers/net/ethernet/intel/i40e/i40e_main.c| 15 +-- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 65 +++-- drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 17 ++-- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 55 +-- drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 45 + drivers/net/ethernet/mellanox/mlx5/core/en_tc.c| 2 +- drivers/net/ethernet/mellanox/mlx5/core/en_tc.h| 4 +- drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 102 - drivers/net/ethernet/mellanox/mlxsw/spectrum.h | 2 +- .../net/ethernet/mellanox/mlxsw/spectrum_flower.c | 4 +- drivers/net/ethernet/netronome/nfp/bpf/main.c | 20 ++-- drivers/net/ethernet/netronome/nfp/flower/main.h | 4 +- .../net/ethernet/netronome/nfp/flower/offload.c| 15 ++- drivers/net/ethernet/netronome/nfp/nfp_app.h | 8 +- drivers/net/ethernet/netronome/nfp/nfp_port.c | 9 +- drivers/net/ethernet/netronome/nfp/nfp_port.h | 5 +- drivers/net/ethernet/sfc/efx.h | 4 +- drivers/net/ethernet/sfc/falcon/efx.h | 4 +- drivers/net/ethernet/sfc/falcon/tx.c | 13 +-- drivers/net/ethernet/sfc/tx.c | 13 +-- drivers/net/ethernet/ti/netcp_core.c | 13 +-- include/linux/netdevice.h | 30 ++ include/net/pkt_cls.h | 23 - net/dsa/slave.c| 39 net/sched/cls_bpf.c| 24 ++--- net/sched/cls_flower.c | 60 +--- net/sched/cls_matchall.c | 31 +++ net/sched/cls_u32.c| 95 --- net/sched/sch_mqprio.c | 16 ++-- 38 files changed, 431 insertions(+), 435 deletions(-) -- 2.9.3
