Re: [PATCH net 0/2] mlxsw: Couple of fixes

2018-10-29 Thread David Miller 
From: Ido Schimmel 
Date: Mon, 29 Oct 2018 14:26:13 +

> First patch makes sure mlxsw does not ignore user requests to delete FDB
> entries that were learned by the device.
> 
> Second patch fixes a use-after-free that can be triggered by requesting
> a reload via devlink when the previous reload failed.
> 
> Please consider both patches for stable. They apply cleanly to both
> 4.18.y and 4.19.y.

Applied and queued up for -stable, thanks.

[PATCH net 0/2] mlxsw: Couple of fixes

2018-10-29 Thread Ido Schimmel 
First patch makes sure mlxsw does not ignore user requests to delete FDB
entries that were learned by the device.

Second patch fixes a use-after-free that can be triggered by requesting
a reload via devlink when the previous reload failed.

Please consider both patches for stable. They apply cleanly to both
4.18.y and 4.19.y.

Petr Machata (1):
  mlxsw: spectrum_switchdev: Don't ignore deletions of learned MACs

Shalom Toledo (1):
  mlxsw: core: Fix devlink unregister flow

 drivers/net/ethernet/mellanox/mlxsw/core.c| 24 +--
 .../mellanox/mlxsw/spectrum_switchdev.c   |  2 --
 2 files changed, 17 insertions(+), 9 deletions(-)

-- 
2.17.2

Re: [PATCH net 0/2] mlxsw: Couple of fixes

2018-10-04 Thread Ido Schimmel 
On Thu, Oct 04, 2018 at 09:56:54AM -0700, David Miller wrote:
> Series applied, and patch #2 queued up for -stable.
> 
> I was thinking about Fixes tags for the situation in patch #2 a bit,
> and it's probably best to list two Fixes tags.  One for the original
> bug that wasn't fixed properly, and one for the incomplete fix.
> 
> It's nice that you mentioned the incomplete fix in the commit message
> but a backporter might miss this chain of commits and dependencies it
> if it isn't in the Fixes: tags.

Noted. Will do so in future submissions.

Thanks, David.

Re: [PATCH net 0/2] mlxsw: Couple of fixes

2018-10-04 Thread David Miller 
From: Ido Schimmel 
Date: Thu, 4 Oct 2018 15:48:00 +

> First patch works around an hardware issue in Spectrum-2 where a field
> indicating the event type is always set to the same value. Since there
> are only two event types and they are reported using different queues,
> we can use the queue number to derive the event type.
> 
> Second patch prevents a router interface (RIF) leakage when a VLAN
> device is deleted from on top a bridge device.

Series applied, and patch #2 queued up for -stable.

I was thinking about Fixes tags for the situation in patch #2 a bit,
and it's probably best to list two Fixes tags.  One for the original
bug that wasn't fixed properly, and one for the incomplete fix.

It's nice that you mentioned the incomplete fix in the commit message
but a backporter might miss this chain of commits and dependencies it
if it isn't in the Fixes: tags.

Thanks.

[PATCH net 0/2] mlxsw: Couple of fixes

2018-10-04 Thread Ido Schimmel 
First patch works around an hardware issue in Spectrum-2 where a field
indicating the event type is always set to the same value. Since there
are only two event types and they are reported using different queues,
we can use the queue number to derive the event type.

Second patch prevents a router interface (RIF) leakage when a VLAN
device is deleted from on top a bridge device.

Ido Schimmel (1):
  mlxsw: spectrum: Delete RIF when VLAN device is removed

Nir Dotan (1):
  mlxsw: pci: Derive event type from event queue number

 drivers/net/ethernet/mellanox/mlxsw/pci.c  | 11 +++
 drivers/net/ethernet/mellanox/mlxsw/spectrum.c |  2 ++
 2 files changed, 9 insertions(+), 4 deletions(-)

-- 
2.17.1

Re: [patch net 0/2] mlxsw: couple of fixes

2018-02-27 Thread Jiri Pirko 
Tue, Feb 27, 2018 at 08:39:06PM CET, da...@davemloft.net wrote:
>From: Jiri Pirko 
>Date: Tue, 27 Feb 2018 12:56:12 +0100
>
>> From: Jiri Pirko 
>> 
>> Couple of unrelated fixes for mlxsw.
>> 
>> ---
>> Please consider the first patch for -stable.
>> Thanks!
>
>Patch #2 doesn't apply cleanly, please respin.

Okay.

Re: [patch net 0/2] mlxsw: couple of fixes

2018-02-27 Thread David Miller 
From: Jiri Pirko 
Date: Tue, 27 Feb 2018 12:56:12 +0100

> From: Jiri Pirko 
> 
> Couple of unrelated fixes for mlxsw.
> 
> ---
> Please consider the first patch for -stable.
> Thanks!

Patch #2 doesn't apply cleanly, please respin.

Thank you.

[patch net 0/2] mlxsw: couple of fixes

2018-02-27 Thread Jiri Pirko 
From: Jiri Pirko 

Couple of unrelated fixes for mlxsw.

---
Please consider the first patch for -stable.
Thanks!

Jiri Pirko (2):
  mlxsw: core: Fix flex keys scratchpad offset conflict
  mlxsw: spectrum: Fix handling of resource_size_param

 .../ethernet/mellanox/mlxsw/core_acl_flex_keys.h   | 20 +++---
 drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 76 +++---
 include/net/devlink.h  | 18 -
 net/core/devlink.c |  7 +-
 4 files changed, 68 insertions(+), 53 deletions(-)

-- 
2.14.3

Re: [patch net 0/2] mlxsw: couple of fixes

2018-01-10 Thread David Miller 
From: Jiri Pirko 
Date: Wed, 10 Jan 2018 11:42:42 +0100

> From: Jiri Pirko 
> 
> Couple of small fixes for mlxsw driver.

Series applied, thanks.

[patch net 0/2] mlxsw: couple of fixes

2018-01-10 Thread Jiri Pirko 
From: Jiri Pirko 

Couple of small fixes for mlxsw driver.

Jiri Pirko (1):
  mlxsw: spectrum_qdisc: Don't use variable array in
mlxsw_sp_tclass_congestion_enable

Yuval Mintz (1):
  mlxsw: pci: Wait after reset before accessing HW

 drivers/net/ethernet/mellanox/mlxsw/pci.c| 7 ++-
 drivers/net/ethernet/mellanox/mlxsw/pci_hw.h | 1 +
 drivers/net/ethernet/mellanox/mlxsw/spectrum_qdisc.c | 7 ---
 3 files changed, 11 insertions(+), 4 deletions(-)

-- 
2.14.3

Re: [patch net 0/2] mlxsw: Couple of fixes

2017-08-04 Thread David Miller 
From: Jiri Pirko 
Date: Fri,  4 Aug 2017 14:12:28 +0200

> From: Jiri Pirko 
> 
> Ido says:
> 
> The first patch prevents us from warning about valid situations that can
> happen due to the fact that some operations in switchdev are deferred.
> 
> Second patch fixes a long standing problem in which we didn't correctly
> free resources upon module removal, resulting in a memory leak.

Series applied, thanks!

[patch net 0/2] mlxsw: Couple of fixes

2017-08-04 Thread Jiri Pirko 
From: Jiri Pirko 

Ido says:

The first patch prevents us from warning about valid situations that can
happen due to the fact that some operations in switchdev are deferred.

Second patch fixes a long standing problem in which we didn't correctly
free resources upon module removal, resulting in a memory leak.

Ido Schimmel (2):
  mlxsw: spectrum_switchdev: Don't warn about valid situations
  mlxsw: spectrum_switchdev: Release multicast groups during fini

 .../ethernet/mellanox/mlxsw/spectrum_switchdev.c   | 37 ++
 1 file changed, 24 insertions(+), 13 deletions(-)

-- 
2.9.3

Re: [patch net 0/2] mlxsw: couple of fixes

2017-05-18 Thread David Miller 
From: Jiri Pirko 
Date: Thu, 18 May 2017 09:18:51 +0200

> Couple of fixes from Arkadi

Series applied.

[patch net 0/2] mlxsw: couple of fixes

2017-05-18 Thread Jiri Pirko 
From: Jiri Pirko 

Cuple of fixes from Arkadi

Arkadi Sharshevsky (2):
  mlxsw: spectrum_dpipe: Fix incorrect entry index
  mlxsw: spectrum_router: Fix rif counter freeing routine

 drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c  | 3 ++-
 drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 3 +++
 2 files changed, 5 insertions(+), 1 deletion(-)

-- 
2.9.3

Re: [patch net 0/2] mlxsw: Couple of fixes

2017-03-14 Thread David Miller 
From: Jiri Pirko 
Date: Tue, 14 Mar 2017 13:59:59 +0100

> Couple or small fixes.

Series applied, thanks Jiri.

[patch net 0/2] mlxsw: Couple of fixes

2017-03-14 Thread Jiri Pirko 
From: Jiri Pirko 

Couple or small fixes.

Jiri Pirko (2):
  mlxsw: reg: Fix SPVM max record count
  mlxsw: reg: Fix SPVMLR max record count

 drivers/net/ethernet/mellanox/mlxsw/reg.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.7.4

Re: [patch net 0/2] mlxsw: Couple of fixes

2016-11-13 Thread David Miller 
From: Jiri Pirko 
Date: Fri, 11 Nov 2016 11:20:40 +0100

> Please, queue-up both for stable. Thanks!

Series applied and queued up for -stable, thanks.

[patch net 0/2] mlxsw: Couple of fixes

2016-11-11 Thread Jiri Pirko 
From: Jiri Pirko 

Please, queue-up both for stable. Thanks!

Arkadi Sharshevsky (1):
  mlxsw: spectrum_router: Correctly dump neighbour activity

Yotam Gigi (1):
  mlxsw: spectrum: Fix refcount bug on span entries

 drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 11 ++-
 .../net/ethernet/mellanox/mlxsw/spectrum_router.c  | 22 +-
 2 files changed, 27 insertions(+), 6 deletions(-)

-- 
2.7.4

Re: [patch net 0/2] mlxsw: Couple of fixes

2016-10-28 Thread David Miller 
From: Jiri Pirko 
Date: Tue, 25 Oct 2016 11:25:55 +0200

> From: Jiri Pirko 
> 
> Couple of LPM tree management fixes.

Series applied, thanks Jiri.

[patch net 0/2] mlxsw: Couple of fixes

2016-10-25 Thread Jiri Pirko 
From: Jiri Pirko 

Couple of LPM tree management fixes.

Jiri Pirko (2):
  mlxsw: spectrum_router: Save requested prefix bitlist when creating
tree
  mlxsw: spectrum_router: Compare only trees which are in use during
tree get

 drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

-- 
2.5.5

Re: [patch net 0/2] mlxsw: Couple of fixes

2016-10-05 Thread Jiri Pirko 
Wed, Oct 05, 2016 at 02:29:27AM CEST, da...@davemloft.net wrote:
>From: Jiri Pirko 
>Date: Tue,  4 Oct 2016 09:46:03 +0200
>
>> Couple of fixes from Yotam.
>
>Series applied, thanks.
>
>Note that needed_headroom is a request, rather than a guarantee, so you
>may in some rare cases need to realloc your headroom if the kernel was
>not able to meet your request.

We already do that: 

if (unlikely(skb_headroom(skb) < MLXSW_TXHDR_LEN)) {
struct sk_buff *skb_orig = skb;

skb = skb_realloc_headroom(skb, MLXSW_TXHDR_LEN);
if (!skb) {
this_cpu_inc(mlxsw_sp_port->pcpu_stats->tx_dropped);
dev_kfree_skb_any(skb_orig);
return NETDEV_TX_OK;
}
}

Re: [patch net 0/2] mlxsw: Couple of fixes

2016-10-04 Thread David Miller 
From: Jiri Pirko 
Date: Tue,  4 Oct 2016 09:46:03 +0200

> Couple of fixes from Yotam.

Series applied, thanks.

Note that needed_headroom is a request, rather than a guarantee, so you
may in some rare cases need to realloc your headroom if the kernel was
not able to meet your request.

[patch net 0/2] mlxsw: Couple of fixes

2016-10-04 Thread Jiri Pirko 
From: Jiri Pirko 

Couple of fixes from Yotam.

Yotam Gigi (2):
  mlxsw: spectrum: Fix misuse of hard_header_len
  mlxsw: switchx2: Fix misuse of hard_header_len

 drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 2 +-
 drivers/net/ethernet/mellanox/mlxsw/switchx2.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

-- 
2.5.5

Re: [patch net 0/2] mlxsw: couple of fixes

2016-09-09 Thread David Miller 
From: Jiri Pirko 
Date: Thu,  8 Sep 2016 08:16:00 +0200

> Couple of fixes from Ido and myself.

Series applied, thanks Jiri.

[patch net 0/2] mlxsw: couple of fixes

2016-09-08 Thread Jiri Pirko 
From: Jiri Pirko 

Couple of fixes from Ido and myself.

Ido Schimmel (1):
  mlxsw: spectrum: Set port type before setting its address

Jiri Pirko (1):
  mlxsw: spectrum_router: Fix error path in mlxsw_sp_router_init

 drivers/net/ethernet/mellanox/mlxsw/spectrum.c| 18 +-
 drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c |  9 -
 2 files changed, 17 insertions(+), 10 deletions(-)

-- 
2.5.5

Re: [patch net 0/2] mlxsw: couple of fixes

2016-08-24 Thread David Miller 
From: Jiri Pirko 
Date: Wed, 24 Aug 2016 11:18:50 +0200

> Ido Schimmel (1):
>   mlxsw: spectrum: Add missing flood to router port
> 
> Yotam Gigi (1):
>   mlxsw: router: Enable neighbors to be created on stacked devices

Both applied, thanks Jiri.

[patch net 0/2] mlxsw: couple of fixes

2016-08-24 Thread Jiri Pirko 
From: Jiri Pirko 

Ido Schimmel (1):
  mlxsw: spectrum: Add missing flood to router port

Yotam Gigi (1):
  mlxsw: router: Enable neighbors to be created on stacked devices

 drivers/net/ethernet/mellanox/mlxsw/port.h |  1 +
 drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 43 +-
 .../net/ethernet/mellanox/mlxsw/spectrum_router.c  |  2 +-
 3 files changed, 44 insertions(+), 2 deletions(-)

-- 
2.5.5

Re: [patch net 0/2] mlxsw: couple of fixes

2016-06-17 Thread David Miller 
From: Jiri Pirko 
Date: Fri, 17 Jun 2016 15:09:04 +0200

> Couple of slowpath tx stats fixes for Spectrum and SwitchX-2.

Series applied, thanks Jiri.

[patch net 0/2] mlxsw: couple of fixes

2016-06-17 Thread Jiri Pirko 
From: Jiri Pirko 

Couple of slowpath tx stats fixes for Spectrum and SwitchX-2.

Nogah Frankel (2):
  mlxsw: spectrum: Don't count internal TX header bytes to stats
  mlxsw: switchx2: Don't count internal TX header bytes to stats

 drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 6 +-
 drivers/net/ethernet/mellanox/mlxsw/switchx2.c | 5 -
 2 files changed, 9 insertions(+), 2 deletions(-)

-- 
2.5.5

Re: [patch net 0/2] mlxsw: couple of fixes

2016-06-09 Thread David Miller 
From: Jiri Pirko 
Date: Thu,  9 Jun 2016 09:51:38 +0200

> Couple of fixes from Ido.

Series applied, thanks.

[patch net 0/2] mlxsw: couple of fixes

2016-06-09 Thread Jiri Pirko 
From: Jiri Pirko 

Couple of fixes from Ido.

Ido Schimmel (2):
  mlxsw: spectrum: Make split flow match firmware requirements
  mlxsw: spectrum: Don't sleep during ndo_get_phys_port_name()

 drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 203 ++---
 drivers/net/ethernet/mellanox/mlxsw/spectrum.h |   5 +
 2 files changed, 117 insertions(+), 91 deletions(-)

-- 
2.5.5

Re: [patch net 0/2] mlxsw: Couple of fixes

2016-05-06 Thread David Miller 
From: Jiri Pirko 
Date: Fri,  6 May 2016 22:18:38 +0200

> From: Jiri Pirko 
> 
> Ido Schimmel (2):
>   mlxsw: spectrum: Fix rollback order in LAG join failure
>   mlxsw: spectrum: Add missing rollback in flood configuration

Applied.

[patch net 0/2] mlxsw: Couple of fixes

2016-05-06 Thread Jiri Pirko 
From: Jiri Pirko 

Ido Schimmel (2):
  mlxsw: spectrum: Fix rollback order in LAG join failure
  mlxsw: spectrum: Add missing rollback in flood configuration

 drivers/net/ethernet/mellanox/mlxsw/spectrum.c   | 4 ++--
 drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c | 8 
 2 files changed, 10 insertions(+), 2 deletions(-)

-- 
2.5.5

[patch net 0/2] mlxsw: couple of fixes

2016-03-07 Thread Jiri Pirko 
From: Jiri Pirko 

Couple of fixes from Ido.

Ido Schimmel (2):
  mlxsw: spectrum: Always decrement bridge's ref count
  mlxsw: pci: Correctly determine if descriptor queue is full

 drivers/net/ethernet/mellanox/mlxsw/pci.c  | 2 +-
 drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 4 +---
 2 files changed, 2 insertions(+), 4 deletions(-)

-- 
2.5.0

Re: [patch net 0/2] mlxsw: couple of fixes

2015-10-11 Thread David Miller 
From: Jiri Pirko 
Date: Thu,  8 Oct 2015 15:17:36 +0200

> Just a couple of small fixes.

Series applied, thanks Jiri.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[patch net 0/2] mlxsw: couple of fixes

2015-10-08 Thread Jiri Pirko 
From: Jiri Pirko 

Just a couple of small fixes.

Elad Raz (1):
  mlxsw: switchx2: changing order of exit fallbacks

Ido Schimmel (1):
  mlxsw: Fix bug in __mlxsw_item_bit_array_offset

 drivers/net/ethernet/mellanox/mlxsw/item.h | 4 +++-
 drivers/net/ethernet/mellanox/mlxsw/switchx2.c | 2 +-
 2 files changed, 4 insertions(+), 2 deletions(-)

-- 
1.9.3

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html