Re: [suricata PATCH 0/3] Suricata cleanup makefile
Hello Jesper, On Wed, 2018-02-07 at 23:21 +0100, Jesper Dangaard Brouer wrote: > Hi Eric, > > I've improved the Suricata ebpf makefile, in-order to avoid > generating > the .eh_frame sections. This required changing the code a bit, to > allow using clang -target bpf. > > The makefile have also been improved to stop on clang compile errors, > instead of generating an almost empty BPF ELF file. > > Could I ask you to get these changes into Suricata, through correct > process for this Open Source project? Sure, I'm reviewing the code, testing it and I will do a Pull Request on github. Thanks a lot for that, that's a really valuable help! BR, -- Eric Leblond
[suricata PATCH 0/3] Suricata cleanup makefile
Hi Eric, I've improved the Suricata ebpf makefile, in-order to avoid generating the .eh_frame sections. This required changing the code a bit, to allow using clang -target bpf. The makefile have also been improved to stop on clang compile errors, instead of generating an almost empty BPF ELF file. Could I ask you to get these changes into Suricata, through correct process for this Open Source project? --Jesper --- Jesper Dangaard Brouer (3): suricata/ebpf: take clang -target bpf include issue of stdint.h into account suricata/ebpf: compile with clang -target bpf suricata/ebpf: improving the ebpf makefile ebpf/Makefile.am | 22 ++ ebpf/bypass_filter.c | 27 +-- ebpf/filter.c|3 +-- ebpf/hash_func01.h | 12 ++-- ebpf/lb.c| 11 +-- ebpf/vlan_filter.c |5 ++--- ebpf/xdp_filter.c| 42 -- 7 files changed, 65 insertions(+), 57 deletions(-) --
