Re: [usb regression] Re: [PATCH 2.6.24-rc3] Fix /proc/net breakage
On Tue, 1 Jan 2008, Greg KH wrote: On Mon, Dec 31, 2007 at 11:26:43AM -0800, Greg KH wrote: On Mon, Dec 31, 2007 at 12:49:52PM -0500, Alan Stern wrote: On Sun, 30 Dec 2007, Greg KH wrote: It looks like Greg misused the debugfs API -- which is ironic, because he wrote debugfs in the first place! :-) Ok, no, I didn't write that patch, I'm getting very confused here. In 2.6.24-rc6 there is no usage of debugfs in the ohci driver. In the -mm tree there is a patch, from Tony Jones, that moves some debug code out of sysfs and into debugfs where it belongs. It does it for both the ehci and ohci USB host controller drivers, and this is the code that is incorrect if CONFIG_DEBUGFS is not enabled. My mistake; I got the impression you had written that new code rather than Tony. BTW, I don't recall ever seeing Tony's patch announced on linux-usb or linux-usb-devel. Did I simply miss it? So, for the 2.6.24 release, nothing needs to be changed, all is good, and there is no regression. Right? Or am I still confused about this whole thing? Correct. The problem exists only in -mm and your development tree. I will go fix up Tony's patches in the -mm tree that do not handle the error return values from debugfs properly, but that is not such a rush, as Tony is on vacation for a few weeks, and those patches are going to be going in only after 2.6.24 is out. The fix I posted earlier in this thread should simply be merged into Tony's patches. Alan Stern -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [usb regression] Re: [PATCH 2.6.24-rc3] Fix /proc/net breakage
On Wednesday 02 January 2008, Alan Stern wrote: BTW, I don't recall ever seeing Tony's patch announced on linux-usb or linux-usb-devel. Did I simply miss it? I think he didn't post it. I got some questions from him at one point, which I answered, but as I recall he decided for some reason to stop that work. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [usb regression] Re: [PATCH 2.6.24-rc3] Fix /proc/net breakage
On Mon, Dec 31, 2007 at 11:26:43AM -0800, Greg KH wrote: On Mon, Dec 31, 2007 at 12:49:52PM -0500, Alan Stern wrote: On Sun, 30 Dec 2007, Greg KH wrote: It looks like Greg misused the debugfs API -- which is ironic, because he wrote debugfs in the first place! :-) Oh crap, sorry, I did mess that up :( Ok, no, I didn't write that patch, I'm getting very confused here. In 2.6.24-rc6 there is no usage of debugfs in the ohci driver. In the -mm tree there is a patch, from Tony Jones, that moves some debug code out of sysfs and into debugfs where it belongs. It does it for both the ehci and ohci USB host controller drivers, and this is the code that is incorrect if CONFIG_DEBUGFS is not enabled. So, for the 2.6.24 release, nothing needs to be changed, all is good, and there is no regression. Right? Or am I still confused about this whole thing? I will go fix up Tony's patches in the -mm tree that do not handle the error return values from debugfs properly, but that is not such a rush, as Tony is on vacation for a few weeks, and those patches are going to be going in only after 2.6.24 is out. Hm, I wonder if this means I can go back to drinking more holiday wine... :) thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [usb regression] Re: [PATCH 2.6.24-rc3] Fix /proc/net breakage
Hi, On Sun, Dec 30, 2007 at 03:34:45PM -0500, Alan Stern wrote: It looks like Greg misused the debugfs API -- which is ironic, because he wrote debugfs in the first place! :-) Let me know if this patch fixes the problem. If it does, I'll submit it to Greg with all the proper accoutrements. Finally a 2.6.24-rc6-mm1 with working USB WLAN. :) IOW I can confirm that this was the cause of the USB problem I was having. Thanks! Andreas Mohr -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [usb regression] Re: [PATCH 2.6.24-rc3] Fix /proc/net breakage
Hi, On Tue, Jan 01, 2008 at 10:00:06PM -0800, Greg KH wrote: Ok, no, I didn't write that patch, I'm getting very confused here. In 2.6.24-rc6 there is no usage of debugfs in the ohci driver. In the -mm tree there is a patch, from Tony Jones, that moves some debug code out of sysfs and into debugfs where it belongs. It does it for both the ehci and ohci USB host controller drivers, and this is the code that is incorrect if CONFIG_DEBUGFS is not enabled. So, for the 2.6.24 release, nothing needs to be changed, all is good, and there is no regression. Right? Or am I still confused about this whole thing? Probably, since I also wasn't sure about this getting added to the post-2.6.23 regressions. I'd expect this problem to be -mm only myself, but then I didn't actively verify it in code (and I haven't tried -rc6 proper on that machine yet either, build takes ages ;). OK, since I cannot really offer anything other than positive feelings about this being non-rc6 breakage, should I try -rc6 proper, too? Hm, I wonder if this means I can go back to drinking more holiday wine... :) .even more confusion? :) Thanks for your help, Andreas Mohr -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [usb regression] Re: [PATCH 2.6.24-rc3] Fix /proc/net breakage
On Wed, Jan 02, 2008 at 07:13:08AM +0100, Andreas Mohr wrote: Hi, On Tue, Jan 01, 2008 at 10:00:06PM -0800, Greg KH wrote: Ok, no, I didn't write that patch, I'm getting very confused here. In 2.6.24-rc6 there is no usage of debugfs in the ohci driver. In the -mm tree there is a patch, from Tony Jones, that moves some debug code out of sysfs and into debugfs where it belongs. It does it for both the ehci and ohci USB host controller drivers, and this is the code that is incorrect if CONFIG_DEBUGFS is not enabled. So, for the 2.6.24 release, nothing needs to be changed, all is good, and there is no regression. Right? Or am I still confused about this whole thing? Probably, since I also wasn't sure about this getting added to the post-2.6.23 regressions. I'd expect this problem to be -mm only myself, but then I didn't actively verify it in code (and I haven't tried -rc6 proper on that machine yet either, build takes ages ;). OK, since I cannot really offer anything other than positive feelings about this being non-rc6 breakage, should I try -rc6 proper, too? Please do, that would be very helpful. As the code being discussed isn't even in Linus's tree, it's hard to see how this could be a proposed fix for the regression :) thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
