Re: IPVS: use proper timeout instead of fixed value
On Mon, Oct 29, 2007 at 04:05:55PM +0900, Simon Horman wrote: > From: Andy Gospodarek <[EMAIL PROTECTED]> > > Instead of using the default timeout of 3 minutes, this uses the timeout > specific to the protocol used for the connection. The 3 minute timeout > seems somewhat arbitrary (though I know it is used other places in the > ipvs code) and when failing over it would be much nicer to use one of > the configured timeout values. > > Signed-off-by: Andy Gospodarek <[EMAIL PROTECTED]> > Acked-by: Simon Horman <[EMAIL PROTECTED]> > Thanks for re-visiting this, Simon! It's too bad that the other work never got done, but I'm glad to see this will get included. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: IPVS: use proper timeout instead of fixed value
From: Simon Horman <[EMAIL PROTECTED]> Date: Mon, 29 Oct 2007 17:59:23 +0900 > On Mon, Oct 29, 2007 at 01:35:15AM -0700, David Miller wrote: > > From: Simon Horman <[EMAIL PROTECTED]> > > Date: Mon, 29 Oct 2007 16:05:55 +0900 (JST) > > > > > From: Andy Gospodarek <[EMAIL PROTECTED]> > > > > > > Instead of using the default timeout of 3 minutes, this uses the timeout > > > specific to the protocol used for the connection. The 3 minute timeout > > > seems somewhat arbitrary (though I know it is used other places in the > > > ipvs code) and when failing over it would be much nicer to use one of > > > the configured timeout values. > > > > > > Signed-off-by: Andy Gospodarek <[EMAIL PROTECTED]> > > > Acked-by: Simon Horman <[EMAIL PROTECTED]> > > > > I would apply this but it does not apply to current 2.6.x, > > please resubmit. > > I tried against net-2.6 and it seemed to work. > Was I mistaken or should I be using a different tree? Nope, that should be good. Maybe I did something stupid or it got clobbered in transit somehow. Please resend it privately to me under seperate cover and we'll sort it out. Thanks Simon! - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: IPVS: use proper timeout instead of fixed value
On Mon, Oct 29, 2007 at 01:35:15AM -0700, David Miller wrote: > From: Simon Horman <[EMAIL PROTECTED]> > Date: Mon, 29 Oct 2007 16:05:55 +0900 (JST) > > > From: Andy Gospodarek <[EMAIL PROTECTED]> > > > > Instead of using the default timeout of 3 minutes, this uses the timeout > > specific to the protocol used for the connection. The 3 minute timeout > > seems somewhat arbitrary (though I know it is used other places in the > > ipvs code) and when failing over it would be much nicer to use one of > > the configured timeout values. > > > > Signed-off-by: Andy Gospodarek <[EMAIL PROTECTED]> > > Acked-by: Simon Horman <[EMAIL PROTECTED]> > > I would apply this but it does not apply to current 2.6.x, > please resubmit. I tried against net-2.6 and it seemed to work. Was I mistaken or should I be using a different tree? -- Horms H: http://www.vergenet.net/~horms/ W: http://www.valinux.co.jp/en/ - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: IPVS: use proper timeout instead of fixed value
From: Simon Horman <[EMAIL PROTECTED]> Date: Mon, 29 Oct 2007 16:05:55 +0900 (JST) > From: Andy Gospodarek <[EMAIL PROTECTED]> > > Instead of using the default timeout of 3 minutes, this uses the timeout > specific to the protocol used for the connection. The 3 minute timeout > seems somewhat arbitrary (though I know it is used other places in the > ipvs code) and when failing over it would be much nicer to use one of > the configured timeout values. > > Signed-off-by: Andy Gospodarek <[EMAIL PROTECTED]> > Acked-by: Simon Horman <[EMAIL PROTECTED]> I would apply this but it does not apply to current 2.6.x, please resubmit. Thanks. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
IPVS: use proper timeout instead of fixed value
From: Andy Gospodarek <[EMAIL PROTECTED]>
Instead of using the default timeout of 3 minutes, this uses the timeout
specific to the protocol used for the connection. The 3 minute timeout
seems somewhat arbitrary (though I know it is used other places in the
ipvs code) and when failing over it would be much nicer to use one of
the configured timeout values.
Signed-off-by: Andy Gospodarek <[EMAIL PROTECTED]>
Acked-by: Simon Horman <[EMAIL PROTECTED]>
---
Hi,
I'd like to revisit this patch which was originally posted
to netdev in May 2006.
Looking through the archives as far as I can see there was
some discussion as to whether it would be good to send timeout
information in the synchronisation packet, and some discussion
as to whether it would be good to make the timeout configurable
on the slave side, and then the ball was dropped.
It seems to me that regardless of whether or not the syncronisation
protocol should be expanded to include timeout information,
and wheather or not it should be configurable on the slave side,
this patch is a good idea as the default that it provides seems
to be much more sensible than the current arrangement.
Andreas Lundqvist provided me with an example where his
cluser has long often idle connections and that in this case
the short, 3 minute default timeout, really is quite useless.
ip_vs_sync.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/net/ipv4/ipvs/ip_vs_sync.c b/net/ipv4/ipvs/ip_vs_sync.c
--- a/net/ipv4/ipvs/ip_vs_sync.c
+++ b/net/ipv4/ipvs/ip_vs_sync.c
@@ -67,7 +67,6 @@ struct ip_vs_sync_conn_options {
struct ip_vs_seqout_seq;/* outgoing seq. struct */
};
-#define IP_VS_SYNC_CONN_TIMEOUT (3*60*HZ)
#define SIMPLE_CONN_SIZE (sizeof(struct ip_vs_sync_conn))
#define FULL_CONN_SIZE \
(sizeof(struct ip_vs_sync_conn) + sizeof(struct ip_vs_sync_conn_options))
@@ -279,6 +278,7 @@ static void ip_vs_process_message(const
struct ip_vs_sync_conn *s;
struct ip_vs_sync_conn_options *opt;
struct ip_vs_conn *cp;
+ struct ip_vs_protocol *pp;
char *p;
int i;
@@ -337,7 +337,8 @@ static void ip_vs_process_message(const
p += SIMPLE_CONN_SIZE;
atomic_set(&cp->in_pkts, sysctl_ip_vs_sync_threshold[0]);
- cp->timeout = IP_VS_SYNC_CONN_TIMEOUT;
+ pp = ip_vs_proto_get(s->protocol);
+ cp->timeout = pp->timeout_table[cp->state];
ip_vs_conn_put(cp);
if (p > buffer+buflen) {
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [rfc][patch] ipvs: use proper timeout instead of fixed value
Hi Andy,
On Sun, 7 May 2006, Andy Gospodarek wrote:
On Sun, May 07, 2006 at 11:32:00PM +0800, Wensong Zhang wrote:
Hi Andy,
Yes, the original sychronziation design is a sort of arbitary or
compromised solution. We don't want to synchronize every state change from
master to backup load balancer, because we were afraid that there were too
much state change synchronization messages and there would be some
performance penalty. So, we only sychronize the connection of TCP
ESTABLISHED state or UDP to backup load balancer, and use the timeout of 3
minutes.
Your change is probably ok, but we should be aware that it may create a
lot of connection entries at backup load balancer for TCP applications,
which is much more than that at master load balancer, because there is no
connection close synchronization and timeout is changed to 3 minutes to 15
minutes.
Wensong,
This is an interesting point. Do you feel it would be reasonable to
synchronize states for extablished connections and terminating
connections rather than all state changes? It would seem keeping the
table at a minimum size would be desireable without tracking every state
change since that could create too much noice between master and backup
-- especially for short-lived connections.
Yeah, it's reasonable, but we need to synchronize updating states of
established connections too when established connections keep receiving
packets, so that we can maintain the timeout of those established
connections more accurately. It's really a trade-off to keep connection
timeout more accurate in the mean while keeping the volume of
synchronization messages as low as possible.
I could work some more to expand and test this patch to include more
detailed connection tracking if you (or anyone else) feel it would be
valuable.
Maybe it's better to write a more detailed design first.
Thanks,
Wensong
-andy
The simple solution is probably to make timeout value tuneable, so that
users can tune it for their application. The better solution is to
synchronize very connection state change from master to backup, so that
backup have almost the same state of connections.
Thanks,
Wensong
On Thu, 4 May 2006, Andy Gospodarek wrote:
Instead of using the default timeout of 3 minutes, this uses the timeout
specific to the protocol used for the connection. The 3 minute timeout
seems somewhat arbitrary (though I know it is used other places in the
ipvs code) and when failing over it would be much nicer to use one of
the configured timeout values.
Signed-off-by: Andy Gospodarek <[EMAIL PROTECTED]>
---
ip_vs_sync.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/net/ipv4/ipvs/ip_vs_sync.c b/net/ipv4/ipvs/ip_vs_sync.c
--- a/net/ipv4/ipvs/ip_vs_sync.c
+++ b/net/ipv4/ipvs/ip_vs_sync.c
@@ -67,7 +67,6 @@ struct ip_vs_sync_conn_options {
struct ip_vs_seqout_seq;/* outgoing seq. struct */
};
-#define IP_VS_SYNC_CONN_TIMEOUT (3*60*HZ)
#define SIMPLE_CONN_SIZE (sizeof(struct ip_vs_sync_conn))
#define FULL_CONN_SIZE \
(sizeof(struct ip_vs_sync_conn) + sizeof(struct ip_vs_sync_conn_options))
@@ -279,6 +278,7 @@ static void ip_vs_process_message(const
struct ip_vs_sync_conn *s;
struct ip_vs_sync_conn_options *opt;
struct ip_vs_conn *cp;
+ struct ip_vs_protocol *pp;
char *p;
int i;
@@ -337,7 +337,8 @@ static void ip_vs_process_message(const
p += SIMPLE_CONN_SIZE;
atomic_set(&cp->in_pkts, sysctl_ip_vs_sync_threshold[0]);
- cp->timeout = IP_VS_SYNC_CONN_TIMEOUT;
+ pp = ip_vs_proto_get(s->protocol);
+ cp->timeout = pp->timeout_table[cp->state];
ip_vs_conn_put(cp);
if (p > buffer+buflen) {
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [rfc][patch] ipvs: use proper timeout instead of fixed value
On Sun, May 07, 2006 at 11:13:33PM -0400, Andy Gospodarek wrote: > On Sun, May 07, 2006 at 01:38:40PM +0900, Horms wrote: > > On Fri, May 05, 2006 at 02:57:26PM -0400, Andy Gospodarek wrote: > > > On Fri, May 05, 2006 at 12:20:54PM +0900, Horms wrote: > > > > > > > > Sorry, I missunderstood your patch completely the first time around. > > > > Yes I think this is an excellent idea. Assuming its tested and works > > > > I'm happy to sign off on it and prod DaveM. > > > > > > Horms, > > > > > > I'll get a setup together and post results when I have them. > > > > I was thinking that it would be nice if the timeout could be sent over > > the wire, though that might bring in some compatibility issues, > > and thus your approach might be the best idea. > > > > -- > > Horms > > http://www.vergenet.net/~horms/ > > > Horms, > > At first I too thought about including the timeout in the messages would > be nice, but it could raise compatibility issues with maybe the only > advantage being that it would allow quicker timeout of connections -- > something that might be undesirable in such an LVS environment. Yes, I agree. Wensong raised the issue of having many many connections on the backup, I personally think thats its unlikely that would be a problem in practice, though making it tunable might be nice in any case. -- Horms http://www.vergenet.net/~horms/ - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [rfc][patch] ipvs: use proper timeout instead of fixed value
On Sun, May 07, 2006 at 11:32:00PM +0800, Wensong Zhang wrote:
>
> Hi Andy,
>
> Yes, the original sychronziation design is a sort of arbitary or
> compromised solution. We don't want to synchronize every state change from
> master to backup load balancer, because we were afraid that there were too
> much state change synchronization messages and there would be some
> performance penalty. So, we only sychronize the connection of TCP
> ESTABLISHED state or UDP to backup load balancer, and use the timeout of 3
> minutes.
>
> Your change is probably ok, but we should be aware that it may create a
> lot of connection entries at backup load balancer for TCP applications,
> which is much more than that at master load balancer, because there is no
> connection close synchronization and timeout is changed to 3 minutes to 15
> minutes.
Wensong,
This is an interesting point. Do you feel it would be reasonable to
synchronize states for extablished connections and terminating
connections rather than all state changes? It would seem keeping the
table at a minimum size would be desireable without tracking every state
change since that could create too much noice between master and backup
-- especially for short-lived connections.
I could work some more to expand and test this patch to include more
detailed connection tracking if you (or anyone else) feel it would be
valuable.
-andy
>
> The simple solution is probably to make timeout value tuneable, so that
> users can tune it for their application. The better solution is to
> synchronize very connection state change from master to backup, so that
> backup have almost the same state of connections.
>
> Thanks,
>
> Wensong
>
>
> On Thu, 4 May 2006, Andy Gospodarek wrote:
>
> >
> >Instead of using the default timeout of 3 minutes, this uses the timeout
> >specific to the protocol used for the connection. The 3 minute timeout
> >seems somewhat arbitrary (though I know it is used other places in the
> >ipvs code) and when failing over it would be much nicer to use one of
> >the configured timeout values.
> >
> >Signed-off-by: Andy Gospodarek <[EMAIL PROTECTED]>
> >---
> >
> >ip_vs_sync.c |5 +++--
> >1 files changed, 3 insertions(+), 2 deletions(-)
> >
> >diff --git a/net/ipv4/ipvs/ip_vs_sync.c b/net/ipv4/ipvs/ip_vs_sync.c
> >--- a/net/ipv4/ipvs/ip_vs_sync.c
> >+++ b/net/ipv4/ipvs/ip_vs_sync.c
> >@@ -67,7 +67,6 @@ struct ip_vs_sync_conn_options {
> > struct ip_vs_seqout_seq;/* outgoing seq. struct */
> >};
> >
> >-#define IP_VS_SYNC_CONN_TIMEOUT (3*60*HZ)
> >#define SIMPLE_CONN_SIZE (sizeof(struct ip_vs_sync_conn))
> >#define FULL_CONN_SIZE \
> >(sizeof(struct ip_vs_sync_conn) + sizeof(struct ip_vs_sync_conn_options))
> >@@ -279,6 +278,7 @@ static void ip_vs_process_message(const
> > struct ip_vs_sync_conn *s;
> > struct ip_vs_sync_conn_options *opt;
> > struct ip_vs_conn *cp;
> >+struct ip_vs_protocol *pp;
> > char *p;
> > int i;
> >
> >@@ -337,7 +337,8 @@ static void ip_vs_process_message(const
> > p += SIMPLE_CONN_SIZE;
> >
> > atomic_set(&cp->in_pkts, sysctl_ip_vs_sync_threshold[0]);
> >-cp->timeout = IP_VS_SYNC_CONN_TIMEOUT;
> >+pp = ip_vs_proto_get(s->protocol);
> >+cp->timeout = pp->timeout_table[cp->state];
> > ip_vs_conn_put(cp);
> >
> > if (p > buffer+buflen) {
> >
> -
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to [EMAIL PROTECTED]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [rfc][patch] ipvs: use proper timeout instead of fixed value
On Sun, May 07, 2006 at 01:38:40PM +0900, Horms wrote: > On Fri, May 05, 2006 at 02:57:26PM -0400, Andy Gospodarek wrote: > > On Fri, May 05, 2006 at 12:20:54PM +0900, Horms wrote: > > > > > > Sorry, I missunderstood your patch completely the first time around. > > > Yes I think this is an excellent idea. Assuming its tested and works > > > I'm happy to sign off on it and prod DaveM. > > > > Horms, > > > > I'll get a setup together and post results when I have them. > > I was thinking that it would be nice if the timeout could be sent over > the wire, though that might bring in some compatibility issues, > and thus your approach might be the best idea. > > -- > Horms > http://www.vergenet.net/~horms/ Horms, At first I too thought about including the timeout in the messages would be nice, but it could raise compatibility issues with maybe the only advantage being that it would allow quicker timeout of connections -- something that might be undesirable in such an LVS environment. -andy - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [rfc][patch] ipvs: use proper timeout instead of fixed value
Hi Andy,
Yes, the original sychronziation design is a sort of arbitary or
compromised solution. We don't want to synchronize every state change from
master to backup load balancer, because we were afraid that there were too
much state change synchronization messages and there would be some
performance penalty. So, we only sychronize the connection of TCP
ESTABLISHED state or UDP to backup load balancer, and use the timeout of 3
minutes.
Your change is probably ok, but we should be aware that it may create a
lot of connection entries at backup load balancer for TCP applications,
which is much more than that at master load balancer, because there is no
connection close synchronization and timeout is changed to 3 minutes to 15
minutes.
The simple solution is probably to make timeout value tuneable, so that
users can tune it for their application. The better solution is to
synchronize very connection state change from master to backup, so that
backup have almost the same state of connections.
Thanks,
Wensong
On Thu, 4 May 2006, Andy Gospodarek wrote:
Instead of using the default timeout of 3 minutes, this uses the timeout
specific to the protocol used for the connection. The 3 minute timeout
seems somewhat arbitrary (though I know it is used other places in the
ipvs code) and when failing over it would be much nicer to use one of
the configured timeout values.
Signed-off-by: Andy Gospodarek <[EMAIL PROTECTED]>
---
ip_vs_sync.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/net/ipv4/ipvs/ip_vs_sync.c b/net/ipv4/ipvs/ip_vs_sync.c
--- a/net/ipv4/ipvs/ip_vs_sync.c
+++ b/net/ipv4/ipvs/ip_vs_sync.c
@@ -67,7 +67,6 @@ struct ip_vs_sync_conn_options {
struct ip_vs_seqout_seq;/* outgoing seq. struct */
};
-#define IP_VS_SYNC_CONN_TIMEOUT (3*60*HZ)
#define SIMPLE_CONN_SIZE (sizeof(struct ip_vs_sync_conn))
#define FULL_CONN_SIZE \
(sizeof(struct ip_vs_sync_conn) + sizeof(struct ip_vs_sync_conn_options))
@@ -279,6 +278,7 @@ static void ip_vs_process_message(const
struct ip_vs_sync_conn *s;
struct ip_vs_sync_conn_options *opt;
struct ip_vs_conn *cp;
+ struct ip_vs_protocol *pp;
char *p;
int i;
@@ -337,7 +337,8 @@ static void ip_vs_process_message(const
p += SIMPLE_CONN_SIZE;
atomic_set(&cp->in_pkts, sysctl_ip_vs_sync_threshold[0]);
- cp->timeout = IP_VS_SYNC_CONN_TIMEOUT;
+ pp = ip_vs_proto_get(s->protocol);
+ cp->timeout = pp->timeout_table[cp->state];
ip_vs_conn_put(cp);
if (p > buffer+buflen) {
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [rfc][patch] ipvs: use proper timeout instead of fixed value
On Fri, May 05, 2006 at 02:57:26PM -0400, Andy Gospodarek wrote: > On Fri, May 05, 2006 at 12:20:54PM +0900, Horms wrote: > > > > Sorry, I missunderstood your patch completely the first time around. > > Yes I think this is an excellent idea. Assuming its tested and works > > I'm happy to sign off on it and prod DaveM. > > Horms, > > I'll get a setup together and post results when I have them. I was thinking that it would be nice if the timeout could be sent over the wire, though that might bring in some compatibility issues, and thus your approach might be the best idea. -- Horms http://www.vergenet.net/~horms/ - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [rfc][patch] ipvs: use proper timeout instead of fixed value
On Fri, May 05, 2006 at 12:20:54PM +0900, Horms wrote: > > Sorry, I missunderstood your patch completely the first time around. > Yes I think this is an excellent idea. Assuming its tested and works > I'm happy to sign off on it and prod DaveM. Horms, I'll get a setup together and post results when I have them. -andy - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [rfc][patch] ipvs: use proper timeout instead of fixed value
On Thu, May 04, 2006 at 10:51:11PM -0400, Andy Gospodarek wrote: > On Fri, May 05, 2006 at 09:47:56AM +0900, Horms wrote: > > On Thu, May 04, 2006 at 04:11:16PM -0400, Andy Gospodarek wrote: > > > > > > Instead of using the default timeout of 3 minutes, this uses the timeout > > > specific to the protocol used for the connection. The 3 minute timeout > > > seems somewhat arbitrary (though I know it is used other places in the > > > ipvs code) and when failing over it would be much nicer to use one of > > > the configured timeout values. > > > > Hi Andy, > > > > I agree that the current value is somewhat arbitary, > > however I'm more in favour of setting it idependantly > > of other timeouts, perhaps via proc. In any case, > > won't pp->timeout_table[cp->state] be rather long in > > the ESTABLISHED case? > > > > Horms, > > I agree that there could be a long timeout for ESTABLISHED connections, > but I've run across a situation where I need exactly that. When testing > failover from master to backup I realize that all of my interactive > sessions get dropped much sooner than the timeout I've configured (mine > is currently set for much longer than 3 minutes). If I wanted > established connections to timeout quickly I would set the timeout to be > a small value. Sorry, I missunderstood your patch completely the first time around. Yes I think this is an excellent idea. Assuming its tested and works I'm happy to sign off on it and prod DaveM. -- Horms http://www.vergenet.net/~horms/ - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [rfc][patch] ipvs: use proper timeout instead of fixed value
On Fri, May 05, 2006 at 09:47:56AM +0900, Horms wrote:
> On Thu, May 04, 2006 at 04:11:16PM -0400, Andy Gospodarek wrote:
> >
> > Instead of using the default timeout of 3 minutes, this uses the timeout
> > specific to the protocol used for the connection. The 3 minute timeout
> > seems somewhat arbitrary (though I know it is used other places in the
> > ipvs code) and when failing over it would be much nicer to use one of
> > the configured timeout values.
>
> Hi Andy,
>
> I agree that the current value is somewhat arbitary,
> however I'm more in favour of setting it idependantly
> of other timeouts, perhaps via proc. In any case,
> won't pp->timeout_table[cp->state] be rather long in
> the ESTABLISHED case?
>
Horms,
I agree that there could be a long timeout for ESTABLISHED connections,
but I've run across a situation where I need exactly that. When testing
failover from master to backup I realize that all of my interactive
sessions get dropped much sooner than the timeout I've configured (mine
is currently set for much longer than 3 minutes). If I wanted
established connections to timeout quickly I would set the timeout to be
a small value.
-andy
> > Signed-off-by: Andy Gospodarek <[EMAIL PROTECTED]>
> > ---
> >
> > ip_vs_sync.c |5 +++--
> > 1 files changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/net/ipv4/ipvs/ip_vs_sync.c b/net/ipv4/ipvs/ip_vs_sync.c
> > --- a/net/ipv4/ipvs/ip_vs_sync.c
> > +++ b/net/ipv4/ipvs/ip_vs_sync.c
> > @@ -67,7 +67,6 @@ struct ip_vs_sync_conn_options {
> > struct ip_vs_seqout_seq;/* outgoing seq. struct */
> > };
> >
> > -#define IP_VS_SYNC_CONN_TIMEOUT (3*60*HZ)
> > #define SIMPLE_CONN_SIZE (sizeof(struct ip_vs_sync_conn))
> > #define FULL_CONN_SIZE \
> > (sizeof(struct ip_vs_sync_conn) + sizeof(struct ip_vs_sync_conn_options))
> > @@ -279,6 +278,7 @@ static void ip_vs_process_message(const
> > struct ip_vs_sync_conn *s;
> > struct ip_vs_sync_conn_options *opt;
> > struct ip_vs_conn *cp;
> > + struct ip_vs_protocol *pp;
> > char *p;
> > int i;
> >
> > @@ -337,7 +337,8 @@ static void ip_vs_process_message(const
> > p += SIMPLE_CONN_SIZE;
> >
> > atomic_set(&cp->in_pkts, sysctl_ip_vs_sync_threshold[0]);
> > - cp->timeout = IP_VS_SYNC_CONN_TIMEOUT;
> > + pp = ip_vs_proto_get(s->protocol);
> > + cp->timeout = pp->timeout_table[cp->state];
> > ip_vs_conn_put(cp);
> >
> > if (p > buffer+buflen) {
>
> --
> Horms
> http://www.vergenet.net/~horms/
>
> -
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to [EMAIL PROTECTED]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [rfc][patch] ipvs: use proper timeout instead of fixed value
On Thu, May 04, 2006 at 04:11:16PM -0400, Andy Gospodarek wrote:
>
> Instead of using the default timeout of 3 minutes, this uses the timeout
> specific to the protocol used for the connection. The 3 minute timeout
> seems somewhat arbitrary (though I know it is used other places in the
> ipvs code) and when failing over it would be much nicer to use one of
> the configured timeout values.
Hi Andy,
I agree that the current value is somewhat arbitary,
however I'm more in favour of setting it idependantly
of other timeouts, perhaps via proc. In any case,
won't pp->timeout_table[cp->state] be rather long in
the ESTABLISHED case?
> Signed-off-by: Andy Gospodarek <[EMAIL PROTECTED]>
> ---
>
> ip_vs_sync.c |5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/net/ipv4/ipvs/ip_vs_sync.c b/net/ipv4/ipvs/ip_vs_sync.c
> --- a/net/ipv4/ipvs/ip_vs_sync.c
> +++ b/net/ipv4/ipvs/ip_vs_sync.c
> @@ -67,7 +67,6 @@ struct ip_vs_sync_conn_options {
> struct ip_vs_seqout_seq;/* outgoing seq. struct */
> };
>
> -#define IP_VS_SYNC_CONN_TIMEOUT (3*60*HZ)
> #define SIMPLE_CONN_SIZE (sizeof(struct ip_vs_sync_conn))
> #define FULL_CONN_SIZE \
> (sizeof(struct ip_vs_sync_conn) + sizeof(struct ip_vs_sync_conn_options))
> @@ -279,6 +278,7 @@ static void ip_vs_process_message(const
> struct ip_vs_sync_conn *s;
> struct ip_vs_sync_conn_options *opt;
> struct ip_vs_conn *cp;
> + struct ip_vs_protocol *pp;
> char *p;
> int i;
>
> @@ -337,7 +337,8 @@ static void ip_vs_process_message(const
> p += SIMPLE_CONN_SIZE;
>
> atomic_set(&cp->in_pkts, sysctl_ip_vs_sync_threshold[0]);
> - cp->timeout = IP_VS_SYNC_CONN_TIMEOUT;
> + pp = ip_vs_proto_get(s->protocol);
> + cp->timeout = pp->timeout_table[cp->state];
> ip_vs_conn_put(cp);
>
> if (p > buffer+buflen) {
--
Horms http://www.vergenet.net/~horms/
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
[rfc][patch] ipvs: use proper timeout instead of fixed value
Instead of using the default timeout of 3 minutes, this uses the timeout
specific to the protocol used for the connection. The 3 minute timeout
seems somewhat arbitrary (though I know it is used other places in the
ipvs code) and when failing over it would be much nicer to use one of
the configured timeout values.
Signed-off-by: Andy Gospodarek <[EMAIL PROTECTED]>
---
ip_vs_sync.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/net/ipv4/ipvs/ip_vs_sync.c b/net/ipv4/ipvs/ip_vs_sync.c
--- a/net/ipv4/ipvs/ip_vs_sync.c
+++ b/net/ipv4/ipvs/ip_vs_sync.c
@@ -67,7 +67,6 @@ struct ip_vs_sync_conn_options {
struct ip_vs_seqout_seq;/* outgoing seq. struct */
};
-#define IP_VS_SYNC_CONN_TIMEOUT (3*60*HZ)
#define SIMPLE_CONN_SIZE (sizeof(struct ip_vs_sync_conn))
#define FULL_CONN_SIZE \
(sizeof(struct ip_vs_sync_conn) + sizeof(struct ip_vs_sync_conn_options))
@@ -279,6 +278,7 @@ static void ip_vs_process_message(const
struct ip_vs_sync_conn *s;
struct ip_vs_sync_conn_options *opt;
struct ip_vs_conn *cp;
+ struct ip_vs_protocol *pp;
char *p;
int i;
@@ -337,7 +337,8 @@ static void ip_vs_process_message(const
p += SIMPLE_CONN_SIZE;
atomic_set(&cp->in_pkts, sysctl_ip_vs_sync_threshold[0]);
- cp->timeout = IP_VS_SYNC_CONN_TIMEOUT;
+ pp = ip_vs_proto_get(s->protocol);
+ cp->timeout = pp->timeout_table[cp->state];
ip_vs_conn_put(cp);
if (p > buffer+buflen) {
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
