Re: [PATCH] forcedeth: move config to gigabit menu

[Manfred Spraul]

Eric W. Biederman wrote:


There are also things to cause doubt.  It looks like Manfred Spraul
has contributed about as many patches as Ayaz Abdulla.

 

That's misleading: I did most of the initial work, in the last months 
Ayaz wrote virtually all improvements.


--
   Manfred
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] forcedeth: move config to gigabit menu

[Eric W. Biederman]

Jeff Garzik <[EMAIL PROTECTED]> writes:

> Eric W. Biederman wrote:
>> There is no maintainer contact in the driver nor in the maintainers file.
>
>> It has clearly been bug fixed but simply didn't look like there
>> was a maintainer.
>
> Then you clearly did not look at all.  Simply running the command
>
>   git-whatchanged drivers/net/forcedeth.c
>
> would have shown you that NV has contributed gigabit support, s/g, TSO,
> checksumming, jumbo frame support, 64-bit support and irq mitigation support 
> in
> the recent past.  'less drivers/net/forcedeth.c' shows much the same thing, 
> but
> without attribution.

There are also things to cause doubt.  It looks like Manfred Spraul
has contributed about as many patches as Ayaz Abdulla.

The driver still contains weird things like:
NvRegUnknownSetupReg6 = 0x008,
#define NVREG_UNKSETUP6_VAL 3
NvRegUnknownSetupReg1 = 0xA0,
#define NVREG_UNKSETUP1_VAL 0x16070f
NvRegUnknownSetupReg2 = 0xA4,
NvRegUnknownSetupReg5 = 0x130,
#define NVREG_UNKSETUP5_BIT31   (1<<31)
NvRegUnknownSetupReg3 = 0x13c,
#define NVREG_UNKSETUP3_VAL10x200010
NvRegTxRxControl = 0x144,
NvRegUnknownSetupReg4 = 0x184,
#define NVREG_UNKSETUP4_VAL 8

The driver has no mention of features like the hardware firewall
that is supposed to be a part of this NIC, not even to the point of
ensuring features like that are turned off.

>> Which bugzilla?  They seem to be very popular and everyone seems to
>> have their own.
>
> bugzilla.kernel.org, the official one.  The one that forwards bugs to LKML and
> related lists.  The one that Andrew Morton always points to.
>
> Come on, Eric, you are far more clueful than this.

Barely.  Each subset of the kernel community does things a little
differently, and the basic assumptions vary.  In any group I'm not in
there day to day working with I find what they assume and what I
assume are not always the same.  So I asked.  Probably badly because
of my frustration.

I'm actually overjoyed to find that it looks like nvidia has some
element of on-going maintenance of their driver and it wasn't just a
one or two time code drop.  

Hopefully that will even make it easier to track this near show
stopper problem we are seeing.

Eric
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] forcedeth: move config to gigabit menu

[Jeff Garzik]

Eric W. Biederman wrote:

There is no maintainer contact in the driver nor in the maintainers file.



It has clearly been bug fixed but simply didn't look like there
was a maintainer.


Then you clearly did not look at all.  Simply running the command

git-whatchanged drivers/net/forcedeth.c

would have shown you that NV has contributed gigabit support, s/g, TSO, 
checksumming, jumbo frame support, 64-bit support and irq mitigation 
support in the recent past.  'less drivers/net/forcedeth.c' shows much 
the same thing, but without attribution.




Which bugzilla?  They seem to be very popular and everyone seems to
have their own.


bugzilla.kernel.org, the official one.  The one that forwards bugs to 
LKML and related lists.  The one that Andrew Morton always points to.


Come on, Eric, you are far more clueful than this.

Jeff


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] forcedeth: move config to gigabit menu

[Eric W. Biederman]

"Ayaz Abdulla" <[EMAIL PROTECTED]> writes:

> Its hard for me to believe that you would think that there is no
> indication of the driver being actively supported. Take a look at the
> revision history in the forcedeth.c file. There have been 18 revisions
> in less then a year timeframe.

There is no maintainer contact in the driver nor in the maintainers file.

The driver is still performing black magic with black magic defines,
and still looks noticeably reveres engineered.

It has clearly been bug fixed but simply didn't look like there
was a maintainer.

The feeling I get is that of a skunkworks project rather than
something nvidia is really behind.  Not that even that level
of support isn't appreciated.

> Please file a bug in bugzilla, thats the intended use of that system.

Which bugzilla?  They seem to be very popular and everyone seems to
have their own.

Usually bugzilla is a lousy mechanism to communicate problems if you
can get developer to developer communication.  Especially when one
of the developer can reproduce the problem.  I can set it being useful 
to record the problem so it doesn't get forgotten. 

If I could get documentation you would simply get a patch that
fixes it.

I don't mean to be hostile but I am very frustrated.

Eric
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH] forcedeth: move config to gigabit menu

[Ayaz Abdulla]

Its hard for me to believe that you would think that there is no
indication of the driver being actively supported. Take a look at the
revision history in the forcedeth.c file. There have been 18 revisions
in less then a year timeframe.

Please file a bug in bugzilla, thats the intended use of that system.

-Original Message-
From: Eric W. Biederman [mailto:[EMAIL PROTECTED] 
Sent: Thursday, March 16, 2006 12:51 PM
To: Ayaz Abdulla
Cc: netdev@vger.kernel.org; Natalie Protasevich; Lew Glendenning; kevin
vanmaren
Subject: Re: [PATCH] forcedeth: move config to gigabit menu


"Ayaz Abdulla" <[EMAIL PROTECTED]> writes:

> What is the bugzilla bug number for that issue?

I don't think there is a bugzilla number as there was no indication
that the driver was actively supported, in which case the practical
solution is generally to dig in and fix a problem rather than whine
about it in bugzilla.

Natalie Protasevich has more details, as she has been actively working
on investigating and fixing this problem.  But the here is a summary to
start with. Using the supermicro h8dce motherboard with the ck804
chipset.  We frequently encounter an issue where when booting a
cluster 1/2 to 1/3 of the nodes don't receive packets, using the
forcedeth driver in 2.6.15.

Interrupts are received, but never an rx interrupt.

It takes cycling the power on the machine for things to start working.

With a couple of tweaks Natalie has gotten the failure rate down
to 1 node in 16 but that is still horribly bad.

> I will work on clearing up some of those names.

Thanks.


> -Original Message-
> From: Eric W. Biederman [mailto:[EMAIL PROTECTED] 
> Sent: Thursday, March 16, 2006 9:58 AM
> To: Ayaz Abdulla
> Cc: Stephen Hemminger; "Manfred Spraul <[EMAIL PROTECTED], Jeff
> Garzik <[EMAIL PROTECTED]>"@osdl.org; netdev@vger.kernel.org
> Subject: Re: [PATCH] forcedeth: move config to gigabit menu
>
>
> "Ayaz Abdulla" <[EMAIL PROTECTED]> writes:
>
>> Can we remove "Reverse Engineered" and "(EXPERIMENTAL)" now?
>
> Can we get better bit names in the driver?
> Having unknown xyz in half of the names is scare?
> Can we have some help fixing the problem where the on some boots
> the driver cannot receive packets?
>
> Or perhaps can Nvidia just document their nic some of
> the rest of us can fix the driver?
>
> So far this is not a solid driver.
>
> Eric


Eric
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] forcedeth: move config to gigabit menu

[Eric W. Biederman]

"Ayaz Abdulla" <[EMAIL PROTECTED]> writes:

> What is the bugzilla bug number for that issue?

I don't think there is a bugzilla number as there was no indication
that the driver was actively supported, in which case the practical
solution is generally to dig in and fix a problem rather than whine
about it in bugzilla.

Natalie Protasevich has more details, as she has been actively working
on investigating and fixing this problem.  But the here is a summary to
start with. Using the supermicro h8dce motherboard with the ck804
chipset.  We frequently encounter an issue where when booting a
cluster 1/2 to 1/3 of the nodes don't receive packets, using the
forcedeth driver in 2.6.15.

Interrupts are received, but never an rx interrupt.

It takes cycling the power on the machine for things to start working.

With a couple of tweaks Natalie has gotten the failure rate down
to 1 node in 16 but that is still horribly bad.

> I will work on clearing up some of those names.

Thanks.


> -Original Message-
> From: Eric W. Biederman [mailto:[EMAIL PROTECTED] 
> Sent: Thursday, March 16, 2006 9:58 AM
> To: Ayaz Abdulla
> Cc: Stephen Hemminger; "Manfred Spraul <[EMAIL PROTECTED], Jeff
> Garzik <[EMAIL PROTECTED]>"@osdl.org; netdev@vger.kernel.org
> Subject: Re: [PATCH] forcedeth: move config to gigabit menu
>
>
> "Ayaz Abdulla" <[EMAIL PROTECTED]> writes:
>
>> Can we remove "Reverse Engineered" and "(EXPERIMENTAL)" now?
>
> Can we get better bit names in the driver?
> Having unknown xyz in half of the names is scare?
> Can we have some help fixing the problem where the on some boots
> the driver cannot receive packets?
>
> Or perhaps can Nvidia just document their nic some of
> the rest of us can fix the driver?
>
> So far this is not a solid driver.
>
> Eric


Eric
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH] forcedeth: move config to gigabit menu

[Ayaz Abdulla]

What is the bugzilla bug number for that issue?

I will work on clearing up some of those names.

-Original Message-
From: Eric W. Biederman [mailto:[EMAIL PROTECTED] 
Sent: Thursday, March 16, 2006 9:58 AM
To: Ayaz Abdulla
Cc: Stephen Hemminger; "Manfred Spraul <[EMAIL PROTECTED], Jeff
Garzik <[EMAIL PROTECTED]>"@osdl.org; netdev@vger.kernel.org
Subject: Re: [PATCH] forcedeth: move config to gigabit menu


"Ayaz Abdulla" <[EMAIL PROTECTED]> writes:

> Can we remove "Reverse Engineered" and "(EXPERIMENTAL)" now?

Can we get better bit names in the driver?
Having unknown xyz in half of the names is scare?
Can we have some help fixing the problem where the on some boots
the driver cannot receive packets?

Or perhaps can Nvidia just document their nic some of
the rest of us can fix the driver?

So far this is not a solid driver.

Eric
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] forcedeth: move config to gigabit menu

[Eric W. Biederman]

"Ayaz Abdulla" <[EMAIL PROTECTED]> writes:

> Can we remove "Reverse Engineered" and "(EXPERIMENTAL)" now?

Can we get better bit names in the driver?
Having unknown xyz in half of the names is scare?
Can we have some help fixing the problem where the on some boots
the driver cannot receive packets?

Or perhaps can Nvidia just document their nic some of
the rest of us can fix the driver?

So far this is not a solid driver.

Eric
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH] forcedeth: move config to gigabit menu

[Ayaz Abdulla]

Can we remove "Reverse Engineered" and "(EXPERIMENTAL)" now?

Thanks,
Ayaz


-Original Message-
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]
On Behalf Of Stephen Hemminger
Sent: Tuesday, March 14, 2006 10:50 AM
To: "Manfred Spraul <[EMAIL PROTECTED], Jeff Garzik
<[EMAIL PROTECTED]>"@osdl.org
Cc: netdev@vger.kernel.org
Subject: [PATCH] forcedeth: move config to gigabit menu


Since the nforce ether ethernet driver supports gigabit, it should be
moved down in the Kconfig file to show up in the 1000Mbit submenu.

Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>


--- test-2.6/drivers/net/Kconfig.orig   2006-03-14 10:45:13.0
-0800
+++ test-2.6/drivers/net/Kconfig2006-03-14 10:46:31.0
-0800
@@ -1371,19 +1371,6 @@
  .  The module
will be
  called b44.
 
-config FORCEDETH
-   tristate "Reverse Engineered nForce Ethernet support
(EXPERIMENTAL)"
-   depends on NET_PCI && PCI && EXPERIMENTAL
-   help
- If you have a network (Ethernet) controller of this type, say
Y and
- read the Ethernet-HOWTO, available from
- .
-
- To compile this driver as a module, choose M here and read
- .  The module
will be
- called forcedeth.
-
-
 config CS89x0
tristate "CS89x0 support"
depends on NET_PCI && (ISA || MACH_IXDP2351 || ARCH_IXDP2X01 ||
ARCH_PNX010X)
@@ -2221,6 +2208,19 @@
  This enables support for Port 2 of the Marvell MV643XX Gigabit
  Ethernet.
 
+config FORCEDETH
+   tristate "Reverse Engineered nForce Ethernet support
(EXPERIMENTAL)"
+   depends on NET_PCI && PCI && EXPERIMENTAL
+   help
+ If you have a network (Ethernet) controller of this type, say
Y and
+ read the Ethernet-HOWTO, available from
+ .
+
+ To compile this driver as a module, choose M here and read
+ .  The module
will be
+ called forcedeth.
+
+
 endmenu
 
 #
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html