Re: [PATCH] qmi_wwan: Added support for Gemalto's Cinterion PHxx WWAN interface

2016-03-20 Thread Bjørn Mork 
Schemmel Hans-Christoph  writes:

> Added support for Gemalto's Cinterion PHxx WWAN interfaces 
> by adding QMI_FIXED_INTF with Cinterion's VID and PID.
>
> PHxx can have:
> 2 RmNet Interfaces (PID 0x0082) or
> 1 RmNet + 1 USB Audio interface (PID 0x0083).
>
> Signed-off-by: Hans-Christoph Schemmel 
> ---
> patch is against linux-4.5
> --- linux/drivers/net/usb/qmi_wwan.c.orig 2016-03-14 12:18:07.153497489 
> +0100
> +++ linux/drivers/net/usb/qmi_wwan.c  2016-03-14 12:21:37.722541644 +0100
> @@ -881,6 +881,9 @@ static const struct usb_device_id produc
>   {QMI_FIXED_INTF(0x0b3c, 0xc00b, 4)},/* Olivetti Olicard 500 */
>   {QMI_FIXED_INTF(0x1e2d, 0x0060, 4)},/* Cinterion PLxx */
>   {QMI_FIXED_INTF(0x1e2d, 0x0053, 4)},/* Cinterion PHxx,PXxx */
> + {QMI_FIXED_INTF(0x1e2d, 0x0082, 4)},/* Cinterion PHxx,PXxx (2 
> RmNet) */
> + {QMI_FIXED_INTF(0x1e2d, 0x0082, 5)},/* Cinterion PHxx,PXxx (2 
> RmNet) */
> + {QMI_FIXED_INTF(0x1e2d, 0x0083, 4)},/* Cinterion PHxx,PXxx (1 RmNet 
> + USB Audio)*/
>   {QMI_FIXED_INTF(0x413c, 0x81a2, 8)},/* Dell Wireless 5806 Gobi(TM) 
> 4G LTE Mobile Broadband Card */
>   {QMI_FIXED_INTF(0x413c, 0x81a3, 8)},/* Dell Wireless 5570 HSPA+ 
> (42Mbps) Mobile Broadband Card */
>   {QMI_FIXED_INTF(0x413c, 0x81a4, 8)},/* Dell Wireless 5570e HSPA+ 
> (42Mbps) Mobile Broadband Card */

Perfect.  Thanks.

Acked-by: Bjørn Mork

Re: [PATCH] qmi_wwan: Added support for Gemalto's Cinterion PHxx WWAN interface

2016-03-19 Thread David Miller 
From: Schemmel Hans-Christoph 
Date: Thu, 17 Mar 2016 10:07:56 +

> Added support for Gemalto's Cinterion PHxx WWAN interfaces 
> by adding QMI_FIXED_INTF with Cinterion's VID and PID.
> 
> PHxx can have:
> 2 RmNet Interfaces (PID 0x0082) or
> 1 RmNet + 1 USB Audio interface (PID 0x0083).
> 
> Signed-off-by: Hans-Christoph Schemmel 

Applied, thanks.

Re: [PATCH] qmi_wwan: Added support for Gemalto's Cinterion PHxx WWAN interface

2016-03-16 Thread Bjørn Mork 
Schemmel Hans-Christoph  writes:

> + {QMI_FIXED_INTF(0x1e2d, 0x0082, 4)},/* Cinterion PHxx,PXxx (2
> RmNet) */

That's broken.  Sorry.  You'll have to figure out some way submit this
in a form that can be applied using "git am".

There are some hints in
https://www.kernel.org/doc/Documentation/email-clients.txt



Bjørn

RE: [PATCH] qmi_wwan: Added support for Gemalto's Cinterion PHxx WWAN interface

2016-03-16 Thread Bjørn Mork 


On March 16, 2016 8:35:26 AM CET, Schemmel Hans-Christoph 
 :
>
>If I digital sign the mail it should be send unmodified/without
>disclaimer.
>But there will be the smime.p7s attached to the mail - like in this
>mail. 
>
>Would it be ok?

Fine with me as long as it applies cleanly without having to consult a lawyer :)

Try it and we'll find out. If it doesn't work then please use a private account 
to submit. You can still set the from and sob to your work email if that is 
important. 


Bjørn

RE: [PATCH] qmi_wwan: Added support for Gemalto's Cinterion PHxx WWAN interface

2016-03-16 Thread Schemmel Hans-Christoph 
> From: David Miller [mailto:da...@davemloft.net]
> Sent: Dienstag, 15. März 2016 22:52
> 
> From: Bjørn Mork 
> Date: Tue, 15 Mar 2016 13:27:03 +0100
> 
> > Schemmel Hans-Christoph 
> writes:
> >
> >>  If you are not the intended recipient of this message, please delete
it and
> notify the sender.
> >
> > OK. Deleted.
> 
> I've also deleted it and therefore won't look at this patch.


Ok, I see. Sorry, the disclaimer is automatically added by companies' mail
server.
If I digital sign the mail it should be send unmodified/without disclaimer.
But there will be the smime.p7s attached to the mail - like in this mail. 

Would it be ok?

Kind regards
Christoph


smime.p7s
Description: S/MIME cryptographic signature

Re: [PATCH] qmi_wwan: Added support for Gemalto's Cinterion PHxx WWAN interface

2016-03-15 Thread David Miller 
From: Bjørn Mork 
Date: Tue, 15 Mar 2016 13:27:03 +0100

> Schemmel Hans-Christoph  writes:
> 
>>  If you are not the intended recipient of this message, please delete it and 
>> notify the sender.
> 
> OK. Deleted.

I've also deleted it and therefore won't look at this patch.

Re: [PATCH] qmi_wwan: Added support for Gemalto's Cinterion PHxx WWAN interface

2016-03-15 Thread Bjørn Mork 
Schemmel Hans-Christoph  writes:

>  If you are not the intended recipient of this message, please delete it and 
> notify the sender.

OK. Deleted.


Bjørn