Re: [PATCH iproute2 v2 1/3] ifstat: Add extended statistics to ifstat
On Thu, Dec 15, 2016 at 3:00 PM, Nogah Frankel wrote: > +/* Note: if one xstat name in subset of another, it should be before it in > this > + * list. > + * Name length must be under 64 chars. > + */ nit "in subset" --> "is subset" ?
RE: [PATCH iproute2 v2 1/3] ifstat: Add extended statistics to ifstat
> -Original Message- > From: Rami Rosen [mailto:roszenr...@gmail.com] > Sent: Friday, December 16, 2016 5:21 PM > To: Nogah Frankel > Cc: Stephen Hemminger ; netdev@vger.kernel.org; > ro...@cumulusnetworks.com; Jiri Pirko ; Elad Raz > ; Yotam Gigi ; Ido Schimmel > ; Or Gerlitz > Subject: Re: [PATCH iproute2 v2 1/3] ifstat: Add extended statistics to ifstat > > Hi, > > >Thanks, I'll fix it. > Another minor nit, on this occasion: > > bool is_extanded should be: bool is_extended > > Regards, > Rami Rosen Thank you, I will fix it. Nogah
Re: [PATCH iproute2 v2 1/3] ifstat: Add extended statistics to ifstat
Hi, >Thanks, I'll fix it. Another minor nit, on this occasion: bool is_extanded should be: bool is_extended Regards, Rami Rosen
RE: [PATCH iproute2 v2 1/3] ifstat: Add extended statistics to ifstat
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Thursday, December 15, 2016 7:33 PM > To: Nogah Frankel > Cc: netdev@vger.kernel.org; ro...@cumulusnetworks.com; Jiri Pirko > ; Elad Raz ; Yotam Gigi > ; Ido Schimmel ; Or Gerlitz > > Subject: Re: [PATCH iproute2 v2 1/3] ifstat: Add extended statistics to ifstat > > On Thu, 15 Dec 2016 15:00:43 +0200 > Nogah Frankel wrote: > > > Extended stats are part of the RTM_GETSTATS method. This patch adds them > > to ifstat. > > While extended stats can come in many forms, we support only the > > rtnl_link_stats64 struct for them (which is the 64 bits version of struct > > rtnl_link_stats). > > We support stats in the main nesting level, or one lower. > > The extension can be called by its name or any shorten of it. If there is > > more than one matched, the first one will be picked. > > > > To get the extended stats the flag -x is used. > > > > Signed-off-by: Nogah Frankel > > Reviewed-by: Jiri Pirko > > --- > > misc/ifstat.c | 161 > -- > > 1 file changed, 146 insertions(+), 15 deletions(-) > > > > diff --git a/misc/ifstat.c b/misc/ifstat.c > > index 92d67b0..d17ae21 100644 > > --- a/misc/ifstat.c > > +++ b/misc/ifstat.c > > @@ -35,6 +35,7 @@ > > > > #include > > > > +#include "utils.h" > > int dump_zeros; > > int reset_history; > > int ignore_history; > > Minor nit, please cleanup include order here (original code was wrong). > > Standard practice is: > #include system headers (like stdio.h etc) > #include "xxx.h" local headers. > > Should be: > #include > > #include > #include > > #include "json_writer.h" > #include "libnetlink.h" > #include "utils.h" > #include "SNAPSHOT.h" Thanks, I'll fix it.
Re: [PATCH iproute2 v2 1/3] ifstat: Add extended statistics to ifstat
On Thu, 15 Dec 2016 15:00:43 +0200 Nogah Frankel wrote: > Extended stats are part of the RTM_GETSTATS method. This patch adds them > to ifstat. > While extended stats can come in many forms, we support only the > rtnl_link_stats64 struct for them (which is the 64 bits version of struct > rtnl_link_stats). > We support stats in the main nesting level, or one lower. > The extension can be called by its name or any shorten of it. If there is > more than one matched, the first one will be picked. > > To get the extended stats the flag -x is used. > > Signed-off-by: Nogah Frankel > Reviewed-by: Jiri Pirko > --- > misc/ifstat.c | 161 > -- > 1 file changed, 146 insertions(+), 15 deletions(-) > > diff --git a/misc/ifstat.c b/misc/ifstat.c > index 92d67b0..d17ae21 100644 > --- a/misc/ifstat.c > +++ b/misc/ifstat.c > @@ -35,6 +35,7 @@ > > #include > > +#include "utils.h" > int dump_zeros; > int reset_history; > int ignore_history; Minor nit, please cleanup include order here (original code was wrong). Standard practice is: #include system headers (like stdio.h etc) #include "xxx.h" local headers. Should be: #include #include #include #include "json_writer.h" #include "libnetlink.h" #include "utils.h" #include "SNAPSHOT.h"
