RE: [PATCH v1 net-next 9/9] lan743x: Add PTP support
Thanks Richard, I'll add it in my next revision. > -Original Message- > From: Richard Cochran [mailto:richardcoch...@gmail.com] > Sent: Friday, July 6, 2018 5:25 PM > To: Bryan Whitehead - C21958 > Cc: da...@davemloft.net; netdev@vger.kernel.org; UNGLinuxDriver > > Subject: Re: [PATCH v1 net-next 9/9] lan743x: Add PTP support > > On Thu, Jul 05, 2018 at 12:39:26PM -0400, Bryan Whitehead wrote: > > Signed-off-by: Bryan Whitehead > > 1. You forgot the commit message. > 2. You forgot to add the PTP maintainer on CC. > > Thanks, > Richard
Re: [PATCH v1 net-next 9/9] lan743x: Add PTP support
On Thu, Jul 05, 2018 at 12:39:26PM -0400, Bryan Whitehead wrote: > Signed-off-by: Bryan Whitehead 1. You forgot the commit message. 2. You forgot to add the PTP maintainer on CC. Thanks, Richard
Re: [PATCH v1 net-next 9/9] lan743x: Add PTP support
Hi Bryan, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Bryan-Whitehead/lan743x-Add-features-to-lan743x-driver/20180706-051812 config: i386-allmodconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): >> ERROR: "__moddi3" [drivers/net/ethernet/microchip/lan743x.ko] undefined! >> ERROR: "__udivdi3" [drivers/net/ethernet/microchip/lan743x.ko] undefined! >> ERROR: "__umoddi3" [drivers/net/ethernet/microchip/lan743x.ko] undefined! >> ERROR: "__divdi3" [drivers/net/ethernet/microchip/lan743x.ko] undefined! --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip