Re: [PATCH v2] fjes: Do not load fjes driver if system does not have extended socket device.
On 03/12/2017 09:02 PM, Izumi, Taku wrote: Ishimatsu-san, Sorry for my late response. Which tree did you apply the patch to? The patch can apply to net-next tree with no conflicts as follows: Not net-next but net tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git I'll update the patch soon. Thanks, Yasuaki Ishimatsu I'll review and test your patch soon. Sincerely, Taku Izumi # git clone git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git Cloning into 'net-next'... remote: Counting objects: 5265118, done. remote: Compressing objects: 100% (805485/805485), done. Receiving objects: 100% (5265118/5265118), 910.11 MiB | 23.42 MiB/s, done. remote: Total 5265118 (delta 4419240), reused 5264459 (delta 4418809) Resolving deltas: 100% (4419240/4419240), done. Checking out files: 100% (58005/58005), done. # head -n 30 fjes.patch Subject: [PATCH v2] fjes: Do not load fjes driver if system does not have extended socket device. Date: Wed, 8 Mar 2017 16:05:18 -0500 From: Yasuaki IshimatsuTo: netdev@vger.kernel.org CC: David Miller , izumi.t...@jp.fujitsu.com The fjes driver is used only by FUJITSU servers and almost of all servers in the world never use it. But currently if ACPI PNP0C02 is defined in the ACPI table, the following message is always shown: "FUJITSU Extended Socket Network Device Driver - version 1.2 - Copyright (c) 2015 FUJITSU LIMITED" The message makes users confused because there is no reason that the message is shown in other vendor servers. To avoid the confusion, the patch adds a check that the server has a extended socket device or not. Signed-off-by: Yasuaki Ishimatsu CC: Taku Izumi --- v2: - Order local variable declarations from longest to shortest line drivers/net/fjes/fjes_main.c | 52 +++- 1 file changed, 47 insertions(+), 5 deletions(-) diff --git a/drivers/net/fjes/fjes_main.c b/drivers/net/fjes/fjes_main.c index b77e4ecf..a57c2cb 100644 # cd net-next/ # git am ../fjes.patch Applying: fjes: Do not load fjes driver if system does not have extended socket device. # Thanks, Yasuaki Ishimatsu
Re: [PATCH v2] fjes: Do not load fjes driver if system does not have extended socket device.
On 03/12/2017 02:29 PM, Bjørn Mork wrote: Yasuaki Ishimatsuwrites: The fjes driver is used only by FUJITSU servers and almost of all servers in the world never use it. But currently if ACPI PNP0C02 is defined in the ACPI table, the following message is always shown: "FUJITSU Extended Socket Network Device Driver - version 1.2 - Copyright (c) 2015 FUJITSU LIMITED" Matching on PNP0C02 is fundamentally wrong. It's a way to load a device driver on all ACPI systems. You should not do that. I don't think it is fair to make everyone suffer because of your inability to properly narrow down the driver matching rules. There are so many similar matching rules. But these modules are not listed in blacklist because these modules has proper check like my patch and no one suffers. So I don't think the matching rule is fundamentally wrong. Thanks, Yasuaki Ishimatsu Could we please just delete the whole MODULE_DEVICE_TABLE() from this driver until a proper solution is found? That way we don't need to blacklist the driver everywhere. Bjørn
RE: [PATCH v2] fjes: Do not load fjes driver if system does not have extended socket device.
Ishimatsu-san, Sorry for my late response. > > Which tree did you apply the patch to? > > The patch can apply to net-next tree with no conflicts as follows: Not net-next but net tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git I'll review and test your patch soon. Sincerely, Taku Izumi > > # git clone > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git > Cloning into 'net-next'... > remote: Counting objects: 5265118, done. > remote: Compressing objects: 100% (805485/805485), done. > Receiving objects: 100% (5265118/5265118), 910.11 MiB | 23.42 MiB/s, done. > remote: Total 5265118 (delta 4419240), reused 5264459 (delta 4418809) > Resolving deltas: 100% (4419240/4419240), done. > Checking out files: 100% (58005/58005), done. > # head -n 30 fjes.patch > Subject: [PATCH v2] fjes: Do not load fjes driver if system does not have > extended socket device. > Date: Wed, 8 Mar 2017 16:05:18 -0500 > From: Yasuaki Ishimatsu> To: netdev@vger.kernel.org > CC: David Miller , izumi.t...@jp.fujitsu.com > > The fjes driver is used only by FUJITSU servers and almost of all servers > in the world never use it. But currently if ACPI PNP0C02 is defined in the > ACPI table, the following message is always shown: > > "FUJITSU Extended Socket Network Device Driver - version 1.2 >- Copyright (c) 2015 FUJITSU LIMITED" > > The message makes users confused because there is no reason that the message > is shown in other vendor servers. > > To avoid the confusion, the patch adds a check that the server has a extended > socket device or not. > > Signed-off-by: Yasuaki Ishimatsu > CC: Taku Izumi > --- > v2: > - Order local variable declarations from longest to shortest line > > drivers/net/fjes/fjes_main.c | 52 > +++- > 1 file changed, 47 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/fjes/fjes_main.c b/drivers/net/fjes/fjes_main.c > index b77e4ecf..a57c2cb 100644 # cd net-next/ # git am ../fjes.patch > Applying: fjes: Do not load fjes driver if system does not have extended > socket device. > # > > > Thanks, > Yasuaki Ishimatsu
Re: [PATCH v2] fjes: Do not load fjes driver if system does not have extended socket device.
Yasuaki Ishimatsuwrites: > The fjes driver is used only by FUJITSU servers and almost of all > servers in the world never use it. But currently if ACPI PNP0C02 > is defined in the ACPI table, the following message is always shown: > > "FUJITSU Extended Socket Network Device Driver - version 1.2 > - Copyright (c) 2015 FUJITSU LIMITED" Matching on PNP0C02 is fundamentally wrong. It's a way to load a device driver on all ACPI systems. You should not do that. I don't think it is fair to make everyone suffer because of your inability to properly narrow down the driver matching rules. Could we please just delete the whole MODULE_DEVICE_TABLE() from this driver until a proper solution is found? That way we don't need to blacklist the driver everywhere. Bjørn
Re: [PATCH v2] fjes: Do not load fjes driver if system does not have extended socket device.
On 03/09/2017 08:35 PM, David Miller wrote: From: Yasuaki IshimatsuDate: Wed, 8 Mar 2017 16:05:18 -0500 The fjes driver is used only by FUJITSU servers and almost of all servers in the world never use it. But currently if ACPI PNP0C02 is defined in the ACPI table, the following message is always shown: "FUJITSU Extended Socket Network Device Driver - version 1.2 - Copyright (c) 2015 FUJITSU LIMITED" The message makes users confused because there is no reason that the message is shown in other vendor servers. To avoid the confusion, the patch adds a check that the server has a extended socket device or not. Signed-off-by: Yasuaki Ishimatsu CC: Taku Izumi --- v2: - Order local variable declarations from longest to shortest line This patch does not apply cleanly to the net tree. Which tree did you apply the patch to? The patch can apply to net-next tree with no conflicts as follows: # git clone git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git Cloning into 'net-next'... remote: Counting objects: 5265118, done. remote: Compressing objects: 100% (805485/805485), done. Receiving objects: 100% (5265118/5265118), 910.11 MiB | 23.42 MiB/s, done. remote: Total 5265118 (delta 4419240), reused 5264459 (delta 4418809) Resolving deltas: 100% (4419240/4419240), done. Checking out files: 100% (58005/58005), done. # head -n 30 fjes.patch Subject: [PATCH v2] fjes: Do not load fjes driver if system does not have extended socket device. Date: Wed, 8 Mar 2017 16:05:18 -0500 From: Yasuaki Ishimatsu To: netdev@vger.kernel.org CC: David Miller , izumi.t...@jp.fujitsu.com The fjes driver is used only by FUJITSU servers and almost of all servers in the world never use it. But currently if ACPI PNP0C02 is defined in the ACPI table, the following message is always shown: "FUJITSU Extended Socket Network Device Driver - version 1.2 - Copyright (c) 2015 FUJITSU LIMITED" The message makes users confused because there is no reason that the message is shown in other vendor servers. To avoid the confusion, the patch adds a check that the server has a extended socket device or not. Signed-off-by: Yasuaki Ishimatsu CC: Taku Izumi --- v2: - Order local variable declarations from longest to shortest line drivers/net/fjes/fjes_main.c | 52 +++- 1 file changed, 47 insertions(+), 5 deletions(-) diff --git a/drivers/net/fjes/fjes_main.c b/drivers/net/fjes/fjes_main.c index b77e4ecf..a57c2cb 100644 # cd net-next/ # git am ../fjes.patch Applying: fjes: Do not load fjes driver if system does not have extended socket device. # Thanks, Yasuaki Ishimatsu
Re: [PATCH v2] fjes: Do not load fjes driver if system does not have extended socket device.
From: Yasuaki IshimatsuDate: Wed, 8 Mar 2017 16:05:18 -0500 > The fjes driver is used only by FUJITSU servers and almost of all > servers in the world never use it. But currently if ACPI PNP0C02 > is defined in the ACPI table, the following message is always shown: > > "FUJITSU Extended Socket Network Device Driver - version 1.2 > - Copyright (c) 2015 FUJITSU LIMITED" > > The message makes users confused because there is no reason that > the message is shown in other vendor servers. > > To avoid the confusion, the patch adds a check that the server > has a extended socket device or not. > > Signed-off-by: Yasuaki Ishimatsu > CC: Taku Izumi > --- > v2: > - Order local variable declarations from longest to shortest line This patch does not apply cleanly to the net tree.