RE: [RFC 2/3] secid reconciliation on inbound: add LSM hooks

2006-08-02 Thread Venkat Yekkirala 
> > -   if (err)
> > -   goto out;
> > +   /* if (err) */
> > +   /*  goto out; */
> > 
> > -   err = selinux_xfrm_sock_rcv_skb(sksec->sid, skb, &ad);
> > -out:   +   /* err = 
> selinux_xfrm_sock_rcv_skb(sksec->sid, skb, &ad); */
> > +out:   return err;
> > }
> 
> 
> Did you mean to leave the call to selinux_xfrm_sock_rcv_skb() 
> commented 
> out?

I actually meant to take the call out entirely. Will fix this in
the next round.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [RFC 2/3] secid reconciliation on inbound: add LSM hooks

2006-08-01 Thread James Morris 
On Tue, 1 Aug 2006, Venkat Yekkirala wrote:

> - if (err)
> - goto out;
> + /* if (err) */
> + /*  goto out; */
> 
> - err = selinux_xfrm_sock_rcv_skb(sksec->sid, skb, &ad);
> -out: +   /* err = selinux_xfrm_sock_rcv_skb(sksec->sid, skb, &ad); */
> +out: return err;
> }


Did you mean to leave the call to selinux_xfrm_sock_rcv_skb() commented 
out?



- James
-- 
James Morris
<[EMAIL PROTECTED]>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html