Re: Potential u32 classifier bug.
* Waskiewicz Jr, Peter P [EMAIL PROTECTED] 2007-08-09 18:07 My big question is: Has anyone recently used the 802_3 protocol in tc with u32 and actually gotten it to work? I can't see how the u32_classify() code can look at the mac header, since it is using the network header accessor to start looking. I think this is an issue with the classification code, but I'm looking to see if I'm doing something stupid before I really start digging into this mess. There is this very horrible way of using the u32 classifier with a negative offset to look into the ethernet header. You might want to look into the cmp ematch which can be attached to almost any classifier. It allows basing offsets on any layer thus making ethernet header filtering trivial. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: Potential u32 classifier bug.
* Waskiewicz Jr, Peter P [EMAIL PROTECTED] 2007-08-15 11:02 There is this very horrible way of using the u32 classifier with a negative offset to look into the ethernet header. Based on this, it sounds like u32 using protocol 802_3 is broken? You might be expecting too much from u32. The protocol given to u32 is just a filter, it doesn't imply anything beyond that. u32 has its usage the way it is, that's way we've added an ematch rather than extending u32 itself. Ok, that clarifies it a bit. I've just found a few examples on the net, one of which is in a TC filter manual (http://tcn.hypert.net/tcmanual.pdf, section 2.2.1.3 at the bottom of the section), that was using u32 to simply filter on dest MAC address without anything elaborate. Either it worked way back when, or it was a bogus example. Thanks again Thomas, -PJ - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: Potential u32 classifier bug.
* Waskiewicz Jr, Peter P [EMAIL PROTECTED] 2007-08-09 18:07 My big question is: Has anyone recently used the 802_3 protocol in tc with u32 and actually gotten it to work? I can't see how the u32_classify() code can look at the mac header, since it is using the network header accessor to start looking. I think this is an issue with the classification code, but I'm looking to see if I'm doing something stupid before I really start digging into this mess. There is this very horrible way of using the u32 classifier with a negative offset to look into the ethernet header. Based on this, it sounds like u32 using protocol 802_3 is broken? You might want to look into the cmp ematch which can be attached to almost any classifier. It allows basing offsets on any layer thus making ethernet header filtering trivial. I'll look at this. Thanks Thomas for the response! -PJ - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Potential u32 classifier bug.
* Waskiewicz Jr, Peter P [EMAIL PROTECTED] 2007-08-15 11:02 There is this very horrible way of using the u32 classifier with a negative offset to look into the ethernet header. Based on this, it sounds like u32 using protocol 802_3 is broken? You might be expecting too much from u32. The protocol given to u32 is just a filter, it doesn't imply anything beyond that. u32 has its usage the way it is, that's way we've added an ematch rather than extending u32 itself. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html