Re: linux-4.2-rc1/samples/bpf/sockex3_kern.c: bad expression ?

2015-07-07 Thread Alexei Starovoitov 
On Tue, Jul 07, 2015 at 11:27:55AM +, David Binderman wrote:
 Hello there,
 
 [linux-4.2-rc1/samples/bpf/sockex3_kern.c:268]: (style) Expression '(X  
 0xf0) == 0x4' is always false.
 
 Source code is
 
    if ((verlen  0xF0) == 4)
 
 Maybe
 
    if ((verlen  0xF0) == 0x40)

oops, yes. Could you please send a patch to fix it. Thx

--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: linux-4.2-rc1/samples/bpf/sockex3_kern.c: bad expression ?

2015-07-07 Thread David Binderman 
Hello there Alexei,


 oops, yes. Could you please send a patch to fix it. 

Sorry, but I gave up trying to do kernel patches many years ago.

Regards

David Binderman

  --
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html