Re: [2.6 patch] drivers/char/random.c: unexport secure_ipv6_port_ephemeral

2006-04-05 Thread Stephen Hemminger 
On Wed, 5 Apr 2006 18:36:10 +0200
Adrian Bunk <[EMAIL PROTECTED]> wrote:

> This patch removes the unused EXPORT_SYMBOL(secure_ipv6_port_ephemeral).
> 
> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
> 
> --- linux-2.6.17-rc1-mm1-full/drivers/char/random.c.old   2006-04-05 
> 17:00:04.0 +0200
> +++ linux-2.6.17-rc1-mm1-full/drivers/char/random.c   2006-04-05 
> 17:00:22.0 +0200
> @@ -1584,7 +1584,6 @@
>  
>   return twothirdsMD4Transform(daddr, hash);
>  }
> -EXPORT_SYMBOL(secure_ipv6_port_ephemeral);
>  #endif
>  
>  #if defined(CONFIG_IP_DCCP) || defined(CONFIG_IP_DCCP_MODULE)
> 
> -
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to [EMAIL PROTECTED]
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

NAK

If IPV6 is built as a module, then it is needed.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [2.6 patch] drivers/char/random.c: unexport secure_ipv6_port_ephemeral

2006-04-05 Thread Adrian Bunk 
On Wed, Apr 05, 2006 at 10:11:11AM -0700, Stephen Hemminger wrote:
> On Wed, 5 Apr 2006 18:36:10 +0200
> Adrian Bunk <[EMAIL PROTECTED]> wrote:
> 
> > This patch removes the unused EXPORT_SYMBOL(secure_ipv6_port_ephemeral).
> > 
> > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
> > 
> > --- linux-2.6.17-rc1-mm1-full/drivers/char/random.c.old 2006-04-05 
> > 17:00:04.0 +0200
> > +++ linux-2.6.17-rc1-mm1-full/drivers/char/random.c 2006-04-05 
> > 17:00:22.0 +0200
> > @@ -1584,7 +1584,6 @@
> >  
> > return twothirdsMD4Transform(daddr, hash);
> >  }
> > -EXPORT_SYMBOL(secure_ipv6_port_ephemeral);
> >  #endif
> >  
> >  #if defined(CONFIG_IP_DCCP) || defined(CONFIG_IP_DCCP_MODULE)
> > 
> > -
> > To unsubscribe from this list: send the line "unsubscribe netdev" in
> > the body of a message to [EMAIL PROTECTED]
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> NAK
> 
> If IPV6 is built as a module, then it is needed.

No, it isn't:
  obj-$(subst m,y,$(CONFIG_IPV6)) += inet6_hashtables.o

cu
Adrian

-- 

   "Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
   "Only a promise," Lao Er said.
   Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [2.6 patch] drivers/char/random.c: unexport secure_ipv6_port_ephemeral

2006-04-09 Thread Matt Mackall 
On Sun, Apr 09, 2006 at 05:58:22PM +0200, Adrian Bunk wrote:
> This patch removes the unused EXPORT_SYMBOL(secure_ipv6_port_ephemeral).

> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
Acked-by: Matt Mackall <[EMAIL PROTECTED]>

Adrian appears to be correct that this doesn't break modular ipv6.
-- 
Mathematics is the supreme nostalgia of our time.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [2.6 patch] drivers/char/random.c: unexport secure_ipv6_port_ephemeral

2006-04-09 Thread David S. Miller 
From: Adrian Bunk <[EMAIL PROTECTED]>
Date: Sun, 9 Apr 2006 17:58:22 +0200

> This patch removes the unused EXPORT_SYMBOL(secure_ipv6_port_ephemeral).
> 
> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>

Applied, thanks Adrian.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html