Re: [HOSTAP] Make debug a run-time option
On Wed, Mar 14, 2007 at 03:48:00PM -0400, John W. Linville wrote: > What about a combined approach? The existing compile-time option > could remain while runtime restrictions could be added for when the > debug stuff is compiled into the driver? I would be perfectly fine with doing that assuming the default behavior is not changed with this patch (i.e., debugging would be enabled by default). I would consider changing the default setting a separate issue and for that, it might be more worthwhile approach to identify the debug messages that are undesired by default than to disable everything. -- Jouni MalinenPGP id EFC895FA - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [HOSTAP] Make debug a run-time option
On Wed, Mar 14, 2007 at 05:17:42PM +, Jouni Malinen wrote: > On Wed, Mar 14, 2007 at 12:03:56PM -0400, Kyle McMartin wrote: > > Build-time debugging isn't overly useful for distro kernel folks, nor is > > enabling huge amounts of debug spew by default. Provide the option of > > enabling debugging with module parameters. > > While I understand that it would be difficult to change the debug level > options with binary distributions, I'm not sure whether I would like to > see these changes going in. PRISM2_NO_DEBUG was added to make it > possible to reduce the driver size considerably. In addition, the change What about a combined approach? The existing compile-time option could remain while runtime restrictions could be added for when the debug stuff is compiled into the driver? John -- John W. Linville [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [HOSTAP] Make debug a run-time option
On Wed, Mar 14, 2007 at 12:03:56PM -0400, Kyle McMartin wrote: > Build-time debugging isn't overly useful for distro kernel folks, nor is > enabling huge amounts of debug spew by default. Provide the option of > enabling debugging with module parameters. While I understand that it would be difficult to change the debug level options with binary distributions, I'm not sure whether I would like to see these changes going in. PRISM2_NO_DEBUG was added to make it possible to reduce the driver size considerably. In addition, the change to the default debug categories (i.e., disable all) may make it more difficult to understand reported issues. I would be more open to disabling debug messages one-by-one if there is something specific that can be agreed to cause more harm than benefit with extra output. -- Jouni MalinenPGP id EFC895FA - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
