Re: [PATCH] [02/10] pasemi_mac: Stop using the pci config space accessors for register read/writes

[Olof Johansson]

On Thu, Aug 23, 2007 at 10:31:03AM +1000, Stephen Rothwell wrote:
 On Wed, 22 Aug 2007 09:12:48 -0500 Olof Johansson [EMAIL PROTECTED] wrote:
 
  -static unsigned int read_iob_reg(struct pasemi_mac *mac, unsigned int reg)
  +static inline unsigned int read_iob_reg(struct pasemi_mac *mac, unsigned 
  int reg)
   ^^
 For static functions in C files, we tend not to bother marking them
 inline any more as the compiler does a pretty good job theses days.

Yeah, sloppy coding on my behalf. It was still there from when I
explicitly added noinline during debugging, forgot to take it out
alltogether.

  -   pci_read_config_dword(mac-iob_pdev, reg, val);
  +   val = in_le32(mac-iob_regs+reg);
  +
  return val;
 
 Why not just return in_le32(mac-iob_regs+reg); ?
 And similarly below?

Residual from debugging as well, I had debug hooks showing what was
read/written that I took out, but didn't fix up the surrounding stuff.


Refreshed patch posted separately. Thanks for the feedback.

-Olof
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] [02/10] pasemi_mac: Stop using the pci config space accessors for register read/writes

[Stephen Rothwell]

Hi Olof,

On Wed, 22 Aug 2007 09:12:48 -0500 Olof Johansson [EMAIL PROTECTED] wrote:

 -static unsigned int read_iob_reg(struct pasemi_mac *mac, unsigned int reg)
 +static inline unsigned int read_iob_reg(struct pasemi_mac *mac, unsigned int 
 reg)
  ^^
For static functions in C files, we tend not to bother marking them
inline any more as the compiler does a pretty good job theses days.

  {
   unsigned int val;
  
 - pci_read_config_dword(mac-iob_pdev, reg, val);
 + val = in_le32(mac-iob_regs+reg);
 +
   return val;

Why not just return in_le32(mac-iob_regs+reg); ?
And similarly below?

 +static inline void __iomem * __devinit map_onedev(struct pci_dev *p, int 
 index)
  ^^^
Mixing inline and __*init is just plain silly :-)

 +fallback:
 + /* This is hardcoded and ugly, but we have some firmware versions
 +  * who don't provide the register space in the device tree. Luckily
   ^^^
that

-- 
Cheers,
Stephen Rothwell[EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/


pgp00KliTG9BH.pgp
Description: PGP signature