Re: [PATCH] IP1000A: IC Plus update 2006-08-22
Hi Francois: In 0049-ip1000-switch-to-classical-tx_current-tx_dirty-ring-management.txt: The LastFreedTxBuff/LastTFDHoldAddr/LastTFDHoldCnt stuff in the xmit handler took care of the skb submitted by the upper layer when the ring was full, i.e. too late: the xmit handler now disables queueing (i.e. netif_stop_queue) when the whole Tx ring is completely full. The Tx irq handler does the required work to enable queuing again when some room is made. The remainder of the LastTFDHoldFoo (see ipg_nic_hard_start_xmit and ipg_nic_txfree) is moved to a tx_timeout handler where it imho belongs. It is better to Use tx_timeout than the original one. Thanks for that. Best Regards, Jesse Huang - Original Message - From: Francois Romieu [EMAIL PROTECTED] To: Jesse Huang [EMAIL PROTECTED] Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; linux-kernel@vger.kernel.org; netdev@vger.kernel.org; [EMAIL PROTECTED]; [EMAIL PROTECTED] Sent: Thursday, August 31, 2006 6:43 AM Subject: Re: [PATCH] IP1000A: IC Plus update 2006-08-22 Francois Romieu [EMAIL PROTECTED] : [...] Added: 0043-ip1000-use-the-new-IRQF_-constants-and-the-dma_-alloc-free-_coherent-AP I.txt 0044-ip1000-mixed-case-and-upper-case-removal.txt 0045-ip1000-add-ipg_-r-w-8-16-32-macros.txt Added: 0046-ip1000-kiss-TxBuffDMAhandle-goodbye.txt 0047-ip1000-kiss-RxBuffDMAhandle-goodbye.txt 0048-ip1000-turn-StationAddr-0-1-2-into-an-array.txt 0049-ip1000-switch-to-classical-tx_current-tx_dirty-ring-management.txt The previous branch for the driver at git://electric-eye.fr.zoreil.com/home/romieu/linux-2.6.git has been stored as 'netdev-ipg-20060831.old'. The current one is based on dc709bd and named 'ipg'. Nothing will be pushed tomorrow as I have some bugs to review in different drivers. -- Ueimor - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] IP1000A: IC Plus update 2006-08-22
Francois Romieu [EMAIL PROTECTED] : [...] Added: 0043-ip1000-use-the-new-IRQF_-constants-and-the-dma_-alloc-free-_coherent-AP I.txt 0044-ip1000-mixed-case-and-upper-case-removal.txt 0045-ip1000-add-ipg_-r-w-8-16-32-macros.txt Added: 0046-ip1000-kiss-TxBuffDMAhandle-goodbye.txt 0047-ip1000-kiss-RxBuffDMAhandle-goodbye.txt 0048-ip1000-turn-StationAddr-0-1-2-into-an-array.txt 0049-ip1000-switch-to-classical-tx_current-tx_dirty-ring-management.txt The previous branch for the driver at git://electric-eye.fr.zoreil.com/home/romieu/linux-2.6.git has been stored as 'netdev-ipg-20060831.old'. The current one is based on dc709bd and named 'ipg'. Nothing will be pushed tomorrow as I have some bugs to review in different drivers. -- Ueimor - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] IP1000A: IC Plus update 2006-08-22
Francois Romieu [EMAIL PROTECTED] : Jesse Huang [EMAIL PROTECTED] : [...] Added: 0039-ip1000-cosmetic-in-ipg_interrupt_handler.txt 0040-ip1000-irq-handler-and-device-close-race.txt 0041-ip1000-schedule-the-host-error-recovery-to-user-context.txt 0042-ip1000-no-need-to-mask-a-constant-field-with-RSVD_MASK.txt Added: 0043-ip1000-use-the-new-IRQF_-constants-and-the-dma_-alloc-free-_coherent-API.txt 0044-ip1000-mixed-case-and-upper-case-removal.txt 0045-ip1000-add-ipg_-r-w-8-16-32-macros.txt The patches beyond 0043 are only available through HTTP. Since 0043 needs a recent enough kernel and the current driver has branched from an old release, I plan to rebase my branch. Does it raise any objection or remark ? -- Ueimor - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] IP1000A: IC Plus update 2006-08-22
It's Ok. Thanks for that. Jesse - Original Message - From: Francois Romieu [EMAIL PROTECTED] To: Jesse Huang [EMAIL PROTECTED] Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; linux-kernel@vger.kernel.org; netdev@vger.kernel.org; [EMAIL PROTECTED]; [EMAIL PROTECTED] Sent: Monday, August 28, 2006 6:08 AM Subject: Re: [PATCH] IP1000A: IC Plus update 2006-08-22 Francois Romieu [EMAIL PROTECTED] : Jesse Huang [EMAIL PROTECTED] : [...] Added: 0039-ip1000-cosmetic-in-ipg_interrupt_handler.txt 0040-ip1000-irq-handler-and-device-close-race.txt 0041-ip1000-schedule-the-host-error-recovery-to-user-context.txt 0042-ip1000-no-need-to-mask-a-constant-field-with-RSVD_MASK.txt Added: 0043-ip1000-use-the-new-IRQF_-constants-and-the-dma_-alloc-free-_coherent-AP I.txt 0044-ip1000-mixed-case-and-upper-case-removal.txt 0045-ip1000-add-ipg_-r-w-8-16-32-macros.txt The patches beyond 0043 are only available through HTTP. Since 0043 needs a recent enough kernel and the current driver has branched from an old release, I plan to rebase my branch. Does it raise any objection or remark ? -- Ueimor - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] IP1000A: IC Plus update 2006-08-22
Jesse Huang [EMAIL PROTECTED] : [...] Added: 0039-ip1000-cosmetic-in-ipg_interrupt_handler.txt 0040-ip1000-irq-handler-and-device-close-race.txt 0041-ip1000-schedule-the-host-error-recovery-to-user-context.txt 0042-ip1000-no-need-to-mask-a-constant-field-with-RSVD_MASK.txt ipg_reset() may still delay for several ms in irq context :o( -- Ueimor - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] IP1000A: IC Plus update 2006-08-22
Francois Romieu [EMAIL PROTECTED] : [...] or as a serie of patches at: http://www.fr.zoreil.com/linux/2.6.x/2.6.18-rc4/ip1000 Typo. It should be: http://www.fr.zoreil.com/linux/kernel/2.6.x/2.6.18-rc4/ip1000 -- Ueimor - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] IP1000A: IC Plus update 2006-08-22
Francois Romieu [EMAIL PROTECTED] : [...] Typo. It should be: http://www.fr.zoreil.com/linux/kernel/2.6.x/2.6.18-rc4/ip1000 Added 0038-ip1000-CodingStyle.txt. More local variables, more unsigned int, less MixedCase, ipg_nic_rx() fits in your favorite 80 cols console. -- Ueimor - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] IP1000A: IC Plus update 2006-08-22
Hi Francois: I am very appreciated what you do for IP1000A. I will follow those files. Thanks you very much! Best Regards, Jesse Huang - Original Message - From: Francois Romieu [EMAIL PROTECTED] To: Jesse Huang [EMAIL PROTECTED] Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; linux-kernel@vger.kernel.org; netdev@vger.kernel.org; [EMAIL PROTECTED] Sent: Thursday, August 24, 2006 6:30 AM Subject: Re: [PATCH] IP1000A: IC Plus update 2006-08-22 Francois Romieu [EMAIL PROTECTED] : [...] Typo. It should be: http://www.fr.zoreil.com/linux/kernel/2.6.x/2.6.18-rc4/ip1000 Added 0038-ip1000-CodingStyle.txt. More local variables, more unsigned int, less MixedCase, ipg_nic_rx() fits in your favorite 80 cols console. -- Ueimor - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] IP1000A: IC Plus update 2006-08-22
On Tue, 22 Aug 2006 13:37:14 -0400 Jesse Huang wrote:
Dear All:
I had regenerate this patch from:
git://git.kernel.org/pub/scm/linux/kernel/git/penberg/netdev-ipg-2.6.git
And, submit those modifications as one patch.
Add: Remove and add some whitespace
From: Jesse Huang [EMAIL PROTECTED]
Change Logs:
- update maintainer information
- remove some default phy params
- remove threshold config from ipg_io_config
- ip1000 ipg_config_autoneg rewrite
- modify coding style of ipg_config_autoneg
- Add IPG_AC_FIFO flag when Tx reset
- For compatible at PCI 66MHz issue
- Remove and add some whitespace
Signed-off-by: Jesse Huang [EMAIL PROTECTED]
- u8 phyctrl;
+ long mac_ctrl_value;
Should mac_ctrl_value be unsigned long or u32 instead of signed long?
We try to keep source lines limited to 80 columns when feasible
so that they fit nicely into an xterm. There are a few lines here
that are 80 columns.
+ if((NextToFree != sp-CurrentTFD) (NextToFree !=
CurrentTxTFDPtr))
+ {
Style: need space after if; opening brace not on line by itself.
+ // Re-configure after DMA reset.
Line ends with a space. :(
+ if (sp-ResetCurrentTFD != 0)
+ {
Opening brace not on line by itself -- put it on the previous line,
with a space between ) and {.
+ if (sp-LastTFDHoldAddr == sp-CurrentTFD) sp-LastTFDHoldCnt++;
+ else {sp-LastTFDHoldAddr = sp-CurrentTFD;
sp-LastTFDHoldCnt=0; }
Split lines as:
if (condition)
action;
else {
action2;
}
---
~Randy
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] IP1000A: IC Plus update 2006-08-22
Jesse Huang [EMAIL PROTECTED] : Dear All: I had regenerate this patch from: git://git.kernel.org/pub/scm/linux/kernel/git/penberg/netdev-ipg-2.6.git And, submit those modifications as one patch. The suggestion was probably to submit the whole driver as one patch to akpm for wider testing when it is ready (it still is a bit rough imho). Unrelated changes make more sense in incremental, isolated patches as you used to submit before. I have made some surgery to apply your previous patchset with former descriptive commit messages, plus your recent codingstyle changes and a few more. You'll find it either in branch 'netdev-ipg' at: git://electric-eye.fr.zoreil.com/home/romieu/linux-2.6.git or as a serie of patches at: http://www.fr.zoreil.com/linux/2.6.x/2.6.18-rc4/ip1000 The serie of patches comes straight from the (now old) git tree. It applies correctly against 2.6.18-git-of-the-day. The result should not be too far from penberg git + your all-in-one patch but I have not checked it yet. I'd appreciate if you could review it. -- Ueimor - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
